Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: aws_quicksight_vpc_connection ID validation rules are broken #39228

Closed
cwthrivent opened this issue Sep 9, 2024 · 4 comments · Fixed by #39231
Closed

[Bug]: aws_quicksight_vpc_connection ID validation rules are broken #39228

cwthrivent opened this issue Sep 9, 2024 · 4 comments · Fixed by #39231
Assignees
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/quicksight Issues and PRs that pertain to the quicksight service.
Milestone

Comments

@cwthrivent
Copy link

cwthrivent commented Sep 9, 2024

Terraform Core Version

1.9.2

AWS Provider Version

5.66.0

Affected Resource(s)

aws_quicksight_vpc_connection

Expected Behavior

Terraform should plan successfully when specifying vpc_connection_id = "main" in the aws_quicksight_vpc_connection resource.

Actual Behavior

The Terraform plan fails with an error saying that the provided vpc_connection_id is not valid. I have tested my aws_quicksight_vpc_connection resource configuration on AWS provider v5.65.0, and it plans and applies without issue. The problem appears to have been introduced starting in v5.66.0.

Relevant Error/Panic Output Snippet

│ Error: Invalid Attribute Value Match
│ 
│   with aws_quicksight_vpc_connection.main,
│   on quicksight.tf line 14, in resource "aws_quicksight_vpc_connection" "main":
│   14:   vpc_connection_id  = "main"
│ 
│ Attribute vpc_connection_id value must match regular expression
│ '[\\w\\-]+', got: main

Terraform Configuration Files

Code
resource "aws_vpc" "example" {
  cidr_block           = "10.29.0.0/16"
  enable_dns_hostnames = true
}

resource "aws_subnet" "example" {
  vpc_id            = aws_vpc.example.id
  cidr_block        = "10.29.16.0/21"
  availability_zone = "us-east-2a"
}

data "aws_iam_policy_document" "quicksight_assume_role_policy" {
  statement {
    effect  = "Allow"
    actions = ["sts:AssumeRole"]
    principals {
      type        = "Service"
      identifiers = ["quicksight.amazonaws.com"]
    }
  }
}

resource "aws_iam_role" "quicksight_vpc_connection" {
  name = "quicksight-vpc-connection"

  assume_role_policy = data.aws_iam_policy_document.quicksight_assume_role_policy.json
}

resource "aws_security_group" "quicksight_connection" {
  name        = "quicksight"
  description = "Allows traffic to and from the QuickSight VPC connection"
  vpc_id      = aws_vpc.example.id

  ingress {
    from_port   = 0
    to_port     = 65535
    protocol    = "tcp"
    cidr_blocks = ["10.0.0.0/8"]
  }

  egress {
    from_port   = 0
    to_port     = 65535
    protocol    = "tcp"
    cidr_blocks = ["10.0.0.0/8"]
  }
}

resource "aws_quicksight_vpc_connection" "main" {
  vpc_connection_id  = "main"
  name               = "main"
  role_arn           = aws_iam_role.quicksight_vpc_connection.arn
  security_group_ids = [aws_security_group.quicksight_connection.id]
  subnet_ids = [
    aws_subnet.example.id
  ]
}

Steps to Reproduce

Run a plan using the provided Terraform code on AWS provider v5.66.0.

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

@cwthrivent cwthrivent added the bug Addresses a defect in current functionality. label Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/quicksight Issues and PRs that pertain to the quicksight service. service/vpc Issues and PRs that pertain to the vpc service. needs-triage Waiting for first response or review from a maintainer. service/iam Issues and PRs that pertain to the iam service. labels Sep 9, 2024
@ewbankkit ewbankkit added regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. and removed service/iam Issues and PRs that pertain to the iam service. service/vpc Issues and PRs that pertain to the vpc service. needs-triage Waiting for first response or review from a maintainer. labels Sep 9, 2024
@ewbankkit ewbankkit self-assigned this Sep 9, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.67.0 milestone Sep 9, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 13, 2024
Copy link

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/quicksight Issues and PRs that pertain to the quicksight service.
Projects
None yet
2 participants