-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_s3_bucket_server_side_encryption_configuration: S3 directory buckets now support SSE-KMS #39366
Conversation
…eException: The runtime parameter of nodejs14.x is no longer supported for creating or updating AWS Lambda functions. We recommend you use a supported runtime while creating or updating functions' in acceptance tests.
% make testacc TESTARGS='-run=TestAccS3BucketServerSideEncryptionConfiguration_directoryBucket' PKG=s3 ACCTEST_PARALLELISM=3 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.0 test ./internal/service/s3/... -v -count 1 -parallel 3 -run=TestAccS3BucketServerSideEncryptionConfiguration_directoryBucket -timeout 360m === RUN TestAccS3BucketServerSideEncryptionConfiguration_directoryBucket === PAUSE TestAccS3BucketServerSideEncryptionConfiguration_directoryBucket === CONT TestAccS3BucketServerSideEncryptionConfiguration_directoryBucket --- PASS: TestAccS3BucketServerSideEncryptionConfiguration_directoryBucket (16.84s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 21.909s
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc TESTARGS='-run=_directoryBucket$$' PKG=s3 ACCTEST_PARALLELISM=5
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/s3/... -v -count 1 -parallel 5 -run=_directoryBucket$ -timeout 360m
--- PASS: TestAccS3BucketLifecycleConfiguration_directoryBucket (9.98s)
=== CONT TestAccS3BucketACL_directoryBucket
--- PASS: TestAccS3BucketAnalyticsConfiguration_directoryBucket (10.11s)
=== CONT TestAccS3BucketInventory_directoryBucket
--- PASS: TestAccS3BucketCORSConfiguration_directoryBucket (10.22s)
=== CONT TestAccS3BucketWebsiteConfiguration_directoryBucket
--- PASS: TestAccS3BucketAccelerateConfiguration_directoryBucket (10.24s)
=== CONT TestAccS3ObjectsDataSource_directoryBucket
--- PASS: TestAccS3BucketPolicy_directoryBucket (17.13s)
=== CONT TestAccS3Object_directoryBucket
--- PASS: TestAccS3BucketACL_directoryBucket (9.15s)
=== CONT TestAccS3ObjectDataSource_directoryBucket
--- PASS: TestAccS3BucketInventory_directoryBucket (9.50s)
=== CONT TestAccS3ObjectCopy_directoryBucket
--- PASS: TestAccS3BucketWebsiteConfiguration_directoryBucket (9.43s)
=== CONT TestAccS3BucketRequestPaymentConfiguration_directoryBucket
--- PASS: TestAccS3ObjectsDataSource_directoryBucket (16.83s)
=== CONT TestAccS3BucketVersioning_directoryBucket
--- PASS: TestAccS3BucketRequestPaymentConfiguration_directoryBucket (9.17s)
=== CONT TestAccS3BucketServerSideEncryptionConfiguration_directoryBucket
--- PASS: TestAccS3ObjectDataSource_directoryBucket (16.91s)
=== CONT TestAccS3BucketReplicationConfiguration_directoryBucket
--- PASS: TestAccS3BucketVersioning_directoryBucket (9.21s)
=== CONT TestAccS3BucketIntelligentTieringConfiguration_directoryBucket
--- PASS: TestAccS3ObjectCopy_directoryBucket (17.89s)
=== CONT TestAccS3BucketNotification_directoryBucket
--- PASS: TestAccS3Object_directoryBucket (20.57s)
=== CONT TestAccS3BucketOwnershipControls_directoryBucket
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_directoryBucket (8.55s)
=== CONT TestAccS3BucketObjectLockConfiguration_directoryBucket
--- PASS: TestAccS3BucketNotification_directoryBucket (8.82s)
=== CONT TestAccS3BucketMetric_directoryBucket
--- PASS: TestAccS3BucketOwnershipControls_directoryBucket (8.92s)
=== CONT TestAccS3BucketLogging_directoryBucket
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_directoryBucket (19.77s)
=== CONT TestAccS3BucketPublicAccessBlock_directoryBucket
--- PASS: TestAccS3BucketReplicationConfiguration_directoryBucket (13.87s)
--- PASS: TestAccS3BucketObjectLockConfiguration_directoryBucket (9.12s)
--- PASS: TestAccS3BucketMetric_directoryBucket (8.98s)
--- PASS: TestAccS3BucketPublicAccessBlock_directoryBucket (8.41s)
--- PASS: TestAccS3BucketLogging_directoryBucket (13.26s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 66.133s
This functionality has been released in v5.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
S3 directory buckets now support SSE-KMS.
Relations
Closes #39365.
Output from Acceptance Testing