Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_sagemaker_workteam: Fix workforce_name: WorkforceName is misconfigured as Required. #39630

Merged

Conversation

trutled3
Copy link
Contributor

@trutled3 trutled3 commented Oct 8, 2024

Description

This pull request fixes the workforce_name argument to be Optional. This argument is optional via the AWS SDK v2 for Golang here and is documented as optional on AWS official documentation here

Relations

Closes #39488

References

Output from Acceptance Testing

% make testacc TESTS=TestAccWorkteam_cognitoOmitWorkforceName PKG=sagemaker
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccWorkteam_cognitoOmitWorkforceName' -timeout 360m
=== RUN   TestAccWorkteam_cognitoOmitWorkforceName
--- PASS: TestAccWorkteam_cognitoOmitWorkforceName (22.29s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  27.559s

@trutled3 trutled3 requested a review from a team as a code owner October 8, 2024 19:41
Copy link

github-actions bot commented Oct 8, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. needs-triage Waiting for first response or review from a maintainer. labels Oct 8, 2024
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 9, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSageMaker_serial/Workteam/Cognito' PKG=sagemaker
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/sagemaker/... -v -count 1 -parallel 20  -run=TestAccSageMaker_serial/Workteam/Cognito -timeout 360m
=== RUN   TestAccSageMaker_serial
=== PAUSE TestAccSageMaker_serial
=== CONT  TestAccSageMaker_serial
=== RUN   TestAccSageMaker_serial/Workteam
=== RUN   TestAccSageMaker_serial/Workteam/CognitoConfig
=== RUN   TestAccSageMaker_serial/Workteam/CognitoOmitWorkforceName
--- PASS: TestAccSageMaker_serial (125.23s)
    --- PASS: TestAccSageMaker_serial/Workteam (125.23s)
        --- PASS: TestAccSageMaker_serial/Workteam/CognitoConfig (108.77s)
        --- PASS: TestAccSageMaker_serial/Workteam/CognitoOmitWorkforceName (16.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	130.479s

@ewbankkit
Copy link
Contributor

@trutled3 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 4a19c19 into hashicorp:main Oct 9, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.71.0 milestone Oct 9, 2024
@trutled3 trutled3 deleted the b-sagemaker_workteam_workforce_name branch October 9, 2024 16:15
Copy link

This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_sagemaker_workteam workforce_name is not a required field
2 participants