Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new datasource spot datafeed subscription #39647

Merged
merged 10 commits into from
Nov 6, 2024
Merged

feat: new datasource spot datafeed subscription #39647

merged 10 commits into from
Nov 6, 2024

Conversation

stefanfreitag
Copy link
Contributor

Description

From #39259:
This is a data source that mirrors the aws_spot_datafeed_subscription resource. Every AWS account is allowed up to one spot data-feed subscription, which updates an s3 bucket with the latest EC2 spot instance prices.

Relations

Closes #39259

References

Copied from #39259:

Output from Acceptance Testing

❯ make testacc TESTS=TestAccEC2SpotDataFeedSubscriptionDataSource_basic PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SpotDataFeedSubscriptionDataSource_basic'  -timeout 360m
=== RUN   TestAccEC2SpotDataFeedSubscriptionDataSource_basic
=== PAUSE TestAccEC2SpotDataFeedSubscriptionDataSource_basic
=== CONT  TestAccEC2SpotDataFeedSubscriptionDataSource_basic
--- PASS: TestAccEC2SpotDataFeedSubscriptionDataSource_basic (39.80s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        39.947s
...

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. labels Oct 9, 2024
@stefanfreitag
fix: improve formatting
9bedd06 
- fix import  issues
- fix markdown issues
- fix terraform format issues
@stefanfreitag
chore: add changelog entry
42f2eed
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 11, 2024
@stefanfreitag stefanfreitag force-pushed the f-aws_spot_datafeed_subscription branch from 4d31146 to ae7f18e Compare October 13, 2024 17:12
@stefanfreitag stefanfreitag marked this pull request as ready for review October 13, 2024 19:03
@stefanfreitag stefanfreitag requested a review from a team as a code owner October 13, 2024 19:03
@stefanfreitag stefanfreitag deleted the f-aws_spot_datafeed_subscription branch October 18, 2024 18:00
@stefanfreitag stefanfreitag restored the f-aws_spot_datafeed_subscription branch October 18, 2024 18:00
@stefanfreitag stefanfreitag reopened this Oct 18, 2024
@jar-b
Merge branch 'main' into f-aws_spot_datafeed_subscription
61bfe2c
@jar-b
Merge branch 'main' into f-aws_spot_datafeed_subscription
16d1307
@jar-b
d/aws_spot_datafeed_subscription: convert to Terraform Plugin Framework
97cc366
@jar-b
d/aws_spot_datafeed_subscription(test): serialize tests
a0ed347 
```console
% make testacc PKG=ec2 TESTS=TestAccEC2SpotDatafeedSubscription_serial/
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SpotDatafeedSubscription_serial/'  -timeout 360m
2024/11/06 13:26:03 Initializing Terraform AWS Provider...

--- PASS: TestAccEC2SpotDatafeedSubscription_serial (63.60s)
    --- PASS: TestAccEC2SpotDatafeedSubscription_serial/SpotDatafeedSubscription (43.38s)
        --- PASS: TestAccEC2SpotDatafeedSubscription_serial/SpotDatafeedSubscription/basic (23.09s)
        --- PASS: TestAccEC2SpotDatafeedSubscription_serial/SpotDatafeedSubscription/disappears (20.29s)
    --- PASS: TestAccEC2SpotDatafeedSubscription_serial/SpotDatafeedSubscriptionDataSource (20.22s)
        --- PASS: TestAccEC2SpotDatafeedSubscription_serial/SpotDatafeedSubscriptionDataSource/basic (20.22s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        70.306s
```
@jar-b
d/aws_spot_datafeed_subscription(doc): tweak note
b645e82
jar-b
jar-b approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=ec2 TESTS=TestAccEC2SpotDatafeedSubscription_serial/
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SpotDatafeedSubscription_serial/'  -timeout 360m
2024/11/06 13:26:03 Initializing Terraform AWS Provider...

--- PASS: TestAccEC2SpotDatafeedSubscription_serial (63.60s)
    --- PASS: TestAccEC2SpotDatafeedSubscription_serial/SpotDatafeedSubscription (43.38s)
        --- PASS: TestAccEC2SpotDatafeedSubscription_serial/SpotDatafeedSubscription/basic (23.09s)
        --- PASS: TestAccEC2SpotDatafeedSubscription_serial/SpotDatafeedSubscription/disappears (20.29s)
    --- PASS: TestAccEC2SpotDatafeedSubscription_serial/SpotDatafeedSubscriptionDataSource (20.22s)
        --- PASS: TestAccEC2SpotDatafeedSubscription_serial/SpotDatafeedSubscriptionDataSource/basic (20.22s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        70.306s

@jar-b
Copy link
Member

jar-b commented Nov 6, 2024

Thanks for your contribution, @stefanfreitag! 👍

@jar-b jar-b merged commit b9546f5 into hashicorp:main Nov 6, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.75.0 milestone Nov 6, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.75.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.75.0
Development

Successfully merging this pull request may close these issues.

[New Data Source]: aws_spot_datafeed_subscription
3 participants
@stefanfreitag @jar-b @justinretzolk