-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: aws_cloudwatch_event_rule update with tags #39648
fix: aws_cloudwatch_event_rule update with tags #39648
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @pedrokiefer 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEventsRule_' PKG=events ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/events/... -v -count 1 -parallel 3 -run=TestAccEventsRule_ -timeout 360m
2024/10/15 10:34:35 Initializing Terraform AWS Provider...
=== RUN TestAccEventsRule_basic
=== PAUSE TestAccEventsRule_basic
=== RUN TestAccEventsRule_eventBusName
=== PAUSE TestAccEventsRule_eventBusName
=== RUN TestAccEventsRule_role
=== PAUSE TestAccEventsRule_role
=== RUN TestAccEventsRule_description
=== PAUSE TestAccEventsRule_description
=== RUN TestAccEventsRule_pattern
=== PAUSE TestAccEventsRule_pattern
=== RUN TestAccEventsRule_patternJSONEncoder
=== PAUSE TestAccEventsRule_patternJSONEncoder
=== RUN TestAccEventsRule_scheduleAndPattern
=== PAUSE TestAccEventsRule_scheduleAndPattern
=== RUN TestAccEventsRule_namePrefix
=== PAUSE TestAccEventsRule_namePrefix
=== RUN TestAccEventsRule_Name_generated
=== PAUSE TestAccEventsRule_Name_generated
=== RUN TestAccEventsRule_tags
=== PAUSE TestAccEventsRule_tags
=== RUN TestAccEventsRule_isEnabled
=== PAUSE TestAccEventsRule_isEnabled
=== RUN TestAccEventsRule_state
=== PAUSE TestAccEventsRule_state
=== RUN TestAccEventsRule_partnerEventBus
rule_test.go:699: Environment variable EVENT_BRIDGE_PARTNER_EVENT_BUS_NAME is not set
--- SKIP: TestAccEventsRule_partnerEventBus (0.00s)
=== RUN TestAccEventsRule_eventBusARN
=== PAUSE TestAccEventsRule_eventBusARN
=== RUN TestAccEventsRule_migrateV0
=== PAUSE TestAccEventsRule_migrateV0
=== RUN TestAccEventsRule_migrateV0_Equivalent
=== PAUSE TestAccEventsRule_migrateV0_Equivalent
=== CONT TestAccEventsRule_basic
=== CONT TestAccEventsRule_Name_generated
=== CONT TestAccEventsRule_pattern
--- PASS: TestAccEventsRule_Name_generated (14.75s)
=== CONT TestAccEventsRule_scheduleAndPattern
--- PASS: TestAccEventsRule_pattern (22.65s)
=== CONT TestAccEventsRule_namePrefix
--- PASS: TestAccEventsRule_scheduleAndPattern (13.12s)
=== CONT TestAccEventsRule_patternJSONEncoder
--- PASS: TestAccEventsRule_basic (31.83s)
=== CONT TestAccEventsRule_eventBusARN
--- PASS: TestAccEventsRule_namePrefix (12.91s)
=== CONT TestAccEventsRule_migrateV0_Equivalent
=== RUN TestAccEventsRule_migrateV0_Equivalent/enabled
=== PAUSE TestAccEventsRule_migrateV0_Equivalent/enabled
=== RUN TestAccEventsRule_migrateV0_Equivalent/disabled
=== PAUSE TestAccEventsRule_migrateV0_Equivalent/disabled
=== CONT TestAccEventsRule_migrateV0
=== RUN TestAccEventsRule_migrateV0/basic
=== PAUSE TestAccEventsRule_migrateV0/basic
=== RUN TestAccEventsRule_migrateV0/enabled
=== PAUSE TestAccEventsRule_migrateV0/enabled
=== RUN TestAccEventsRule_migrateV0/disabled
=== PAUSE TestAccEventsRule_migrateV0/disabled
=== CONT TestAccEventsRule_role
--- PASS: TestAccEventsRule_patternJSONEncoder (10.35s)
=== CONT TestAccEventsRule_description
--- PASS: TestAccEventsRule_eventBusARN (13.87s)
=== CONT TestAccEventsRule_isEnabled
--- PASS: TestAccEventsRule_role (23.68s)
=== CONT TestAccEventsRule_state
--- PASS: TestAccEventsRule_description (21.31s)
=== CONT TestAccEventsRule_tags
--- PASS: TestAccEventsRule_isEnabled (32.36s)
=== CONT TestAccEventsRule_eventBusName
--- PASS: TestAccEventsRule_state (23.61s)
=== CONT TestAccEventsRule_migrateV0_Equivalent/enabled
--- PASS: TestAccEventsRule_tags (29.96s)
=== CONT TestAccEventsRule_migrateV0_Equivalent/disabled
--- PASS: TestAccEventsRule_eventBusName (34.11s)
=== CONT TestAccEventsRule_migrateV0/basic
=== CONT TestAccEventsRule_migrateV0/disabled
--- PASS: TestAccEventsRule_migrateV0_Equivalent (0.00s)
--- PASS: TestAccEventsRule_migrateV0_Equivalent/enabled (34.05s)
--- PASS: TestAccEventsRule_migrateV0_Equivalent/disabled (36.71s)
=== CONT TestAccEventsRule_migrateV0/enabled
--- PASS: TestAccEventsRule_migrateV0 (0.00s)
--- PASS: TestAccEventsRule_migrateV0/basic (40.37s)
--- PASS: TestAccEventsRule_migrateV0/disabled (37.61s)
--- PASS: TestAccEventsRule_migrateV0/enabled (33.26s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/events 164.546s
@pedrokiefer Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Populate
Tags
field when updating an event rule.Relations
Closes #39646
References
Output from Acceptance Testing