Update record.go allow ttl to be 0

[cortico-aws]

Description

Updated route53/record.go to allow creation of record with ttl = 0.

Relations

Closes #36411

References

#36411

Output from Acceptance Testing

terraform-provider-aws % go test ./internal/service/route53/...
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53 

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @cortico-aws 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRoute53Record_' PKG=route53 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/route53/... -v -count 1 -parallel 3  -run=TestAccRoute53Record_ -timeout 360m
2024/10/16 16:04:27 Initializing Terraform AWS Provider...
=== RUN   TestAccRoute53Record_basic
=== PAUSE TestAccRoute53Record_basic
=== RUN   TestAccRoute53Record_disappears
=== PAUSE TestAccRoute53Record_disappears
=== RUN   TestAccRoute53Record_Disappears_multipleRecords
=== PAUSE TestAccRoute53Record_Disappears_multipleRecords
=== RUN   TestAccRoute53Record_underscored
=== PAUSE TestAccRoute53Record_underscored
=== RUN   TestAccRoute53Record_fqdn
=== PAUSE TestAccRoute53Record_fqdn
=== RUN   TestAccRoute53Record_trailingPeriodAndZoneID
=== PAUSE TestAccRoute53Record_trailingPeriodAndZoneID
=== RUN   TestAccRoute53Record_Support_txt
=== PAUSE TestAccRoute53Record_Support_txt
=== RUN   TestAccRoute53Record_Support_spf
=== PAUSE TestAccRoute53Record_Support_spf
=== RUN   TestAccRoute53Record_Support_caa
=== PAUSE TestAccRoute53Record_Support_caa
=== RUN   TestAccRoute53Record_Support_ds
=== PAUSE TestAccRoute53Record_Support_ds
=== RUN   TestAccRoute53Record_generatesSuffix
=== PAUSE TestAccRoute53Record_generatesSuffix
=== RUN   TestAccRoute53Record_wildcard
=== PAUSE TestAccRoute53Record_wildcard
=== RUN   TestAccRoute53Record_failover
=== PAUSE TestAccRoute53Record_failover
=== RUN   TestAccRoute53Record_Weighted_basic
=== PAUSE TestAccRoute53Record_Weighted_basic
=== RUN   TestAccRoute53Record_WeightedToSimple_basic
=== PAUSE TestAccRoute53Record_WeightedToSimple_basic
=== RUN   TestAccRoute53Record_Alias_elb
=== PAUSE TestAccRoute53Record_Alias_elb
=== RUN   TestAccRoute53Record_Alias_s3
=== PAUSE TestAccRoute53Record_Alias_s3
=== RUN   TestAccRoute53Record_Alias_vpcEndpoint
=== PAUSE TestAccRoute53Record_Alias_vpcEndpoint
=== RUN   TestAccRoute53Record_Alias_uppercase
=== PAUSE TestAccRoute53Record_Alias_uppercase
=== RUN   TestAccRoute53Record_Weighted_alias
=== PAUSE TestAccRoute53Record_Weighted_alias
=== RUN   TestAccRoute53Record_cidr
=== PAUSE TestAccRoute53Record_cidr
=== RUN   TestAccRoute53Record_Geolocation_basic
=== PAUSE TestAccRoute53Record_Geolocation_basic
=== RUN   TestAccRoute53Record_Geoproximity_basic
=== PAUSE TestAccRoute53Record_Geoproximity_basic
=== RUN   TestAccRoute53Record_HealthCheckID_setIdentifierChange
=== PAUSE TestAccRoute53Record_HealthCheckID_setIdentifierChange
=== RUN   TestAccRoute53Record_HealthCheckID_typeChange
=== PAUSE TestAccRoute53Record_HealthCheckID_typeChange
=== RUN   TestAccRoute53Record_Latency_basic
=== PAUSE TestAccRoute53Record_Latency_basic
=== RUN   TestAccRoute53Record_typeChange
=== PAUSE TestAccRoute53Record_typeChange
=== RUN   TestAccRoute53Record_nameChange
=== PAUSE TestAccRoute53Record_nameChange
=== RUN   TestAccRoute53Record_setIdentifierChangeBasicToWeighted
=== PAUSE TestAccRoute53Record_setIdentifierChangeBasicToWeighted
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationContinent
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationContinent
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified
=== RUN   TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision
=== RUN   TestAccRoute53Record_SetIdentifierRename_geoproximityRegion
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geoproximityRegion
=== RUN   TestAccRoute53Record_SetIdentifierRename_geoproximityLocalZoneGroup
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geoproximityLocalZoneGroup
=== RUN   TestAccRoute53Record_SetIdentifierRename_geoproximityCoordinates
=== PAUSE TestAccRoute53Record_SetIdentifierRename_geoproximityCoordinates
=== RUN   TestAccRoute53Record_SetIdentifierRename_failover
=== PAUSE TestAccRoute53Record_SetIdentifierRename_failover
=== RUN   TestAccRoute53Record_SetIdentifierRename_latency
=== PAUSE TestAccRoute53Record_SetIdentifierRename_latency
=== RUN   TestAccRoute53Record_SetIdentifierRename_multiValueAnswer
=== PAUSE TestAccRoute53Record_SetIdentifierRename_multiValueAnswer
=== RUN   TestAccRoute53Record_SetIdentifierRename_weighted
=== PAUSE TestAccRoute53Record_SetIdentifierRename_weighted
=== RUN   TestAccRoute53Record_Alias_change
=== PAUSE TestAccRoute53Record_Alias_change
=== RUN   TestAccRoute53Record_Alias_changeDualstack
=== PAUSE TestAccRoute53Record_Alias_changeDualstack
=== RUN   TestAccRoute53Record_empty
=== PAUSE TestAccRoute53Record_empty
=== RUN   TestAccRoute53Record_longTXTrecord
=== PAUSE TestAccRoute53Record_longTXTrecord
=== RUN   TestAccRoute53Record_MultiValueAnswer_basic
=== PAUSE TestAccRoute53Record_MultiValueAnswer_basic
=== RUN   TestAccRoute53Record_Allow_doNotOverwrite
=== PAUSE TestAccRoute53Record_Allow_doNotOverwrite
=== RUN   TestAccRoute53Record_Allow_overwrite
=== PAUSE TestAccRoute53Record_Allow_overwrite
=== RUN   TestAccRoute53Record_ttl0
=== PAUSE TestAccRoute53Record_ttl0
=== CONT  TestAccRoute53Record_basic
=== CONT  TestAccRoute53Record_ttl0
=== CONT  TestAccRoute53Record_HealthCheckID_typeChange
--- PASS: TestAccRoute53Record_basic (182.15s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_failover
--- PASS: TestAccRoute53Record_HealthCheckID_typeChange (234.96s)
=== CONT  TestAccRoute53Record_Allow_overwrite
--- PASS: TestAccRoute53Record_ttl0 (267.36s)
=== CONT  TestAccRoute53Record_Allow_doNotOverwrite
--- PASS: TestAccRoute53Record_SetIdentifierRename_failover (230.62s)
=== CONT  TestAccRoute53Record_MultiValueAnswer_basic
--- PASS: TestAccRoute53Record_Allow_doNotOverwrite (166.39s)
=== CONT  TestAccRoute53Record_longTXTrecord
--- PASS: TestAccRoute53Record_Allow_overwrite (211.15s)
=== CONT  TestAccRoute53Record_empty
--- PASS: TestAccRoute53Record_MultiValueAnswer_basic (177.36s)
=== CONT  TestAccRoute53Record_Alias_changeDualstack
--- PASS: TestAccRoute53Record_longTXTrecord (182.29s)
=== CONT  TestAccRoute53Record_Alias_change
--- PASS: TestAccRoute53Record_empty (172.29s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_weighted
--- PASS: TestAccRoute53Record_Alias_changeDualstack (238.76s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_multiValueAnswer
--- PASS: TestAccRoute53Record_SetIdentifierRename_weighted (226.32s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_latency
--- PASS: TestAccRoute53Record_Alias_change (240.34s)
=== CONT  TestAccRoute53Record_failover
--- PASS: TestAccRoute53Record_failover (177.22s)
=== CONT  TestAccRoute53Record_HealthCheckID_setIdentifierChange
--- PASS: TestAccRoute53Record_SetIdentifierRename_multiValueAnswer (220.63s)
=== CONT  TestAccRoute53Record_Geoproximity_basic
--- PASS: TestAccRoute53Record_SetIdentifierRename_latency (220.11s)
=== CONT  TestAccRoute53Record_Geolocation_basic
--- PASS: TestAccRoute53Record_Geoproximity_basic (177.06s)
=== CONT  TestAccRoute53Record_cidr
--- PASS: TestAccRoute53Record_Geolocation_basic (175.56s)
=== CONT  TestAccRoute53Record_Weighted_alias
--- PASS: TestAccRoute53Record_HealthCheckID_setIdentifierChange (228.22s)
=== CONT  TestAccRoute53Record_Alias_uppercase
--- PASS: TestAccRoute53Record_Alias_uppercase (168.93s)
=== CONT  TestAccRoute53Record_Alias_vpcEndpoint
--- PASS: TestAccRoute53Record_cidr (257.46s)
=== CONT  TestAccRoute53Record_Alias_s3
--- PASS: TestAccRoute53Record_Weighted_alias (321.52s)
=== CONT  TestAccRoute53Record_Alias_elb
--- PASS: TestAccRoute53Record_Alias_s3 (160.97s)
=== CONT  TestAccRoute53Record_WeightedToSimple_basic
--- PASS: TestAccRoute53Record_Alias_elb (182.33s)
=== CONT  TestAccRoute53Record_Weighted_basic
--- PASS: TestAccRoute53Record_Alias_vpcEndpoint (337.13s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault
--- PASS: TestAccRoute53Record_WeightedToSimple_basic (231.14s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geoproximityCoordinates
--- PASS: TestAccRoute53Record_Weighted_basic (184.82s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geoproximityLocalZoneGroup
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault (218.22s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geoproximityRegion
--- PASS: TestAccRoute53Record_SetIdentifierRename_geoproximityCoordinates (232.42s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision
--- PASS: TestAccRoute53Record_SetIdentifierRename_geoproximityLocalZoneGroup (220.16s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified
--- PASS: TestAccRoute53Record_SetIdentifierRename_geoproximityRegion (205.63s)
=== CONT  TestAccRoute53Record_nameChange
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision (231.69s)
=== CONT  TestAccRoute53Record_SetIdentifierRename_geolocationContinent
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified (241.64s)
=== CONT  TestAccRoute53Record_setIdentifierChangeBasicToWeighted
--- PASS: TestAccRoute53Record_nameChange (246.56s)
=== CONT  TestAccRoute53Record_typeChange
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationContinent (230.77s)
=== CONT  TestAccRoute53Record_Support_txt
--- PASS: TestAccRoute53Record_setIdentifierChangeBasicToWeighted (238.11s)
=== CONT  TestAccRoute53Record_underscored
--- PASS: TestAccRoute53Record_typeChange (231.23s)
=== CONT  TestAccRoute53Record_wildcard
--- PASS: TestAccRoute53Record_Support_txt (185.85s)
=== CONT  TestAccRoute53Record_trailingPeriodAndZoneID
--- PASS: TestAccRoute53Record_underscored (195.11s)
=== CONT  TestAccRoute53Record_generatesSuffix
--- PASS: TestAccRoute53Record_wildcard (247.71s)
=== CONT  TestAccRoute53Record_fqdn
--- PASS: TestAccRoute53Record_trailingPeriodAndZoneID (179.23s)
=== CONT  TestAccRoute53Record_Support_ds
--- PASS: TestAccRoute53Record_generatesSuffix (178.03s)
=== CONT  TestAccRoute53Record_Support_caa
--- PASS: TestAccRoute53Record_fqdn (168.88s)
=== CONT  TestAccRoute53Record_Support_spf
--- PASS: TestAccRoute53Record_Support_ds (164.53s)
=== CONT  TestAccRoute53Record_Disappears_multipleRecords
--- PASS: TestAccRoute53Record_Support_caa (177.10s)
=== CONT  TestAccRoute53Record_disappears
--- PASS: TestAccRoute53Record_Support_spf (182.94s)
=== CONT  TestAccRoute53Record_Latency_basic
--- PASS: TestAccRoute53Record_Disappears_multipleRecords (227.78s)
--- PASS: TestAccRoute53Record_disappears (177.97s)
--- PASS: TestAccRoute53Record_Latency_basic (189.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	3463.063s

[ewbankkit]

@cortico-aws Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.