d/aws_workspaces_bundle: Fix multiple WorkSpaces Bundles matched; use additional constraints to reduce matches to a single WorkSpaces Bundle regression

[ewbankkit]

Description

Return the first matching bundle, not the only matching bundle, when searching by name.

Relations

Closes #39775.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccWorkSpacesDataSource_serial/^Bundle$$' PKG=workspaces
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/workspaces/... -v -count 1 -parallel 20  -run=TestAccWorkSpacesDataSource_serial/^Bundle$ -timeout 360m
2024/10/17 13:11:42 Initializing Terraform AWS Provider...
=== RUN   TestAccWorkSpacesDataSource_serial
=== PAUSE TestAccWorkSpacesDataSource_serial
=== CONT  TestAccWorkSpacesDataSource_serial
=== RUN   TestAccWorkSpacesDataSource_serial/Bundle
=== RUN   TestAccWorkSpacesDataSource_serial/Bundle/basic
=== RUN   TestAccWorkSpacesDataSource_serial/Bundle/bundleIDAndNameConflict
=== RUN   TestAccWorkSpacesDataSource_serial/Bundle/byOwnerName
=== RUN   TestAccWorkSpacesDataSource_serial/Bundle/byOwnerNameMultiple
=== RUN   TestAccWorkSpacesDataSource_serial/Bundle/privateOwner
    bundle_data_source_test.go:143: AWS_WORKSPACES_BUNDLE_NAME env var must be set for AWS WorkSpaces private bundle acceptance test. This is required until AWS provides bundle creation API.
--- PASS: TestAccWorkSpacesDataSource_serial (43.22s)
    --- PASS: TestAccWorkSpacesDataSource_serial/Bundle (43.22s)
        --- PASS: TestAccWorkSpacesDataSource_serial/Bundle/basic (8.36s)
        --- PASS: TestAccWorkSpacesDataSource_serial/Bundle/bundleIDAndNameConflict (0.78s)
        --- PASS: TestAccWorkSpacesDataSource_serial/Bundle/byOwnerName (16.86s)
        --- PASS: TestAccWorkSpacesDataSource_serial/Bundle/byOwnerNameMultiple (17.21s)
        --- SKIP: TestAccWorkSpacesDataSource_serial/Bundle/privateOwner (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/workspaces	48.600s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🚀

% make testacc TESTARGS='-run=TestAccWorkSpacesDataSource_serial/^Bundle$$' PKG=workspaces
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/workspaces/... -v -count 1 -parallel 20  -run=TestAccWorkSpacesDataSource_serial/^Bundle$ -timeout 360m
2024/10/17 14:06:26 Initializing Terraform AWS Provider...
=== RUN   TestAccWorkSpacesDataSource_serial
=== PAUSE TestAccWorkSpacesDataSource_serial
=== CONT  TestAccWorkSpacesDataSource_serial
=== RUN   TestAccWorkSpacesDataSource_serial/Bundle
=== RUN   TestAccWorkSpacesDataSource_serial/Bundle/byOwnerNameMultiple
=== RUN   TestAccWorkSpacesDataSource_serial/Bundle/privateOwner
    bundle_data_source_test.go:143: AWS_WORKSPACES_BUNDLE_NAME env var must be set for AWS WorkSpaces private bundle acceptance test. This is required until AWS provides bundle creation API.
=== RUN   TestAccWorkSpacesDataSource_serial/Bundle/basic
=== RUN   TestAccWorkSpacesDataSource_serial/Bundle/bundleIDAndNameConflict
=== RUN   TestAccWorkSpacesDataSource_serial/Bundle/byOwnerName
--- PASS: TestAccWorkSpacesDataSource_serial (43.55s)
    --- PASS: TestAccWorkSpacesDataSource_serial/Bundle (43.55s)
        --- PASS: TestAccWorkSpacesDataSource_serial/Bundle/byOwnerNameMultiple (18.19s)
        --- SKIP: TestAccWorkSpacesDataSource_serial/Bundle/privateOwner (0.00s)
        --- PASS: TestAccWorkSpacesDataSource_serial/Bundle/basic (8.29s)
        --- PASS: TestAccWorkSpacesDataSource_serial/Bundle/bundleIDAndNameConflict (0.74s)
        --- PASS: TestAccWorkSpacesDataSource_serial/Bundle/byOwnerName (16.34s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/workspaces 48.582s

[github-actions]

This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!