r/route53profiles_association: Validate name field against regex

[jandersen-plaid]

Description

Adds a regex validation to the name argument of aws_route53profiles_association to validate that the name matches the regex expected by AWS before creating the resource.

Relations

Closes #39793

References

• https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-route53profiles-profileassociation.html#aws-resource-route53profiles-profileassociation-properties

Output from Acceptance Testing

% make testacc TESTS=TestAccRoute53ProfilesAssociation PKG=route53profiles
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/route53profiles/... -v -count 1 -parallel 20 -run='TestAccRoute53ProfilesAssociation'  -timeout 360m
2024/10/18 12:52:26 Initializing Terraform AWS Provider...
=== RUN   TestAccRoute53ProfilesAssociation_basic
=== PAUSE TestAccRoute53ProfilesAssociation_basic
=== RUN   TestAccRoute53ProfilesAssociation_tags
=== PAUSE TestAccRoute53ProfilesAssociation_tags
=== RUN   TestAccRoute53ProfilesAssociation_disappears
=== PAUSE TestAccRoute53ProfilesAssociation_disappears
=== CONT  TestAccRoute53ProfilesAssociation_basic
=== CONT  TestAccRoute53ProfilesAssociation_disappears
=== CONT  TestAccRoute53ProfilesAssociation_tags
--- PASS: TestAccRoute53ProfilesAssociation_basic (376.25s)
--- PASS: TestAccRoute53ProfilesAssociation_disappears (392.46s)
--- PASS: TestAccRoute53ProfilesAssociation_tags (413.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53profiles	424.106s
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @jandersen-plaid 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[jar-b]

LGTM 🎉

% make testacc PKG=route53profiles TESTS=TestAccRoute53ProfilesAssociation_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/route53profiles/... -v -count 1 -parallel 20 -run='TestAccRoute53ProfilesAssociation_'  -timeout 360m
2024/10/23 09:52:43 Initializing Terraform AWS Provider...
=== RUN   TestAccRoute53ProfilesAssociation_basic
=== PAUSE TestAccRoute53ProfilesAssociation_basic
=== RUN   TestAccRoute53ProfilesAssociation_tags
=== PAUSE TestAccRoute53ProfilesAssociation_tags
=== RUN   TestAccRoute53ProfilesAssociation_disappears
=== PAUSE TestAccRoute53ProfilesAssociation_disappears
=== CONT  TestAccRoute53ProfilesAssociation_basic
=== CONT  TestAccRoute53ProfilesAssociation_disappears
=== CONT  TestAccRoute53ProfilesAssociation_tags
--- PASS: TestAccRoute53ProfilesAssociation_disappears (266.51s)
--- PASS: TestAccRoute53ProfilesAssociation_basic (278.71s)
--- PASS: TestAccRoute53ProfilesAssociation_tags (288.80s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53profiles    295.255s

[jar-b]

Thanks for your contribution, @jandersen-plaid! 👍

[github-actions]

This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!