Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_ssmquicksetup_configuration_manager: new resource #39931

Merged
merged 1 commit into from
Oct 30, 2024
Merged

r/aws_ssmquicksetup_configuration_manager: new resource #39931

merged 1 commit into from
Oct 30, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Oct 29, 2024

Description

This resource will allow practitioners to manage AWS SSM Quick Setup Configuration Managers via Terraform.

Relations

Closes #29549

References

Output from Acceptance Testing

% make testacc PKG=ssmquicksetup TESTS=TestAccSSMQuickSetupConfigurationManager_ ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ssmquicksetup/... -v -count 1 -parallel 3 -run='TestAccSSMQuickSetupConfigurationManager_'  -timeout 360m
2024/10/29 14:21:40 Initializing Terraform AWS Provider...

--- PASS: TestAccSSMQuickSetupConfigurationManager_basic (237.33s)
=== CONT  TestAccSSMQuickSetupConfigurationManager_description
--- PASS: TestAccSSMQuickSetupConfigurationManager_parameters (274.29s)
=== CONT  TestAccSSMQuickSetupConfigurationManager_disappears
--- PASS: TestAccSSMQuickSetupConfigurationManager_tags (396.48s)
--- PASS: TestAccSSMQuickSetupConfigurationManager_description (240.23s)
--- PASS: TestAccSSMQuickSetupConfigurationManager_disappears (224.85s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssmquicksetup      505.450s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. tags Pertains to resource tagging. generators Relates to code generators. service/ssmquicksetup Issues and PRs that pertain to the ssmquicksetup service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 29, 2024
@jar-b jar-b force-pushed the f-ssmquicksetup_configuration_manager branch from e564ee0 to f566e96 Compare October 29, 2024 18:35
@jar-b jar-b added the new-resource Introduces a new resource. label Oct 29, 2024
@jar-b jar-b force-pushed the f-ssmquicksetup_configuration_manager branch from f566e96 to efa88d8 Compare October 29, 2024 20:56
@jar-b
r/aws_ssmquicksetup_configuration_manager: new resource
0e0ba99 
This resource will allow practitioners to manage AWS SSM Quick Setup Configuration Managers via Terraform.

```console
% make testacc PKG=ssmquicksetup TESTS=TestAccSSMQuickSetupConfigurationManager_ ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ssmquicksetup/... -v -count 1 -parallel 3 -run='TestAccSSMQuickSetupConfigurationManager_'  -timeout 360m
2024/10/29 14:21:40 Initializing Terraform AWS Provider...

--- PASS: TestAccSSMQuickSetupConfigurationManager_basic (237.33s)
=== CONT  TestAccSSMQuickSetupConfigurationManager_description
--- PASS: TestAccSSMQuickSetupConfigurationManager_parameters (274.29s)
=== CONT  TestAccSSMQuickSetupConfigurationManager_disappears
--- PASS: TestAccSSMQuickSetupConfigurationManager_tags (396.48s)
--- PASS: TestAccSSMQuickSetupConfigurationManager_description (240.23s)
--- PASS: TestAccSSMQuickSetupConfigurationManager_disappears (224.85s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssmquicksetup      505.450s
```
@jar-b jar-b force-pushed the f-ssmquicksetup_configuration_manager branch from efa88d8 to 0e0ba99 Compare October 30, 2024 00:15
@jar-b jar-b marked this pull request as ready for review October 30, 2024 00:15
@jar-b jar-b requested a review from a team as a code owner October 30, 2024 00:15
@jar-b
Copy link
Member Author

jar-b commented Oct 30, 2024 

% make golangci-lint PKG=ssmquicksetup
make: golangci-lint Checks / 1 of 3...
make: golangci-lint Checks / 2 of 3...
WARN [config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`.
make: golangci-lint Checks / 3 of 3...

Semgrep failures are in an unrelated service and will be fixed by #39938

@ewbankkit ewbankkit self-assigned this Oct 30, 2024
ewbankkit
ewbankkit approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSSMQuickSetupConfigurationManager_' PKG=ssmquicksetup ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ssmquicksetup/... -v -count 1 -parallel 3  -run=TestAccSSMQuickSetupConfigurationManager_ -timeout 360m
2024/10/30 09:59:56 Initializing Terraform AWS Provider...
=== RUN   TestAccSSMQuickSetupConfigurationManager_basic
=== PAUSE TestAccSSMQuickSetupConfigurationManager_basic
=== RUN   TestAccSSMQuickSetupConfigurationManager_disappears
=== PAUSE TestAccSSMQuickSetupConfigurationManager_disappears
=== RUN   TestAccSSMQuickSetupConfigurationManager_description
=== PAUSE TestAccSSMQuickSetupConfigurationManager_description
=== RUN   TestAccSSMQuickSetupConfigurationManager_parameters
=== PAUSE TestAccSSMQuickSetupConfigurationManager_parameters
=== RUN   TestAccSSMQuickSetupConfigurationManager_tags
=== PAUSE TestAccSSMQuickSetupConfigurationManager_tags
=== CONT  TestAccSSMQuickSetupConfigurationManager_basic
=== CONT  TestAccSSMQuickSetupConfigurationManager_parameters
=== CONT  TestAccSSMQuickSetupConfigurationManager_description
--- PASS: TestAccSSMQuickSetupConfigurationManager_basic (226.44s)
=== CONT  TestAccSSMQuickSetupConfigurationManager_tags
--- PASS: TestAccSSMQuickSetupConfigurationManager_description (247.36s)
=== CONT  TestAccSSMQuickSetupConfigurationManager_disappears
--- PASS: TestAccSSMQuickSetupConfigurationManager_parameters (273.83s)
--- PASS: TestAccSSMQuickSetupConfigurationManager_disappears (253.24s)
--- PASS: TestAccSSMQuickSetupConfigurationManager_tags (394.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssmquicksetup	625.748s

@jar-b jar-b merged commit 9bfc058 into main Oct 30, 2024
54 of 55 checks passed
@jar-b jar-b deleted the f-ssmquicksetup_configuration_manager branch October 30, 2024 14:12
@github-actions github-actions bot added this to the v5.74.0 milestone Oct 30, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Oct 30, 2024
Update CHANGELOG.md for #39931
db786a4
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 31, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/ssmquicksetup Issues and PRs that pertain to the ssmquicksetup service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.74.0
Development

Successfully merging this pull request may close these issues.

[New Resource]: SSM (Systems Manager) - Patch Policy
2 participants
@jar-b @ewbankkit