dynamodb/table: Fix ability to disable dynamodb table ttl

[YakDriver]

Description

Brief history:

• aws_dynamodb_table - with ttl disabled, can't "terraform apply" twice #10304 describes a diff bug caused by ttl.0.attribute_name going out to AWS but not coming back
• resource/aws_dynamodb_table: Fixes perpetual diff when ttl.attribute_name is set when not enabled #37991 attempted to fix the diff by applying validation preventing ttl.0.attribute_name from being set if ttl.0.enabled is false. That fixed the diff but caused another problem.
• In order to disable TTL on a table, you must pass in ttl.0.attribute_name, even though AWS will not return it. resource/aws_dynamodb_table: Fixes perpetual diff when ttl.attribute_name is set when not enabled #37991 made it impossible to disable TTL.
• This PR removes the validation preventing ttl.0.attribute_name from being set if ttl.0.enabled is false and addresses the diff issue with a DiffSuppressFunc.
• Unfortunately, testing this fix is complicated because AWS will not allow you to disable TTL in the first hour it's enabled. I've added a test that sleeps an hour so it can verify that disabling works.

Relations

Closes #39195
Relates #37991

References

• resource/aws_dynamodb_table: Fixes perpetual diff when ttl.attribute_name is set when not enabled #37991
• aws_dynamodb_table - with ttl disabled, can't "terraform apply" twice #10304

Output from Acceptance Testing

% make t T=TestAccDynamoDBTable_TTL_updateDisable K=dynamodb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTable_TTL_updateDisable'  -timeout 360m
2024/11/07 13:57:43 Initializing Terraform AWS Provider...
=== RUN   TestAccDynamoDBTable_TTL_updateDisable
=== PAUSE TestAccDynamoDBTable_TTL_updateDisable
=== CONT  TestAccDynamoDBTable_TTL_updateDisable
--- PASS: TestAccDynamoDBTable_TTL_updateDisable (3639.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	3643.912s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🚀

Looks good! Just one suggestion on gating the new test.

[jar-b]

Should we consider gating this behind an environment variable (ENABLE_DYNAMODB_TTL_DISABLE or similar) in addition to the standard -short directive?

The other table tests aren't quite on the order of hours, so I could see this causing friction when running acceptance tests to validate changes to other arguments.

[YakDriver]

My concern there is that the test wouldn't be run ever then.... I definitely see your point and maybe we circle back and add it but would like to see it run sometimes to make sure we don't break it again for a little bit.

[github-actions]

This functionality has been released in v5.75.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!