b/aws_eip on delete error with ipam_pool_id stuck in IPAM eventual consistency loop

[alexbacchin]

Description

This PR fixes the aws_eip issue when action ReleaseAddress raises an error and ipam_pool_id is set. The error is not handled because the code enters IPAM eventual consistency check and never exists (until timeout).

This simply moves the error handling before the IPAM eventual consistency check

Relations

References

Output from Acceptance Testing

make testacc TESTS=TestAccEC2EIP_PublicIPv4Pool_IPAMPoolId PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2EIP_PublicIPv4Pool_IPAMPoolId'  -timeout 360m
2024/11/11 21:59:11 Initializing Terraform AWS Provider...
=== RUN   TestAccEC2EIP_PublicIPv4Pool_IPAMPoolId
=== PAUSE TestAccEC2EIP_PublicIPv4Pool_IPAMPoolId
=== CONT  TestAccEC2EIP_PublicIPv4Pool_IPAMPoolId
--- PASS: TestAccEC2EIP_PublicIPv4Pool_IPAMPoolId (81.56s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        81.626s
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🎉

% make testacc PKG=ec2 TESTS=TestAccEC2EIP_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2EIP_'  -timeout 360m
2024/11/11 11:31:00 Initializing Terraform AWS Provider...

=== NAME  TestAccEC2EIP_carrierIP
    wavelength_carrier_gateway_test.go:198: skipping since no Wavelength Zones are available
--- SKIP: TestAccEC2EIP_carrierIP (0.78s)
=== NAME  TestAccEC2EIP_customerOwnedIPv4Pool
    ec2_eip_test.go:538: skipping since no Outposts found
--- SKIP: TestAccEC2EIP_customerOwnedIPv4Pool (0.82s)
--- PASS: TestAccEC2EIP_BYOIPAddress_default (23.11s)
--- PASS: TestAccEC2EIP_disappears (23.64s)
--- PASS: TestAccEC2EIP_networkBorderGroup (25.05s)
--- PASS: TestAccEC2EIP_PublicIPv4Pool_default (25.77s)
--- PASS: TestAccEC2EIP_noVPC (26.43s)
--- PASS: TestAccEC2EIP_basic (26.55s)
--- PASS: TestAccEC2EIP_NetworkInterface_twoEIPsOneInterface (32.10s)
--- PASS: TestAccEC2EIP_migrateVPCToDomain (33.64s)
--- PASS: TestAccEC2EIP_networkInterface (35.61s)
--- PASS: TestAccEC2EIP_tags (45.86s)
--- PASS: TestAccEC2EIP_PublicIPv4Pool_IPAMPoolId (82.51s)
--- PASS: TestAccEC2EIP_Instance_reassociate (125.31s)
--- PASS: TestAccEC2EIP_Instance_notAssociated (132.89s)
--- PASS: TestAccEC2EIP_association (167.12s)
--- PASS: TestAccEC2EIP_Instance_associatedUserPrivateIP (167.48s)
--- PASS: TestAccEC2EIP_instance (332.63s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        338.207s

[jar-b]

Thanks for the fix, @alexbacchin! 👍

[github-actions]

This functionality has been released in v5.76.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.