-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add topic_name_configuration to msk replicator #40101
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccKafkaReplicator_' PKG=kafka
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/kafka/... -v -count 1 -parallel 20 -run=TestAccKafkaReplicator_ -timeout 720m
2024/12/06 12:17:33 Initializing Terraform AWS Provider...
=== RUN TestAccKafkaReplicator_basic
=== PAUSE TestAccKafkaReplicator_basic
=== RUN TestAccKafkaReplicator_update
=== PAUSE TestAccKafkaReplicator_update
=== RUN TestAccKafkaReplicator_tags
=== PAUSE TestAccKafkaReplicator_tags
=== RUN TestAccKafkaReplicator_disappears
=== PAUSE TestAccKafkaReplicator_disappears
=== CONT TestAccKafkaReplicator_basic
=== CONT TestAccKafkaReplicator_tags
=== CONT TestAccKafkaReplicator_disappears
=== CONT TestAccKafkaReplicator_update
--- PASS: TestAccKafkaReplicator_basic (6257.58s)
--- PASS: TestAccKafkaReplicator_tags (6259.17s)
--- PASS: TestAccKafkaReplicator_disappears (6259.51s)
--- PASS: TestAccKafkaReplicator_update (6968.86s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/kafka 6974.123s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🚀
@lvthillo Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.81.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Add
topic_name_configuration
attribute to MSK replicator.Relations
Closes #39309
References
Output from Acceptance Testing