Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add topic_name_configuration to msk replicator #40101

Merged
merged 6 commits into from
Dec 6, 2024

Conversation

lvthillo
Copy link
Contributor

Description

Add topic_name_configuration attribute to MSK replicator.

Relations

Closes #39309

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccKafkaReplicator_basic\|TestAccKafkaReplicator_update' PKG=kafka
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/kafka/... -v -count 1 -parallel 20  -run=TestAccKafkaReplicator_basic\|TestAccKafkaReplicator_update -timeout 360m
2024/11/12 11:50:56 Initializing Terraform AWS Provider...
=== RUN   TestAccKafkaReplicator_basic
=== PAUSE TestAccKafkaReplicator_basic
=== RUN   TestAccKafkaReplicator_update
=== PAUSE TestAccKafkaReplicator_update
=== CONT  TestAccKafkaReplicator_basic
=== CONT  TestAccKafkaReplicator_update
--- PASS: TestAccKafkaReplicator_basic (9085.58s)
--- PASS: TestAccKafkaReplicator_update (9902.97s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kafka      9919.192s

...

@lvthillo lvthillo requested a review from a team as a code owner November 12, 2024 19:41
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/kafka Issues and PRs that pertain to the kafka service. needs-triage Waiting for first response or review from a maintainer. labels Nov 12, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 13, 2024
@ewbankkit ewbankkit self-assigned this Dec 6, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 6, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccKafkaReplicator_' PKG=kafka
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/kafka/... -v -count 1 -parallel 20  -run=TestAccKafkaReplicator_ -timeout 720m
2024/12/06 12:17:33 Initializing Terraform AWS Provider...
=== RUN   TestAccKafkaReplicator_basic
=== PAUSE TestAccKafkaReplicator_basic
=== RUN   TestAccKafkaReplicator_update
=== PAUSE TestAccKafkaReplicator_update
=== RUN   TestAccKafkaReplicator_tags
=== PAUSE TestAccKafkaReplicator_tags
=== RUN   TestAccKafkaReplicator_disappears
=== PAUSE TestAccKafkaReplicator_disappears
=== CONT  TestAccKafkaReplicator_basic
=== CONT  TestAccKafkaReplicator_tags
=== CONT  TestAccKafkaReplicator_disappears
=== CONT  TestAccKafkaReplicator_update
--- PASS: TestAccKafkaReplicator_basic (6257.58s)
--- PASS: TestAccKafkaReplicator_tags (6259.17s)
--- PASS: TestAccKafkaReplicator_disappears (6259.51s)
--- PASS: TestAccKafkaReplicator_update (6968.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafka	6974.123s

Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@ewbankkit
Copy link
Contributor

@lvthillo Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 049b197 into hashicorp:main Dec 6, 2024
48 checks passed
@github-actions github-actions bot added this to the v5.81.0 milestone Dec 6, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 12, 2024
Copy link

This functionality has been released in v5.81.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@lvthillo lvthillo deleted the add-topicnameconfiguration branch December 13, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/kafka Issues and PRs that pertain to the kafka service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add TopicNameConfiguration argument under topic_replication block for msk replicator resource
4 participants