-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_iam_organization_features: IAM Organizations Root Access Management new resource #40164
r/aws_iam_organization_features: IAM Organizations Root Access Management new resource #40164
Conversation
Community NoteVoting for Prioritization
For Submitters
|
…nizationsEnabledServicePrincipal'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccIAMOrganizationsFeatures_serial' PKG=iam
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/iam/... -v -count 1 -parallel 20 -run=TestAccIAMOrganizationsFeatures_serial -timeout 360m
2024/11/26 08:25:37 Initializing Terraform AWS Provider...
=== RUN TestAccIAMOrganizationsFeatures_serial
=== PAUSE TestAccIAMOrganizationsFeatures_serial
=== CONT TestAccIAMOrganizationsFeatures_serial
=== RUN TestAccIAMOrganizationsFeatures_serial/basic
=== RUN TestAccIAMOrganizationsFeatures_serial/update
--- PASS: TestAccIAMOrganizationsFeatures_serial (32.33s)
--- PASS: TestAccIAMOrganizationsFeatures_serial/basic (13.23s)
--- PASS: TestAccIAMOrganizationsFeatures_serial/update (19.10s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/iam 37.488s
% make testacc TESTARGS='-run=TestAccIAMOrganizationsFeatures_serial' PKG=iam
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/iam/... -v -count 1 -parallel 20 -run=TestAccIAMOrganizationsFeatures_serial -timeout 360m
2024/11/26 08:27:16 Initializing Terraform AWS Provider...
=== RUN TestAccIAMOrganizationsFeatures_serial
=== PAUSE TestAccIAMOrganizationsFeatures_serial
=== CONT TestAccIAMOrganizationsFeatures_serial
=== RUN TestAccIAMOrganizationsFeatures_serial/basic
organizations_features_test.go:42: this AWS account must be the management account of an AWS Organization
=== RUN TestAccIAMOrganizationsFeatures_serial/update
organizations_features_test.go:78: this AWS account must be the management account of an AWS Organization
--- PASS: TestAccIAMOrganizationsFeatures_serial (1.10s)
--- SKIP: TestAccIAMOrganizationsFeatures_serial/basic (0.84s)
--- SKIP: TestAccIAMOrganizationsFeatures_serial/update (0.26s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/iam 6.150s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@alexbacchin Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.78.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
This resource manages the IAM Organization features (Root Access Management). It can only be utilised on the management account with AWS Organization enabled, as well as trusted access for AWS Identity and Access Management.
The implementation was not as a straightforward. Each feature requires a separate Enable/Disable API call. However, reading all enable features is a single ListFeatures action.
Relations
Closes #40151
Closes #40173
References
https://docs.aws.amazon.com/IAM/latest/UserGuide/id_root-enable-root-access.html
Output from Acceptance Testing
I have only included the basic testing. Please let me know if more testing is needed