-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource aws_bedrock_inference_profile #40294
Conversation
Community NoteVoting for Prioritization
For Submitters
|
ec9163b
to
85a9f83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
85a9f83
to
f0398c3
Compare
f0398c3
to
459a740
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @chlunde. I've made a few changes:
- Removed optional attributes from the
basic
test - Added a separate test for
description
- Generated tagging tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccBedrockInferenceProfile_' PKG=bedrock
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/bedrock/... -v -count 1 -parallel 20 -run=TestAccBedrockInferenceProfile_ -timeout 360m
2024/12/04 16:10:34 Initializing Terraform AWS Provider...
=== RUN TestAccBedrockInferenceProfile_tags
=== PAUSE TestAccBedrockInferenceProfile_tags
=== RUN TestAccBedrockInferenceProfile_tags_null
=== PAUSE TestAccBedrockInferenceProfile_tags_null
=== RUN TestAccBedrockInferenceProfile_tags_EmptyMap
=== PAUSE TestAccBedrockInferenceProfile_tags_EmptyMap
=== RUN TestAccBedrockInferenceProfile_tags_AddOnUpdate
=== PAUSE TestAccBedrockInferenceProfile_tags_AddOnUpdate
=== RUN TestAccBedrockInferenceProfile_tags_EmptyTag_OnCreate
=== PAUSE TestAccBedrockInferenceProfile_tags_EmptyTag_OnCreate
=== RUN TestAccBedrockInferenceProfile_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccBedrockInferenceProfile_tags_EmptyTag_OnUpdate_Add
=== RUN TestAccBedrockInferenceProfile_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccBedrockInferenceProfile_tags_EmptyTag_OnUpdate_Replace
=== RUN TestAccBedrockInferenceProfile_tags_DefaultTags_providerOnly
=== PAUSE TestAccBedrockInferenceProfile_tags_DefaultTags_providerOnly
=== RUN TestAccBedrockInferenceProfile_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccBedrockInferenceProfile_tags_DefaultTags_nonOverlapping
=== RUN TestAccBedrockInferenceProfile_tags_DefaultTags_overlapping
=== PAUSE TestAccBedrockInferenceProfile_tags_DefaultTags_overlapping
=== RUN TestAccBedrockInferenceProfile_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccBedrockInferenceProfile_tags_DefaultTags_updateToProviderOnly
=== RUN TestAccBedrockInferenceProfile_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccBedrockInferenceProfile_tags_DefaultTags_updateToResourceOnly
=== RUN TestAccBedrockInferenceProfile_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccBedrockInferenceProfile_tags_DefaultTags_emptyResourceTag
=== RUN TestAccBedrockInferenceProfile_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccBedrockInferenceProfile_tags_DefaultTags_emptyProviderOnlyTag
=== RUN TestAccBedrockInferenceProfile_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccBedrockInferenceProfile_tags_DefaultTags_nullOverlappingResourceTag
=== RUN TestAccBedrockInferenceProfile_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccBedrockInferenceProfile_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN TestAccBedrockInferenceProfile_tags_ComputedTag_OnCreate
=== PAUSE TestAccBedrockInferenceProfile_tags_ComputedTag_OnCreate
=== RUN TestAccBedrockInferenceProfile_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccBedrockInferenceProfile_tags_ComputedTag_OnUpdate_Add
=== RUN TestAccBedrockInferenceProfile_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccBedrockInferenceProfile_tags_ComputedTag_OnUpdate_Replace
=== RUN TestAccBedrockInferenceProfile_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccBedrockInferenceProfile_tags_IgnoreTags_Overlap_DefaultTag
=== RUN TestAccBedrockInferenceProfile_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccBedrockInferenceProfile_tags_IgnoreTags_Overlap_ResourceTag
=== RUN TestAccBedrockInferenceProfile_basic
=== PAUSE TestAccBedrockInferenceProfile_basic
=== RUN TestAccBedrockInferenceProfile_disappears
=== PAUSE TestAccBedrockInferenceProfile_disappears
=== RUN TestAccBedrockInferenceProfile_description
=== PAUSE TestAccBedrockInferenceProfile_description
=== CONT TestAccBedrockInferenceProfile_tags
=== CONT TestAccBedrockInferenceProfile_tags_DefaultTags_emptyResourceTag
=== CONT TestAccBedrockInferenceProfile_tags_IgnoreTags_Overlap_DefaultTag
=== CONT TestAccBedrockInferenceProfile_tags_ComputedTag_OnUpdate_Replace
=== CONT TestAccBedrockInferenceProfile_tags_EmptyTag_OnUpdate_Replace
=== CONT TestAccBedrockInferenceProfile_disappears
=== CONT TestAccBedrockInferenceProfile_basic
=== CONT TestAccBedrockInferenceProfile_tags_IgnoreTags_Overlap_ResourceTag
=== CONT TestAccBedrockInferenceProfile_tags_DefaultTags_updateToResourceOnly
=== CONT TestAccBedrockInferenceProfile_tags_DefaultTags_updateToProviderOnly
=== CONT TestAccBedrockInferenceProfile_tags_DefaultTags_overlapping
=== CONT TestAccBedrockInferenceProfile_tags_DefaultTags_nonOverlapping
=== CONT TestAccBedrockInferenceProfile_tags_DefaultTags_providerOnly
=== CONT TestAccBedrockInferenceProfile_tags_AddOnUpdate
=== CONT TestAccBedrockInferenceProfile_tags_EmptyTag_OnUpdate_Add
=== CONT TestAccBedrockInferenceProfile_tags_EmptyTag_OnCreate
=== CONT TestAccBedrockInferenceProfile_tags_EmptyMap
=== CONT TestAccBedrockInferenceProfile_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT TestAccBedrockInferenceProfile_tags_ComputedTag_OnUpdate_Add
=== CONT TestAccBedrockInferenceProfile_description
--- PASS: TestAccBedrockInferenceProfile_disappears (17.30s)
=== CONT TestAccBedrockInferenceProfile_tags_ComputedTag_OnCreate
--- PASS: TestAccBedrockInferenceProfile_basic (18.21s)
=== CONT TestAccBedrockInferenceProfile_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccBedrockInferenceProfile_tags_DefaultTags_emptyResourceTag (28.82s)
=== CONT TestAccBedrockInferenceProfile_tags_null
--- PASS: TestAccBedrockInferenceProfile_tags_EmptyMap (29.09s)
=== CONT TestAccBedrockInferenceProfile_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccBedrockInferenceProfile_tags_DefaultTags_updateToProviderOnly (37.67s)
--- PASS: TestAccBedrockInferenceProfile_description (38.60s)
--- PASS: TestAccBedrockInferenceProfile_tags_DefaultTags_nullNonOverlappingResourceTag (40.62s)
--- PASS: TestAccBedrockInferenceProfile_tags_ComputedTag_OnUpdate_Add (42.33s)
--- PASS: TestAccBedrockInferenceProfile_tags_DefaultTags_nullOverlappingResourceTag (25.36s)
--- PASS: TestAccBedrockInferenceProfile_tags_ComputedTag_OnCreate (27.50s)
--- PASS: TestAccBedrockInferenceProfile_tags_DefaultTags_updateToResourceOnly (45.85s)
--- PASS: TestAccBedrockInferenceProfile_tags_EmptyTag_OnUpdate_Replace (45.87s)
--- PASS: TestAccBedrockInferenceProfile_tags_AddOnUpdate (48.84s)
--- PASS: TestAccBedrockInferenceProfile_tags_null (21.52s)
--- PASS: TestAccBedrockInferenceProfile_tags_IgnoreTags_Overlap_DefaultTag (50.44s)
--- PASS: TestAccBedrockInferenceProfile_tags_DefaultTags_emptyProviderOnlyTag (21.51s)
--- PASS: TestAccBedrockInferenceProfile_tags_ComputedTag_OnUpdate_Replace (51.65s)
--- PASS: TestAccBedrockInferenceProfile_tags_IgnoreTags_Overlap_ResourceTag (52.98s)
--- PASS: TestAccBedrockInferenceProfile_tags_EmptyTag_OnUpdate_Add (54.21s)
--- PASS: TestAccBedrockInferenceProfile_tags_EmptyTag_OnCreate (54.21s)
--- PASS: TestAccBedrockInferenceProfile_tags_DefaultTags_overlapping (65.09s)
--- PASS: TestAccBedrockInferenceProfile_tags_DefaultTags_nonOverlapping (65.14s)
--- PASS: TestAccBedrockInferenceProfile_tags_DefaultTags_providerOnly (72.11s)
--- PASS: TestAccBedrockInferenceProfile_tags (76.43s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/bedrock 82.058s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
@gdavison @ewbankkit thanks! |
This functionality has been released in v5.81.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Introduce new resource aws_bedrock_inference_profile, which allows cost tracking and metrics.
Relations
Closes #40288
References
Output from Acceptance Testing