Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_wafregional_geo_match_set cannot be added to a rule #4039

Closed
dcohan opened this issue Apr 4, 2018 · 4 comments · Fixed by #4046
Closed

aws_wafregional_geo_match_set cannot be added to a rule #4039

dcohan opened this issue Apr 4, 2018 · 4 comments · Fixed by #4046
Labels
bug Addresses a defect in current functionality. service/waf Issues and PRs that pertain to the waf service.
Milestone

Comments

@dcohan
Copy link

dcohan commented Apr 4, 2018

Hi there,

Thank you for opening an issue. Please note that we try to keep the Terraform issue tracker reserved for bug reports and feature requests. For general usage questions, please see: https://www.terraform.io/community.html.

Terraform Version

0.11.5

Affected Resource(s)

Please list the resources as a list, for example:

  • aws_wafregional_geo_match_set
  • aws_wafregional_rule
  • aws_wafregional_rule_group (probably)

Terraform Configuration Files

resource "aws_wafregional_geo_match_set" "geo_match_set" {
  name = "geo_match_set"

  geo_match_constraint {
    type  = "Country"
    value = "AR"
  }
}

resource "aws_wafregional_rule" "georule" {
  depends_on  = ["aws_wafregional_geo_match_set.geo_match_set"]
  name        = "${var.group}-${var.environment}-waf-geo-rule"
  metric_name = "${var.group}${var.environment}wafgeorule"

  predicate {
    data_id = "${aws_wafregional_geo_match_set.geo_match_set.id}"
    negated = false
    type    = "GeoMatch"
  }
}

Expected Behavior

Created a match set and a rule using that geo match set

Actual Behavior

The resource aws_wafregional_rule don't expect the type GeoMatch

@bflad bflad added bug Addresses a defect in current functionality. service/waf Issues and PRs that pertain to the waf service. labels Apr 4, 2018
@bflad
Copy link
Contributor

bflad commented Apr 4, 2018

PR submitted: #4046

@bflad bflad added this to the v1.14.0 milestone Apr 4, 2018
@bflad
Copy link
Contributor

bflad commented Apr 4, 2018

The fix for the validation to allow all predicate types in the aws_wafregional_rule has been merged into master and will release with v1.14.0 of the AWS provider, likely by the end of this week.

@bflad
Copy link
Contributor

bflad commented Apr 6, 2018

This has been released in version 1.14.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/waf Issues and PRs that pertain to the waf service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants