Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Service: s3tables #40420

Merged
merged 35 commits into from
Dec 4, 2024
Merged

New Service: s3tables #40420

merged 35 commits into from
Dec 4, 2024

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Dec 3, 2024

Description

Adds the following resource types for the service s3tables:

  • aws_s3tables_table_bucket
  • aws_s3tables_table_bucket_policy
  • aws_s3tables_table
  • aws_s3tables_table_policy
  • aws_s3tables_namespace

References

Closes #40407.

Announcement: https://aws.amazon.com/about-aws/whats-new/2024/12/amazon-s3-tables-apache-iceberg-tables-analytics-workloads/

Documentation: https://docs.aws.amazon.com/AmazonS3/latest/userguide/s3-tables.html

Output from Acceptance Testing

% make testacc PKG=s3tables TESTS=TestAccS3Tables

--- PASS: TestAccS3TablesTableBucket_disappears (24.10s)
--- PASS: TestAccS3TablesTableBucket_basic (24.44s)
--- PASS: TestAccS3TablesTable_disappears (28.60s)
--- PASS: TestAccS3TablesNamespace_basic (29.03s)
--- PASS: TestAccS3TablesTablePolicy_disappears (29.69s)
--- PASS: TestAccS3TablesTable_basic (32.72s)
--- PASS: TestAccS3TablesTablePolicy_basic (36.77s)
--- PASS: TestAccS3TablesTable_rename (44.76s)
--- PASS: TestAccS3TablesTableBucketPolicy_basic (23.78s)
--- PASS: TestAccS3TablesTable_updateNamespace (48.75s)
--- PASS: TestAccS3TablesTableBucketPolicy_disappears (20.27s)
--- PASS: TestAccS3TablesNamespace_disappears (19.76s)
--- PASS: TestAccS3TablesTableBucket_maintenanceConfiguration (59.77s)
--- PASS: TestAccS3TablesTable_maintenanceConfiguration (42.99s)
--- PASS: TestAccS3TablesTable_updateNameAndNamespace (38.87s)

Copy link

github-actions bot commented Dec 3, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Dec 3, 2024
@github-actions github-actions bot added sweeper Pertains to changes to or issues with the sweeper. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. github_actions Pull requests that update Github_actions code skaff Issues and pull requested related to the skaff tool service/devopsguru Issues and PRs that pertain to the devopsguru service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Dec 3, 2024
@ewbankkit
Copy link
Contributor

% make testacc TESTARGS='-run=TestAccS3Tables' PKG=s3tables ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/s3tables/... -v -count 1 -parallel 3  -run=TestAccS3Tables -timeout 360m
go: downloading github.com/aws/aws-sdk-go-v2/service/s3tables v1.0.0
2024/12/03 16:31:27 Initializing Terraform AWS Provider...
=== RUN   TestAccS3TablesNamespace_basic
=== PAUSE TestAccS3TablesNamespace_basic
=== RUN   TestAccS3TablesNamespace_disappears
=== PAUSE TestAccS3TablesNamespace_disappears
=== RUN   TestAccS3TablesTableBucketPolicy_basic
=== PAUSE TestAccS3TablesTableBucketPolicy_basic
=== RUN   TestAccS3TablesTableBucketPolicy_disappears
=== PAUSE TestAccS3TablesTableBucketPolicy_disappears
=== RUN   TestAccS3TablesTableBucket_basic
=== PAUSE TestAccS3TablesTableBucket_basic
=== RUN   TestAccS3TablesTableBucket_disappears
=== PAUSE TestAccS3TablesTableBucket_disappears
=== RUN   TestAccS3TablesTableBucket_maintenanceConfiguration
=== PAUSE TestAccS3TablesTableBucket_maintenanceConfiguration
=== RUN   TestAccS3TablesTablePolicy_basic
=== PAUSE TestAccS3TablesTablePolicy_basic
=== RUN   TestAccS3TablesTablePolicy_disappears
=== PAUSE TestAccS3TablesTablePolicy_disappears
=== RUN   TestAccS3TablesTable_basic
=== PAUSE TestAccS3TablesTable_basic
=== RUN   TestAccS3TablesTable_disappears
=== PAUSE TestAccS3TablesTable_disappears
=== RUN   TestAccS3TablesTable_rename
=== PAUSE TestAccS3TablesTable_rename
=== RUN   TestAccS3TablesTable_updateNamespace
=== PAUSE TestAccS3TablesTable_updateNamespace
=== RUN   TestAccS3TablesTable_updateNameAndNamespace
=== PAUSE TestAccS3TablesTable_updateNameAndNamespace
=== RUN   TestAccS3TablesTable_maintenanceConfiguration
=== PAUSE TestAccS3TablesTable_maintenanceConfiguration
=== CONT  TestAccS3TablesNamespace_basic
=== CONT  TestAccS3TablesTablePolicy_disappears
=== CONT  TestAccS3TablesTable_updateNamespace
--- PASS: TestAccS3TablesNamespace_basic (17.06s)
=== CONT  TestAccS3TablesTable_maintenanceConfiguration
--- PASS: TestAccS3TablesTablePolicy_disappears (18.04s)
=== CONT  TestAccS3TablesTable_updateNameAndNamespace
--- PASS: TestAccS3TablesTable_updateNamespace (30.32s)
=== CONT  TestAccS3TablesTable_disappears
--- PASS: TestAccS3TablesTable_disappears (15.76s)
=== CONT  TestAccS3TablesTable_rename
--- PASS: TestAccS3TablesTable_maintenanceConfiguration (31.22s)
=== CONT  TestAccS3TablesTableBucket_basic
--- PASS: TestAccS3TablesTable_updateNameAndNamespace (33.10s)
=== CONT  TestAccS3TablesTablePolicy_basic
--- PASS: TestAccS3TablesTableBucket_basic (16.09s)
=== CONT  TestAccS3TablesTableBucket_maintenanceConfiguration
--- PASS: TestAccS3TablesTablePolicy_basic (19.29s)
=== CONT  TestAccS3TablesTableBucket_disappears
--- PASS: TestAccS3TablesTable_rename (29.23s)
=== CONT  TestAccS3TablesTable_basic
--- PASS: TestAccS3TablesTableBucket_disappears (13.17s)
=== CONT  TestAccS3TablesTableBucketPolicy_basic
--- PASS: TestAccS3TablesTable_basic (18.65s)
=== CONT  TestAccS3TablesTableBucketPolicy_disappears
--- PASS: TestAccS3TablesTableBucketPolicy_basic (16.30s)
=== CONT  TestAccS3TablesNamespace_disappears
--- PASS: TestAccS3TablesTableBucket_maintenanceConfiguration (40.46s)
--- PASS: TestAccS3TablesTableBucketPolicy_disappears (14.58s)
--- PASS: TestAccS3TablesNamespace_disappears (14.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3tables	119.417s

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@gdavison gdavison merged commit 51769a8 into main Dec 4, 2024
53 checks passed
@gdavison gdavison deleted the f-s3tables branch December 4, 2024 00:11
@github-actions github-actions bot added this to the v5.80.0 milestone Dec 4, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

This functionality has been released in v5.80.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 4, 2024
Copy link

github-actions bot commented Jan 4, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/devopsguru Issues and PRs that pertain to the devopsguru service. skaff Issues and pull requested related to the skaff tool sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon S3 Tables
2 participants