Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_lb_listener: Add mutual_authentication.advertise_trust_store_ca_names attribute #40658

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Dec 20, 2024

Description

Missing from data source.
Causing setting mutual_authentication: Invalid address to set: []string{"mutual_authentication", "0", "advertise_trust_store_ca_names"} errors.

Relations

Closes #40651.
Relates #40550.

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccELBV2ListenerDataSource_' PKG=elbv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/elbv2/... -v -count 1 -parallel 20  -run=TestAccELBV2ListenerDataSource_ -timeout 360m
2024/12/20 10:12:00 Initializing Terraform AWS Provider...
=== RUN   TestAccELBV2ListenerDataSource_tags
=== PAUSE TestAccELBV2ListenerDataSource_tags
=== RUN   TestAccELBV2ListenerDataSource_tags_NullMap
=== PAUSE TestAccELBV2ListenerDataSource_tags_NullMap
=== RUN   TestAccELBV2ListenerDataSource_tags_EmptyMap
=== PAUSE TestAccELBV2ListenerDataSource_tags_EmptyMap
=== RUN   TestAccELBV2ListenerDataSource_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccELBV2ListenerDataSource_tags_DefaultTags_nonOverlapping
=== RUN   TestAccELBV2ListenerDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccELBV2ListenerDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccELBV2ListenerDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccELBV2ListenerDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccELBV2ListenerDataSource_basic
=== PAUSE TestAccELBV2ListenerDataSource_basic
=== RUN   TestAccELBV2ListenerDataSource_mutualAuthentication
=== PAUSE TestAccELBV2ListenerDataSource_mutualAuthentication
=== CONT  TestAccELBV2ListenerDataSource_tags
=== CONT  TestAccELBV2ListenerDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== CONT  TestAccELBV2ListenerDataSource_mutualAuthentication
=== CONT  TestAccELBV2ListenerDataSource_basic
=== CONT  TestAccELBV2ListenerDataSource_tags_DefaultTags_nonOverlapping
=== CONT  TestAccELBV2ListenerDataSource_tags_EmptyMap
=== CONT  TestAccELBV2ListenerDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== CONT  TestAccELBV2ListenerDataSource_tags_NullMap
--- PASS: TestAccELBV2ListenerDataSource_tags_EmptyMap (218.39s)
--- PASS: TestAccELBV2ListenerDataSource_mutualAuthentication (221.68s)
--- PASS: TestAccELBV2ListenerDataSource_tags (226.84s)
--- PASS: TestAccELBV2ListenerDataSource_tags_IgnoreTags_Overlap_ResourceTag (227.30s)
--- PASS: TestAccELBV2ListenerDataSource_tags_DefaultTags_nonOverlapping (228.74s)
--- PASS: TestAccELBV2ListenerDataSource_tags_IgnoreTags_Overlap_DefaultTag (228.82s)
--- PASS: TestAccELBV2ListenerDataSource_tags_NullMap (237.40s)
--- PASS: TestAccELBV2ListenerDataSource_basic (237.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	243.201s

@ewbankkit ewbankkit requested a review from a team as a code owner December 20, 2024 15:10
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elbv2 Issues and PRs that pertain to the elbv2 service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Dec 20, 2024
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Dec 20, 2024
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccELBV2ListenerDataSource_' PKG=elbv2

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/elbv2/... -v -count 1 -parallel 20  -run=TestAccELBV2ListenerDataSource_ -timeout 360m
2024/12/20 10:08:34 Initializing Terraform AWS Provider...
--- PASS: TestAccELBV2ListenerDataSource_tags_NullMap (225.22s)
--- PASS: TestAccELBV2ListenerDataSource_mutualAuthentication (225.29s)
--- PASS: TestAccELBV2ListenerDataSource_tags_EmptyMap (233.14s)
--- PASS: TestAccELBV2ListenerDataSource_tags_DefaultTags_nonOverlapping (233.25s)
--- PASS: TestAccELBV2ListenerDataSource_tags_IgnoreTags_Overlap_DefaultTag (233.28s)
--- PASS: TestAccELBV2ListenerDataSource_tags_IgnoreTags_Overlap_ResourceTag (235.58s)
--- PASS: TestAccELBV2ListenerDataSource_tags (243.13s)
--- PASS: TestAccELBV2ListenerDataSource_basic (245.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	252.008s

@ewbankkit ewbankkit merged commit 9463e6f into main Dec 20, 2024
48 checks passed
@ewbankkit ewbankkit deleted the b-d/aws_lb_listener-regression branch December 20, 2024 16:14
@github-actions github-actions bot added this to the v5.83.0 milestone Dec 20, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Dec 20, 2024
@ewbankkit ewbankkit modified the milestones: v5.83.0, v5.82.2 Dec 20, 2024
Copy link

This functionality has been released in v5.82.2 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/elbv2 Issues and PRs that pertain to the elbv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants