Add support for supports_local_write_forwarding, supports_certificate_rotation_without_restart and supports_integrations

[matthewbaggett]

Description

Add to aws_rds_engine_version support for

• supports_certificate_rotation_without_restart
• supports_integrations
• supports_local_write_forwarding

There is a test failure, but I do not think it is my PR:
engine_version_data_source_test.go:165: Step 1/2 error: Check failed: Check 1/1 error: data.aws_rds_engine_version.test: Attribute 'version' didn't match "^5\\.7\\.", got "8.0.40"
I suspect the default has changed.

Relations

No related issue.

References

Output from Acceptance Testing

% make testacc TESTS=TestAccRDSEngineVersion PKG=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSEngineVersion'  -timeout 360m
2024/12/26 19:52:55 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSEngineVersionDataSource_basic
=== PAUSE TestAccRDSEngineVersionDataSource_basic
=== RUN   TestAccRDSEngineVersionDataSource_upgradeTargets
=== PAUSE TestAccRDSEngineVersionDataSource_upgradeTargets
=== RUN   TestAccRDSEngineVersionDataSource_preferred
=== PAUSE TestAccRDSEngineVersionDataSource_preferred
=== RUN   TestAccRDSEngineVersionDataSource_preferredVersionsPreferredUpgradeTargets
=== PAUSE TestAccRDSEngineVersionDataSource_preferredVersionsPreferredUpgradeTargets
=== RUN   TestAccRDSEngineVersionDataSource_preferredUpgradeTargetsVersion
=== PAUSE TestAccRDSEngineVersionDataSource_preferredUpgradeTargetsVersion
=== RUN   TestAccRDSEngineVersionDataSource_preferredMajorTargets
=== PAUSE TestAccRDSEngineVersionDataSource_preferredMajorTargets
=== RUN   TestAccRDSEngineVersionDataSource_defaultOnlyImplicit
=== PAUSE TestAccRDSEngineVersionDataSource_defaultOnlyImplicit
=== RUN   TestAccRDSEngineVersionDataSource_defaultOnlyExplicit
=== PAUSE TestAccRDSEngineVersionDataSource_defaultOnlyExplicit
=== RUN   TestAccRDSEngineVersionDataSource_includeAll
=== PAUSE TestAccRDSEngineVersionDataSource_includeAll
=== RUN   TestAccRDSEngineVersionDataSource_filter
=== PAUSE TestAccRDSEngineVersionDataSource_filter
=== RUN   TestAccRDSEngineVersionDataSource_latest
=== PAUSE TestAccRDSEngineVersionDataSource_latest
=== RUN   TestAccRDSEngineVersionDataSource_hasMinorMajor
=== PAUSE TestAccRDSEngineVersionDataSource_hasMinorMajor
=== CONT  TestAccRDSEngineVersionDataSource_basic
=== CONT  TestAccRDSEngineVersionDataSource_defaultOnlyImplicit
=== CONT  TestAccRDSEngineVersionDataSource_filter
=== CONT  TestAccRDSEngineVersionDataSource_preferredVersionsPreferredUpgradeTargets
=== CONT  TestAccRDSEngineVersionDataSource_preferred
=== CONT  TestAccRDSEngineVersionDataSource_includeAll
=== CONT  TestAccRDSEngineVersionDataSource_upgradeTargets
=== CONT  TestAccRDSEngineVersionDataSource_preferredUpgradeTargetsVersion
=== CONT  TestAccRDSEngineVersionDataSource_preferredMajorTargets
=== CONT  TestAccRDSEngineVersionDataSource_defaultOnlyExplicit
=== CONT  TestAccRDSEngineVersionDataSource_hasMinorMajor
=== CONT  TestAccRDSEngineVersionDataSource_latest
=== NAME  TestAccRDSEngineVersionDataSource_preferredMajorTargets
    engine_version_data_source_test.go:165: Step 1/2 error: Check failed: Check 1/1 error: data.aws_rds_engine_version.test: Attribute 'version' didn't match "^5\\.7\\.", got "8.0.40"
--- FAIL: TestAccRDSEngineVersionDataSource_preferredMajorTargets (12.74s)
--- PASS: TestAccRDSEngineVersionDataSource_basic (19.58s)
--- PASS: TestAccRDSEngineVersionDataSource_defaultOnlyImplicit (21.31s)
--- PASS: TestAccRDSEngineVersionDataSource_upgradeTargets (21.67s)
--- PASS: TestAccRDSEngineVersionDataSource_includeAll (21.70s)
--- PASS: TestAccRDSEngineVersionDataSource_defaultOnlyExplicit (21.83s)
--- PASS: TestAccRDSEngineVersionDataSource_preferredUpgradeTargetsVersion (22.02s)
--- PASS: TestAccRDSEngineVersionDataSource_filter (31.38s)
--- PASS: TestAccRDSEngineVersionDataSource_preferred (31.82s)
--- PASS: TestAccRDSEngineVersionDataSource_preferredVersionsPreferredUpgradeTargets (32.34s)
--- PASS: TestAccRDSEngineVersionDataSource_hasMinorMajor (53.35s)
--- PASS: TestAccRDSEngineVersionDataSource_latest (59.42s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/rds	59.523s
FAIL
make: *** [GNUmakefile:601: testacc] Error 1
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @matthewbaggett 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSEngineVersionDataSource_' PKG=rds ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/rds/... -v -count 1 -parallel 4  -run=TestAccRDSEngineVersionDataSource_ -timeout 360m
2024/12/26 15:00:21 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSEngineVersionDataSource_basic
=== PAUSE TestAccRDSEngineVersionDataSource_basic
=== RUN   TestAccRDSEngineVersionDataSource_upgradeTargets
=== PAUSE TestAccRDSEngineVersionDataSource_upgradeTargets
=== RUN   TestAccRDSEngineVersionDataSource_preferred
=== PAUSE TestAccRDSEngineVersionDataSource_preferred
=== RUN   TestAccRDSEngineVersionDataSource_preferredVersionsPreferredUpgradeTargets
=== PAUSE TestAccRDSEngineVersionDataSource_preferredVersionsPreferredUpgradeTargets
=== RUN   TestAccRDSEngineVersionDataSource_preferredUpgradeTargetsVersion
=== PAUSE TestAccRDSEngineVersionDataSource_preferredUpgradeTargetsVersion
=== RUN   TestAccRDSEngineVersionDataSource_preferredMajorTargets
=== PAUSE TestAccRDSEngineVersionDataSource_preferredMajorTargets
=== RUN   TestAccRDSEngineVersionDataSource_defaultOnlyImplicit
=== PAUSE TestAccRDSEngineVersionDataSource_defaultOnlyImplicit
=== RUN   TestAccRDSEngineVersionDataSource_defaultOnlyExplicit
=== PAUSE TestAccRDSEngineVersionDataSource_defaultOnlyExplicit
=== RUN   TestAccRDSEngineVersionDataSource_includeAll
=== PAUSE TestAccRDSEngineVersionDataSource_includeAll
=== RUN   TestAccRDSEngineVersionDataSource_filter
=== PAUSE TestAccRDSEngineVersionDataSource_filter
=== RUN   TestAccRDSEngineVersionDataSource_latest
=== PAUSE TestAccRDSEngineVersionDataSource_latest
=== RUN   TestAccRDSEngineVersionDataSource_hasMinorMajor
=== PAUSE TestAccRDSEngineVersionDataSource_hasMinorMajor
=== CONT  TestAccRDSEngineVersionDataSource_basic
=== CONT  TestAccRDSEngineVersionDataSource_defaultOnlyImplicit
=== CONT  TestAccRDSEngineVersionDataSource_preferredVersionsPreferredUpgradeTargets
=== CONT  TestAccRDSEngineVersionDataSource_filter
--- PASS: TestAccRDSEngineVersionDataSource_defaultOnlyImplicit (9.70s)
=== CONT  TestAccRDSEngineVersionDataSource_hasMinorMajor
--- PASS: TestAccRDSEngineVersionDataSource_basic (10.04s)
=== CONT  TestAccRDSEngineVersionDataSource_latest
--- PASS: TestAccRDSEngineVersionDataSource_preferredVersionsPreferredUpgradeTargets (15.91s)
=== CONT  TestAccRDSEngineVersionDataSource_includeAll
--- PASS: TestAccRDSEngineVersionDataSource_filter (16.68s)
=== CONT  TestAccRDSEngineVersionDataSource_preferred
--- PASS: TestAccRDSEngineVersionDataSource_includeAll (7.91s)
=== CONT  TestAccRDSEngineVersionDataSource_upgradeTargets
--- PASS: TestAccRDSEngineVersionDataSource_preferred (14.50s)
=== CONT  TestAccRDSEngineVersionDataSource_preferredMajorTargets
--- PASS: TestAccRDSEngineVersionDataSource_upgradeTargets (11.71s)
=== CONT  TestAccRDSEngineVersionDataSource_defaultOnlyExplicit
--- PASS: TestAccRDSEngineVersionDataSource_defaultOnlyExplicit (7.88s)
=== CONT  TestAccRDSEngineVersionDataSource_preferredUpgradeTargetsVersion
--- PASS: TestAccRDSEngineVersionDataSource_hasMinorMajor (35.63s)
--- PASS: TestAccRDSEngineVersionDataSource_latest (38.04s)
--- PASS: TestAccRDSEngineVersionDataSource_preferredUpgradeTargetsVersion (7.80s)
--- PASS: TestAccRDSEngineVersionDataSource_preferredMajorTargets (24.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	60.468s

[nam054]

LGTM 🚀

[ewbankkit]

@matthewbaggett Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.83.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!