Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_api_gateway_domain_name - fixed issue when policy is added to private domain name after initial creation #40708

Merged
merged 3 commits into from
Dec 29, 2024
Merged

aws_api_gateway_domain_name - fixed issue when policy is added to private domain name after initial creation #40708

merged 3 commits into from
Dec 29, 2024

Conversation

A-Shevchenko
Copy link
Contributor

Description

Fixes #40699 where error occurs when trying to add policy to existing private domain name

Relations

Closes #40699

Output from Acceptance Testing

$ ACCTEST_PARALLELISM=10 make testacc TESTS=TestAccAPIGatewayDomainName PKG=apigateway
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/apigateway/... -v -count 1 -parallel 10 -run='TestAccAPIGatewayDomainName'  -timeout 360m
2024/12/27 16:26:57 Initializing Terraform AWS Provider...
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_null
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_null
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyMap
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyMap
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_AddOnUpdate
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_AddOnUpdate
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnCreate
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnCreate
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_providerOnly
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_providerOnly
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nonOverlapping
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_overlapping
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_overlapping
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnCreate
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnCreate
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_basic
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_basic
=== RUN   TestAccAPIGatewayDomainNameAccessAssociation_disappears
=== PAUSE TestAccAPIGatewayDomainNameAccessAssociation_disappears
=== RUN   TestAccAPIGatewayDomainNameDataSource_tags
=== PAUSE TestAccAPIGatewayDomainNameDataSource_tags
=== RUN   TestAccAPIGatewayDomainNameDataSource_tags_NullMap
=== PAUSE TestAccAPIGatewayDomainNameDataSource_tags_NullMap
=== RUN   TestAccAPIGatewayDomainNameDataSource_tags_EmptyMap
=== PAUSE TestAccAPIGatewayDomainNameDataSource_tags_EmptyMap
=== RUN   TestAccAPIGatewayDomainNameDataSource_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccAPIGatewayDomainNameDataSource_tags_DefaultTags_nonOverlapping
=== RUN   TestAccAPIGatewayDomainNameDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccAPIGatewayDomainNameDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccAPIGatewayDomainNameDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccAPIGatewayDomainNameDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccAPIGatewayDomainNameDataSource_basic
=== PAUSE TestAccAPIGatewayDomainNameDataSource_basic
=== RUN   TestAccAPIGatewayDomainName_tags
=== PAUSE TestAccAPIGatewayDomainName_tags
=== RUN   TestAccAPIGatewayDomainName_tags_null
=== PAUSE TestAccAPIGatewayDomainName_tags_null
=== RUN   TestAccAPIGatewayDomainName_tags_EmptyMap
=== PAUSE TestAccAPIGatewayDomainName_tags_EmptyMap
=== RUN   TestAccAPIGatewayDomainName_tags_AddOnUpdate
=== PAUSE TestAccAPIGatewayDomainName_tags_AddOnUpdate
=== RUN   TestAccAPIGatewayDomainName_tags_EmptyTag_OnCreate
=== PAUSE TestAccAPIGatewayDomainName_tags_EmptyTag_OnCreate
=== RUN   TestAccAPIGatewayDomainName_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccAPIGatewayDomainName_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccAPIGatewayDomainName_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccAPIGatewayDomainName_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccAPIGatewayDomainName_tags_DefaultTags_providerOnly
=== PAUSE TestAccAPIGatewayDomainName_tags_DefaultTags_providerOnly
=== RUN   TestAccAPIGatewayDomainName_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccAPIGatewayDomainName_tags_DefaultTags_nonOverlapping
=== RUN   TestAccAPIGatewayDomainName_tags_DefaultTags_overlapping
=== PAUSE TestAccAPIGatewayDomainName_tags_DefaultTags_overlapping
=== RUN   TestAccAPIGatewayDomainName_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccAPIGatewayDomainName_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccAPIGatewayDomainName_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccAPIGatewayDomainName_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccAPIGatewayDomainName_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccAPIGatewayDomainName_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccAPIGatewayDomainName_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccAPIGatewayDomainName_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccAPIGatewayDomainName_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccAPIGatewayDomainName_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccAPIGatewayDomainName_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccAPIGatewayDomainName_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccAPIGatewayDomainName_tags_ComputedTag_OnCreate
=== PAUSE TestAccAPIGatewayDomainName_tags_ComputedTag_OnCreate
=== RUN   TestAccAPIGatewayDomainName_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccAPIGatewayDomainName_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccAPIGatewayDomainName_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccAPIGatewayDomainName_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccAPIGatewayDomainName_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccAPIGatewayDomainName_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccAPIGatewayDomainName_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccAPIGatewayDomainName_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccAPIGatewayDomainName_certificateARN
    domain_name_test.go:29: Environment variable ACM_CERTIFICATE_ROOT_DOMAIN is not set. For DNS validation requests, this domain must be publicly accessible and configurable via Route53 during the testing. For email validation requests, you must have access to one of the five standard email addresses used (admin|administrator|hostmaster|postmaster|webmaster)@domain or one of the WHOIS contact addresses.
--- SKIP: TestAccAPIGatewayDomainName_certificateARN (0.00s)
=== RUN   TestAccAPIGatewayDomainName_certificateName
    domain_name_test.go:65: Environment variable AWS_API_GATEWAY_DOMAIN_NAME_CERTIFICATE_BODY is not set. This environment variable must be set to any non-empty value with a publicly trusted certificate body to enable the test.
--- SKIP: TestAccAPIGatewayDomainName_certificateName (0.00s)
=== RUN   TestAccAPIGatewayDomainName_regionalCertificateARN
=== PAUSE TestAccAPIGatewayDomainName_regionalCertificateARN
=== RUN   TestAccAPIGatewayDomainName_regionalCertificateName
    domain_name_test.go:162: Environment variable AWS_API_GATEWAY_DOMAIN_NAME_REGIONAL_CERTIFICATE_NAME_ENABLED is not set. This environment variable must be set to any non-empty value in a region where uploading REGIONAL certificates is allowed to enable the test.
--- SKIP: TestAccAPIGatewayDomainName_regionalCertificateName (0.00s)
=== RUN   TestAccAPIGatewayDomainName_securityPolicy
=== PAUSE TestAccAPIGatewayDomainName_securityPolicy
=== RUN   TestAccAPIGatewayDomainName_private
=== PAUSE TestAccAPIGatewayDomainName_private
=== RUN   TestAccAPIGatewayDomainName_privatePolicy
=== PAUSE TestAccAPIGatewayDomainName_privatePolicy
=== RUN   TestAccAPIGatewayDomainName_privatePolicy_added
=== PAUSE TestAccAPIGatewayDomainName_privatePolicy_added
=== RUN   TestAccAPIGatewayDomainName_disappears
=== PAUSE TestAccAPIGatewayDomainName_disappears
=== RUN   TestAccAPIGatewayDomainName_MutualTLSAuthentication_basic
    domain_name_test.go:360: Environment variable ACM_CERTIFICATE_ROOT_DOMAIN is not set. For DNS validation requests, this domain must be publicly accessible and configurable via Route53 during the testing. For email validation requests, you must have access to one of the five standard email addresses used (admin|administrator|hostmaster|postmaster|webmaster)@domain or one of the WHOIS contact addresses.
--- SKIP: TestAccAPIGatewayDomainName_MutualTLSAuthentication_basic (0.00s)
=== RUN   TestAccAPIGatewayDomainName_MutualTLSAuthentication_ownership
    domain_name_test.go:416: Environment variable ACM_CERTIFICATE_ROOT_DOMAIN is not set. For DNS validation requests, this domain must be publicly accessible and configurable via Route53 during the testing. For email validation requests, you must have access to one of the five standard email addresses used (admin|administrator|hostmaster|postmaster|webmaster)@domain or one of the WHOIS contact addresses.
--- SKIP: TestAccAPIGatewayDomainName_MutualTLSAuthentication_ownership (0.00s)
=== RUN   TestAccAPIGatewayDomainName_updateIDFormat
=== PAUSE TestAccAPIGatewayDomainName_updateIDFormat
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags
=== CONT  TestAccAPIGatewayDomainNameDataSource_basic
=== CONT  TestAccAPIGatewayDomainName_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccAPIGatewayDomainName_tags_DefaultTags_providerOnly
=== CONT  TestAccAPIGatewayDomainName_regionalCertificateARN
=== CONT  TestAccAPIGatewayDomainName_tags_AddOnUpdate
=== CONT  TestAccAPIGatewayDomainName_tags_EmptyTag_OnUpdate_Replace
=== CONT  TestAccAPIGatewayDomainName_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccAPIGatewayDomainName_tags_EmptyTag_OnCreate
=== CONT  TestAccAPIGatewayDomainName_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccAPIGatewayDomainNameDataSource_basic (48.78s)
=== CONT  TestAccAPIGatewayDomainName_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccAPIGatewayDomainName_regionalCertificateARN (58.67s)
=== CONT  TestAccAPIGatewayDomainName_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccAPIGatewayDomainName_tags_DefaultTags_emptyResourceTag (80.23s)
=== CONT  TestAccAPIGatewayDomainName_privatePolicy_added
--- PASS: TestAccAPIGatewayDomainName_tags_DefaultTags_emptyProviderOnlyTag (120.03s)
=== CONT  TestAccAPIGatewayDomainName_updateIDFormat
--- PASS: TestAccAPIGatewayDomainName_tags_EmptyTag_OnUpdate_Add (220.35s)
=== CONT  TestAccAPIGatewayDomainName_disappears
--- PASS: TestAccAPIGatewayDomainName_privatePolicy_added (102.51s)
=== CONT  TestAccAPIGatewayDomainName_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccAPIGatewayDomainName_updateIDFormat (95.98s)
=== CONT  TestAccAPIGatewayDomainName_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags (352.06s)
=== CONT  TestAccAPIGatewayDomainName_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccAPIGatewayDomainName_tags_IgnoreTags_Overlap_ResourceTag (101.01s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccAPIGatewayDomainName_disappears (188.26s)
=== CONT  TestAccAPIGatewayDomainNameDataSource_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccAPIGatewayDomainName_tags_ComputedTag_OnUpdate_Replace (180.41s)
=== CONT  TestAccAPIGatewayDomainNameDataSource_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccAPIGatewayDomainNameDataSource_tags_IgnoreTags_Overlap_ResourceTag (119.39s)
=== CONT  TestAccAPIGatewayDomainNameDataSource_tags_DefaultTags_nonOverlapping
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullNonOverlappingResourceTag (172.67s)
=== CONT  TestAccAPIGatewayDomainNameDataSource_tags_EmptyMap
--- PASS: TestAccAPIGatewayDomainName_tags_IgnoreTags_Overlap_DefaultTag (189.43s)
=== CONT  TestAccAPIGatewayDomainNameDataSource_tags_NullMap
--- PASS: TestAccAPIGatewayDomainName_tags_DefaultTags_providerOnly (564.38s)
=== CONT  TestAccAPIGatewayDomainNameDataSource_tags
--- PASS: TestAccAPIGatewayDomainNameDataSource_tags_DefaultTags_nonOverlapping (53.53s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_disappears
--- PASS: TestAccAPIGatewayDomainNameDataSource_tags_IgnoreTags_Overlap_DefaultTag (184.94s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_basic
--- PASS: TestAccAPIGatewayDomainNameDataSource_tags_EmptyMap (87.51s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_disappears (157.97s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccAPIGatewayDomainName_tags_DefaultTags_nullOverlappingResourceTag (761.70s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccAPIGatewayDomainNameDataSource_tags_NullMap (221.02s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_basic (203.34s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnCreate
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_ResourceTag (213.69s)
=== CONT  TestAccAPIGatewayDomainName_private
--- PASS: TestAccAPIGatewayDomainName_tags_EmptyTag_OnCreate (854.76s)
=== CONT  TestAccAPIGatewayDomainName_privatePolicy
--- PASS: TestAccAPIGatewayDomainName_private (48.87s)
=== CONT  TestAccAPIGatewayDomainName_tags_ComputedTag_OnCreate
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Add (169.58s)
=== CONT  TestAccAPIGatewayDomainName_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccAPIGatewayDomainName_tags_ComputedTag_OnCreate (84.42s)
=== CONT  TestAccAPIGatewayDomainName_securityPolicy
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnUpdate_Replace (211.27s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nonOverlapping
--- PASS: TestAccAPIGatewayDomainName_tags_ComputedTag_OnUpdate_Add (67.44s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_ComputedTag_OnCreate (215.54s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccAPIGatewayDomainName_securityPolicy (69.49s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_IgnoreTags_Overlap_DefaultTag (328.59s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccAPIGatewayDomainName_tags_DefaultTags_updateToResourceOnly (1152.54s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nullOverlappingResourceTag (163.85s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_overlapping
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_nonOverlapping (235.39s)
=== CONT  TestAccAPIGatewayDomainName_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyResourceTag (194.10s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnCreate
--- PASS: TestAccAPIGatewayDomainName_tags_DefaultTags_nullNonOverlappingResourceTag (67.44s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_providerOnly
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToResourceOnly (209.31s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_updateToProviderOnly (157.04s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccAPIGatewayDomainName_tags_AddOnUpdate (1319.36s)
=== CONT  TestAccAPIGatewayDomainName_tags_DefaultTags_overlapping
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_overlapping (214.78s)
=== CONT  TestAccAPIGatewayDomainName_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccAPIGatewayDomainNameDataSource_tags (851.27s)
=== CONT  TestAccAPIGatewayDomainName_tags_null
--- PASS: TestAccAPIGatewayDomainName_tags_DefaultTags_overlapping (113.21s)
=== CONT  TestAccAPIGatewayDomainName_tags_EmptyMap
--- PASS: TestAccAPIGatewayDomainName_tags_DefaultTags_updateToProviderOnly (86.61s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyMap
--- PASS: TestAccAPIGatewayDomainName_tags_null (57.92s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_AddOnUpdate
--- PASS: TestAccAPIGatewayDomainName_privatePolicy (629.36s)
=== CONT  TestAccAPIGatewayDomainName_tags
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_providerOnly (253.85s)
=== CONT  TestAccAPIGatewayDomainName_tags_DefaultTags_nonOverlapping
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyMap (121.22s)
=== CONT  TestAccAPIGatewayDomainNameAccessAssociation_tags_null
--- PASS: TestAccAPIGatewayDomainName_tags_DefaultTags_nonOverlapping (111.16s)
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_AddOnUpdate (172.84s)
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnCreate (445.64s)
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_null (164.94s)
--- PASS: TestAccAPIGatewayDomainName_tags (288.53s)
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Add (508.72s)
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_EmptyTag_OnUpdate_Replace (548.56s)
--- PASS: TestAccAPIGatewayDomainNameAccessAssociation_tags_DefaultTags_emptyProviderOnlyTag (884.12s)
--- PASS: TestAccAPIGatewayDomainName_tags_EmptyTag_OnUpdate_Replace (2010.72s)
--- PASS: TestAccAPIGatewayDomainName_tags_EmptyMap (768.86s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apigateway 2210.080s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/apigateway Issues and PRs that pertain to the apigateway service. needs-triage Waiting for first response or review from a maintainer. labels Dec 27, 2024
@A-Shevchenko A-Shevchenko marked this pull request as ready for review December 27, 2024 16:39
@A-Shevchenko A-Shevchenko requested a review from a team as a code owner December 27, 2024 16:39
github-actions[bot]
github-actions bot reviewed Dec 27, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @A-Shevchenko 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 27, 2024
@ewbankkit ewbankkit self-assigned this Dec 29, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 29, 2024
ewbankkit
ewbankkit approved these changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAPIGatewayDomainName_' PKG=apigateway ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/apigateway/... -v -count 1 -parallel 3  -run=TestAccAPIGatewayDomainName_ -timeout 360m
2024/12/29 15:22:20 Initializing Terraform AWS Provider...
=== RUN   TestAccAPIGatewayDomainName_tags
=== PAUSE TestAccAPIGatewayDomainName_tags
=== RUN   TestAccAPIGatewayDomainName_tags_null
=== PAUSE TestAccAPIGatewayDomainName_tags_null
=== RUN   TestAccAPIGatewayDomainName_tags_EmptyMap
=== PAUSE TestAccAPIGatewayDomainName_tags_EmptyMap
=== RUN   TestAccAPIGatewayDomainName_tags_AddOnUpdate
=== PAUSE TestAccAPIGatewayDomainName_tags_AddOnUpdate
=== RUN   TestAccAPIGatewayDomainName_tags_EmptyTag_OnCreate
=== PAUSE TestAccAPIGatewayDomainName_tags_EmptyTag_OnCreate
=== RUN   TestAccAPIGatewayDomainName_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccAPIGatewayDomainName_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccAPIGatewayDomainName_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccAPIGatewayDomainName_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccAPIGatewayDomainName_tags_DefaultTags_providerOnly
=== PAUSE TestAccAPIGatewayDomainName_tags_DefaultTags_providerOnly
=== RUN   TestAccAPIGatewayDomainName_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccAPIGatewayDomainName_tags_DefaultTags_nonOverlapping
=== RUN   TestAccAPIGatewayDomainName_tags_DefaultTags_overlapping
=== PAUSE TestAccAPIGatewayDomainName_tags_DefaultTags_overlapping
=== RUN   TestAccAPIGatewayDomainName_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccAPIGatewayDomainName_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccAPIGatewayDomainName_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccAPIGatewayDomainName_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccAPIGatewayDomainName_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccAPIGatewayDomainName_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccAPIGatewayDomainName_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccAPIGatewayDomainName_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccAPIGatewayDomainName_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccAPIGatewayDomainName_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccAPIGatewayDomainName_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccAPIGatewayDomainName_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccAPIGatewayDomainName_tags_ComputedTag_OnCreate
=== PAUSE TestAccAPIGatewayDomainName_tags_ComputedTag_OnCreate
=== RUN   TestAccAPIGatewayDomainName_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccAPIGatewayDomainName_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccAPIGatewayDomainName_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccAPIGatewayDomainName_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccAPIGatewayDomainName_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccAPIGatewayDomainName_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccAPIGatewayDomainName_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccAPIGatewayDomainName_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccAPIGatewayDomainName_certificateARN
    domain_name_test.go:29: Environment variable ACM_CERTIFICATE_ROOT_DOMAIN is not set. For DNS validation requests, this domain must be publicly accessible and configurable via Route53 during the testing. For email validation requests, you must have access to one of the five standard email addresses used (admin|administrator|hostmaster|postmaster|webmaster)@domain or one of the WHOIS contact addresses.
--- SKIP: TestAccAPIGatewayDomainName_certificateARN (0.00s)
=== RUN   TestAccAPIGatewayDomainName_certificateName
    domain_name_test.go:65: Environment variable AWS_API_GATEWAY_DOMAIN_NAME_CERTIFICATE_BODY is not set. This environment variable must be set to any non-empty value with a publicly trusted certificate body to enable the test.
--- SKIP: TestAccAPIGatewayDomainName_certificateName (0.00s)
=== RUN   TestAccAPIGatewayDomainName_regionalCertificateARN
=== PAUSE TestAccAPIGatewayDomainName_regionalCertificateARN
=== RUN   TestAccAPIGatewayDomainName_regionalCertificateName
    domain_name_test.go:162: Environment variable AWS_API_GATEWAY_DOMAIN_NAME_REGIONAL_CERTIFICATE_NAME_ENABLED is not set. This environment variable must be set to any non-empty value in a region where uploading REGIONAL certificates is allowed to enable the test.
--- SKIP: TestAccAPIGatewayDomainName_regionalCertificateName (0.00s)
=== RUN   TestAccAPIGatewayDomainName_securityPolicy
=== PAUSE TestAccAPIGatewayDomainName_securityPolicy
=== RUN   TestAccAPIGatewayDomainName_private
=== PAUSE TestAccAPIGatewayDomainName_private
=== RUN   TestAccAPIGatewayDomainName_privatePolicy
=== PAUSE TestAccAPIGatewayDomainName_privatePolicy
=== RUN   TestAccAPIGatewayDomainName_privatePolicy_added
=== PAUSE TestAccAPIGatewayDomainName_privatePolicy_added
=== RUN   TestAccAPIGatewayDomainName_disappears
=== PAUSE TestAccAPIGatewayDomainName_disappears
=== RUN   TestAccAPIGatewayDomainName_MutualTLSAuthentication_basic
    domain_name_test.go:360: Environment variable ACM_CERTIFICATE_ROOT_DOMAIN is not set. For DNS validation requests, this domain must be publicly accessible and configurable via Route53 during the testing. For email validation requests, you must have access to one of the five standard email addresses used (admin|administrator|hostmaster|postmaster|webmaster)@domain or one of the WHOIS contact addresses.
--- SKIP: TestAccAPIGatewayDomainName_MutualTLSAuthentication_basic (0.00s)
=== RUN   TestAccAPIGatewayDomainName_MutualTLSAuthentication_ownership
    domain_name_test.go:416: Environment variable ACM_CERTIFICATE_ROOT_DOMAIN is not set. For DNS validation requests, this domain must be publicly accessible and configurable via Route53 during the testing. For email validation requests, you must have access to one of the five standard email addresses used (admin|administrator|hostmaster|postmaster|webmaster)@domain or one of the WHOIS contact addresses.
--- SKIP: TestAccAPIGatewayDomainName_MutualTLSAuthentication_ownership (0.00s)
=== RUN   TestAccAPIGatewayDomainName_updateIDFormat
=== PAUSE TestAccAPIGatewayDomainName_updateIDFormat
=== CONT  TestAccAPIGatewayDomainName_tags
=== CONT  TestAccAPIGatewayDomainName_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccAPIGatewayDomainName_tags_DefaultTags_providerOnly
--- PASS: TestAccAPIGatewayDomainName_tags_DefaultTags_nullOverlappingResourceTag (67.38s)
=== CONT  TestAccAPIGatewayDomainName_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccAPIGatewayDomainName_tags (138.77s)
=== CONT  TestAccAPIGatewayDomainName_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccAPIGatewayDomainName_tags_DefaultTags_emptyProviderOnlyTag (94.53s)
=== CONT  TestAccAPIGatewayDomainName_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccAPIGatewayDomainName_tags_DefaultTags_emptyResourceTag (76.74s)
=== CONT  TestAccAPIGatewayDomainName_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccAPIGatewayDomainName_tags_DefaultTags_updateToResourceOnly (69.48s)
=== CONT  TestAccAPIGatewayDomainName_tags_DefaultTags_overlapping
--- PASS: TestAccAPIGatewayDomainName_tags_DefaultTags_updateToProviderOnly (77.11s)
=== CONT  TestAccAPIGatewayDomainName_tags_DefaultTags_nonOverlapping
--- PASS: TestAccAPIGatewayDomainName_tags_DefaultTags_overlapping (107.06s)
=== CONT  TestAccAPIGatewayDomainName_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccAPIGatewayDomainName_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccAPIGatewayDomainName_tags_DefaultTags_nonOverlapping (60.87s)
--- PASS: TestAccAPIGatewayDomainName_tags_ComputedTag_OnUpdate_Replace (70.92s)
=== CONT  TestAccAPIGatewayDomainName_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccAPIGatewayDomainName_tags_IgnoreTags_Overlap_ResourceTag (98.24s)
=== CONT  TestAccAPIGatewayDomainName_regionalCertificateARN
--- PASS: TestAccAPIGatewayDomainName_regionalCertificateARN (18.34s)
=== CONT  TestAccAPIGatewayDomainName_privatePolicy_added
--- PASS: TestAccAPIGatewayDomainName_tags_IgnoreTags_Overlap_DefaultTag (70.43s)
=== CONT  TestAccAPIGatewayDomainName_updateIDFormat
--- PASS: TestAccAPIGatewayDomainName_privatePolicy_added (89.87s)
=== CONT  TestAccAPIGatewayDomainName_privatePolicy
--- PASS: TestAccAPIGatewayDomainName_updateIDFormat (83.39s)
=== CONT  TestAccAPIGatewayDomainName_disappears
--- PASS: TestAccAPIGatewayDomainName_privatePolicy (35.81s)
=== CONT  TestAccAPIGatewayDomainName_private
--- PASS: TestAccAPIGatewayDomainName_private (19.64s)
=== CONT  TestAccAPIGatewayDomainName_tags_ComputedTag_OnCreate
--- PASS: TestAccAPIGatewayDomainName_tags_ComputedTag_OnCreate (41.46s)
=== CONT  TestAccAPIGatewayDomainName_securityPolicy
--- PASS: TestAccAPIGatewayDomainName_securityPolicy (20.55s)
=== CONT  TestAccAPIGatewayDomainName_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccAPIGatewayDomainName_tags_ComputedTag_OnUpdate_Add (69.77s)
=== CONT  TestAccAPIGatewayDomainName_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccAPIGatewayDomainName_tags_DefaultTags_nullNonOverlappingResourceTag (24.66s)
=== CONT  TestAccAPIGatewayDomainName_tags_EmptyTag_OnCreate
--- PASS: TestAccAPIGatewayDomainName_tags_EmptyTag_OnCreate (77.57s)
=== CONT  TestAccAPIGatewayDomainName_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccAPIGatewayDomainName_tags_EmptyTag_OnUpdate_Replace (64.49s)
=== CONT  TestAccAPIGatewayDomainName_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccAPIGatewayDomainName_tags_EmptyTag_OnUpdate_Add (66.17s)
=== CONT  TestAccAPIGatewayDomainName_tags_EmptyMap
--- PASS: TestAccAPIGatewayDomainName_disappears (463.63s)
=== CONT  TestAccAPIGatewayDomainName_tags_AddOnUpdate
--- PASS: TestAccAPIGatewayDomainName_tags_EmptyMap (48.99s)
=== CONT  TestAccAPIGatewayDomainName_tags_null
--- PASS: TestAccAPIGatewayDomainName_tags_AddOnUpdate (54.81s)
--- PASS: TestAccAPIGatewayDomainName_tags_null (94.44s)
--- PASS: TestAccAPIGatewayDomainName_tags_DefaultTags_providerOnly (1316.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigateway	1324.153s

@ewbankkit
Copy link
Contributor

@A-Shevchenko Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 48d2e08 into hashicorp:main Dec 29, 2024
21 checks passed
@github-actions github-actions bot added this to the v5.83.0 milestone Dec 29, 2024
@A-Shevchenko A-Shevchenko deleted the b-wrong-arg-getdomainapi-call-40699 branch December 30, 2024 08:22
@A-Shevchenko A-Shevchenko restored the b-wrong-arg-getdomainapi-call-40699 branch December 30, 2024 08:22
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

This functionality has been released in v5.83.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
bug Addresses a defect in current functionality. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.83.0
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_api_gateway_domain_name - wrong parameters for GetDomainName API call
2 participants
@A-Shevchenko @ewbankkit