-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_instance: Set public_dns
and public_ip
as newly Computed if instance is stopped/started
#40710
Conversation
…p` attributes when changing `instance_type`, `user_data`, or `user_data_base64`.
…ly Computed if there was a value.
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
> make testacc TESTARGS='-run=^TestAccEC2Instance_changeInstanceType' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=^TestAccEC2Instance_changeInstanceType -timeout 360m
2024/12/30 11:57:40 Initializing Terraform AWS Provider...
=== RUN TestAccEC2Instance_changeInstanceType
=== PAUSE TestAccEC2Instance_changeInstanceType
=== RUN TestAccEC2Instance_changeInstanceTypeReplace
=== PAUSE TestAccEC2Instance_changeInstanceTypeReplace
=== RUN TestAccEC2Instance_changeInstanceTypeAndUserData
=== PAUSE TestAccEC2Instance_changeInstanceTypeAndUserData
=== RUN TestAccEC2Instance_changeInstanceTypeAndUserDataBase64
=== PAUSE TestAccEC2Instance_changeInstanceTypeAndUserDataBase64
=== CONT TestAccEC2Instance_changeInstanceType
=== CONT TestAccEC2Instance_changeInstanceTypeAndUserData
=== CONT TestAccEC2Instance_changeInstanceTypeAndUserDataBase64
=== CONT TestAccEC2Instance_changeInstanceTypeReplace
--- PASS: TestAccEC2Instance_changeInstanceTypeAndUserDataBase64 (463.68s)
--- PASS: TestAccEC2Instance_changeInstanceType (548.22s)
--- PASS: TestAccEC2Instance_changeInstanceTypeReplace (606.09s)
--- PASS: TestAccEC2Instance_changeInstanceTypeAndUserData (701.85s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 708.698s
This functionality has been released in v5.83.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Set
public_dns
andpublic_ip
as newly Computed if anaws_instance
update would stop then start the instance as this may result in an IP address change -- see https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-instance-addressing.html#concepts-public-addresses.Relations
Closes #6781.
Closes #10720.
Closes #20651.
Closes #24690.
Closes #33726.
Closes #40586.
Output from Acceptance Testing