Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_route53_health_check: add triggers argument #40918

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Jan 14, 2025

Description

This argument will allow for the health check to be synchronized with the upstream CloudWatch alarm when changes are made.

% make testacc PKG=route53 TESTS=TestAccRoute53HealthCheck_triggers
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53HealthCheck_triggers'  -timeout 360m -vet=off
2025/01/14 10:39:47 Initializing Terraform AWS Provider...

--- PASS: TestAccRoute53HealthCheck_triggers (23.64s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53    28.800s

Relations

Closes #29251

References

Output from Acceptance Testing

% make testacc PKG=route53 TESTS=TestAccRoute53HealthCheck_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53HealthCheck_'  -timeout 360m -vet=off
2025/01/14 10:46:44 Initializing Terraform AWS Provider...

--- PASS: TestAccRoute53HealthCheck_disappears (20.63s)
--- PASS: TestAccRoute53HealthCheck_withChildHealthChecks (25.44s)
--- PASS: TestAccRoute53HealthCheck_withHealthCheckRegions (28.06s)
--- PASS: TestAccRoute53HealthCheck_ipv6 (30.28s)
--- PASS: TestAccRoute53HealthCheck_cloudWatchAlarmCheck (30.57s)
--- PASS: TestAccRoute53HealthCheck_basic (36.66s)
--- PASS: TestAccRoute53HealthCheck_ip (39.52s)
--- PASS: TestAccRoute53HealthCheck_withSearchString (39.53s)
--- PASS: TestAccRoute53HealthCheck_disabled (42.84s)
--- PASS: TestAccRoute53HealthCheck_triggers (42.87s)
--- PASS: TestAccRoute53HealthCheck_withSNI (42.88s)
--- PASS: TestAccRoute53HealthCheck_tags (45.26s)
--- PASS: TestAccRoute53HealthCheck_withRoutingControlARN (95.17s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53    100.263s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53 Issues and PRs that pertain to the route53 service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Jan 14, 2025
@jar-b jar-b force-pushed the f-route53_health_check-triggers branch from 8d560e8 to 728b3e6 Compare January 14, 2025 16:15
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@jar-b jar-b force-pushed the f-route53_health_check-triggers branch from 728b3e6 to 4e54080 Compare January 14, 2025 16:20
@jar-b jar-b marked this pull request as ready for review January 14, 2025 16:21
@jar-b jar-b requested a review from a team as a code owner January 14, 2025 16:21
This argument will allow for the health check to be synchronized with
the upstream CloudWatch alarm when changes are made.

```console
% make testacc PKG=route53 TESTS=TestAccRoute53HealthCheck_triggers
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53HealthCheck_triggers'  -timeout 360m -vet=off
2025/01/14 10:39:47 Initializing Terraform AWS Provider...

--- PASS: TestAccRoute53HealthCheck_triggers (23.64s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53    28.800s
```

```console
% make testacc PKG=route53 TESTS=TestAccRoute53HealthCheck_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53HealthCheck_'  -timeout 360m -vet=off
2025/01/14 10:46:44 Initializing Terraform AWS Provider...

--- PASS: TestAccRoute53HealthCheck_disappears (20.63s)
--- PASS: TestAccRoute53HealthCheck_withChildHealthChecks (25.44s)
--- PASS: TestAccRoute53HealthCheck_withHealthCheckRegions (28.06s)
--- PASS: TestAccRoute53HealthCheck_ipv6 (30.28s)
--- PASS: TestAccRoute53HealthCheck_cloudWatchAlarmCheck (30.57s)
--- PASS: TestAccRoute53HealthCheck_basic (36.66s)
--- PASS: TestAccRoute53HealthCheck_ip (39.52s)
--- PASS: TestAccRoute53HealthCheck_withSearchString (39.53s)
--- PASS: TestAccRoute53HealthCheck_disabled (42.84s)
--- PASS: TestAccRoute53HealthCheck_triggers (42.87s)
--- PASS: TestAccRoute53HealthCheck_withSNI (42.88s)
--- PASS: TestAccRoute53HealthCheck_tags (45.26s)
--- PASS: TestAccRoute53HealthCheck_withRoutingControlARN (95.17s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53    100.263s
```
@jar-b jar-b force-pushed the f-route53_health_check-triggers branch from 4e54080 to a5f9dd4 Compare January 14, 2025 16:47
@ewbankkit ewbankkit self-assigned this Jan 14, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRoute53HealthCheck_' PKG=route53 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/route53/... -v -count 1 -parallel 3  -run=TestAccRoute53HealthCheck_ -timeout 360m -vet=off
2025/01/14 13:28:29 Initializing Terraform AWS Provider...
=== RUN   TestAccRoute53HealthCheck_basic
=== PAUSE TestAccRoute53HealthCheck_basic
=== RUN   TestAccRoute53HealthCheck_tags
=== PAUSE TestAccRoute53HealthCheck_tags
=== RUN   TestAccRoute53HealthCheck_withSearchString
=== PAUSE TestAccRoute53HealthCheck_withSearchString
=== RUN   TestAccRoute53HealthCheck_withChildHealthChecks
=== PAUSE TestAccRoute53HealthCheck_withChildHealthChecks
=== RUN   TestAccRoute53HealthCheck_withHealthCheckRegions
=== PAUSE TestAccRoute53HealthCheck_withHealthCheckRegions
=== RUN   TestAccRoute53HealthCheck_ip
=== PAUSE TestAccRoute53HealthCheck_ip
=== RUN   TestAccRoute53HealthCheck_ipv6
=== PAUSE TestAccRoute53HealthCheck_ipv6
=== RUN   TestAccRoute53HealthCheck_cloudWatchAlarmCheck
=== PAUSE TestAccRoute53HealthCheck_cloudWatchAlarmCheck
=== RUN   TestAccRoute53HealthCheck_triggers
=== PAUSE TestAccRoute53HealthCheck_triggers
=== RUN   TestAccRoute53HealthCheck_withSNI
=== PAUSE TestAccRoute53HealthCheck_withSNI
=== RUN   TestAccRoute53HealthCheck_disabled
=== PAUSE TestAccRoute53HealthCheck_disabled
=== RUN   TestAccRoute53HealthCheck_withRoutingControlARN
=== PAUSE TestAccRoute53HealthCheck_withRoutingControlARN
=== RUN   TestAccRoute53HealthCheck_disappears
=== PAUSE TestAccRoute53HealthCheck_disappears
=== CONT  TestAccRoute53HealthCheck_basic
=== CONT  TestAccRoute53HealthCheck_cloudWatchAlarmCheck
=== CONT  TestAccRoute53HealthCheck_withHealthCheckRegions
--- PASS: TestAccRoute53HealthCheck_withHealthCheckRegions (12.81s)
=== CONT  TestAccRoute53HealthCheck_ipv6
--- PASS: TestAccRoute53HealthCheck_cloudWatchAlarmCheck (14.25s)
=== CONT  TestAccRoute53HealthCheck_withSearchString
--- PASS: TestAccRoute53HealthCheck_basic (18.92s)
=== CONT  TestAccRoute53HealthCheck_withChildHealthChecks
--- PASS: TestAccRoute53HealthCheck_ipv6 (14.30s)
=== CONT  TestAccRoute53HealthCheck_disabled
--- PASS: TestAccRoute53HealthCheck_withChildHealthChecks (11.58s)
=== CONT  TestAccRoute53HealthCheck_disappears
--- PASS: TestAccRoute53HealthCheck_withSearchString (18.19s)
=== CONT  TestAccRoute53HealthCheck_withRoutingControlARN
--- PASS: TestAccRoute53HealthCheck_disappears (9.22s)
=== CONT  TestAccRoute53HealthCheck_withSNI
--- PASS: TestAccRoute53HealthCheck_disabled (24.26s)
=== CONT  TestAccRoute53HealthCheck_tags
--- PASS: TestAccRoute53HealthCheck_withSNI (24.04s)
=== CONT  TestAccRoute53HealthCheck_ip
--- PASS: TestAccRoute53HealthCheck_tags (23.93s)
=== CONT  TestAccRoute53HealthCheck_triggers
--- PASS: TestAccRoute53HealthCheck_ip (17.52s)
--- PASS: TestAccRoute53HealthCheck_triggers (21.71s)
--- PASS: TestAccRoute53HealthCheck_withRoutingControlARN (81.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	119.239s

@jar-b jar-b merged commit 0418fc8 into main Jan 14, 2025
50 checks passed
@jar-b jar-b deleted the f-route53_health_check-triggers branch January 14, 2025 21:02
@github-actions github-actions bot added this to the v5.84.0 milestone Jan 14, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Jan 14, 2025
Copy link

This functionality has been released in v5.84.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/route53 Issues and PRs that pertain to the route53 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_route53_health_check does not synchronize configuration after an apply
2 participants