-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_route53_health_check: add triggers
argument
#40918
Conversation
8d560e8
to
728b3e6
Compare
Community NoteVoting for Prioritization
For Submitters
|
728b3e6
to
4e54080
Compare
This argument will allow for the health check to be synchronized with the upstream CloudWatch alarm when changes are made. ```console % make testacc PKG=route53 TESTS=TestAccRoute53HealthCheck_triggers make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.3 test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53HealthCheck_triggers' -timeout 360m -vet=off 2025/01/14 10:39:47 Initializing Terraform AWS Provider... --- PASS: TestAccRoute53HealthCheck_triggers (23.64s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/route53 28.800s ``` ```console % make testacc PKG=route53 TESTS=TestAccRoute53HealthCheck_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.3 test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53HealthCheck_' -timeout 360m -vet=off 2025/01/14 10:46:44 Initializing Terraform AWS Provider... --- PASS: TestAccRoute53HealthCheck_disappears (20.63s) --- PASS: TestAccRoute53HealthCheck_withChildHealthChecks (25.44s) --- PASS: TestAccRoute53HealthCheck_withHealthCheckRegions (28.06s) --- PASS: TestAccRoute53HealthCheck_ipv6 (30.28s) --- PASS: TestAccRoute53HealthCheck_cloudWatchAlarmCheck (30.57s) --- PASS: TestAccRoute53HealthCheck_basic (36.66s) --- PASS: TestAccRoute53HealthCheck_ip (39.52s) --- PASS: TestAccRoute53HealthCheck_withSearchString (39.53s) --- PASS: TestAccRoute53HealthCheck_disabled (42.84s) --- PASS: TestAccRoute53HealthCheck_triggers (42.87s) --- PASS: TestAccRoute53HealthCheck_withSNI (42.88s) --- PASS: TestAccRoute53HealthCheck_tags (45.26s) --- PASS: TestAccRoute53HealthCheck_withRoutingControlARN (95.17s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/route53 100.263s ```
4e54080
to
a5f9dd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRoute53HealthCheck_' PKG=route53 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/route53/... -v -count 1 -parallel 3 -run=TestAccRoute53HealthCheck_ -timeout 360m -vet=off
2025/01/14 13:28:29 Initializing Terraform AWS Provider...
=== RUN TestAccRoute53HealthCheck_basic
=== PAUSE TestAccRoute53HealthCheck_basic
=== RUN TestAccRoute53HealthCheck_tags
=== PAUSE TestAccRoute53HealthCheck_tags
=== RUN TestAccRoute53HealthCheck_withSearchString
=== PAUSE TestAccRoute53HealthCheck_withSearchString
=== RUN TestAccRoute53HealthCheck_withChildHealthChecks
=== PAUSE TestAccRoute53HealthCheck_withChildHealthChecks
=== RUN TestAccRoute53HealthCheck_withHealthCheckRegions
=== PAUSE TestAccRoute53HealthCheck_withHealthCheckRegions
=== RUN TestAccRoute53HealthCheck_ip
=== PAUSE TestAccRoute53HealthCheck_ip
=== RUN TestAccRoute53HealthCheck_ipv6
=== PAUSE TestAccRoute53HealthCheck_ipv6
=== RUN TestAccRoute53HealthCheck_cloudWatchAlarmCheck
=== PAUSE TestAccRoute53HealthCheck_cloudWatchAlarmCheck
=== RUN TestAccRoute53HealthCheck_triggers
=== PAUSE TestAccRoute53HealthCheck_triggers
=== RUN TestAccRoute53HealthCheck_withSNI
=== PAUSE TestAccRoute53HealthCheck_withSNI
=== RUN TestAccRoute53HealthCheck_disabled
=== PAUSE TestAccRoute53HealthCheck_disabled
=== RUN TestAccRoute53HealthCheck_withRoutingControlARN
=== PAUSE TestAccRoute53HealthCheck_withRoutingControlARN
=== RUN TestAccRoute53HealthCheck_disappears
=== PAUSE TestAccRoute53HealthCheck_disappears
=== CONT TestAccRoute53HealthCheck_basic
=== CONT TestAccRoute53HealthCheck_cloudWatchAlarmCheck
=== CONT TestAccRoute53HealthCheck_withHealthCheckRegions
--- PASS: TestAccRoute53HealthCheck_withHealthCheckRegions (12.81s)
=== CONT TestAccRoute53HealthCheck_ipv6
--- PASS: TestAccRoute53HealthCheck_cloudWatchAlarmCheck (14.25s)
=== CONT TestAccRoute53HealthCheck_withSearchString
--- PASS: TestAccRoute53HealthCheck_basic (18.92s)
=== CONT TestAccRoute53HealthCheck_withChildHealthChecks
--- PASS: TestAccRoute53HealthCheck_ipv6 (14.30s)
=== CONT TestAccRoute53HealthCheck_disabled
--- PASS: TestAccRoute53HealthCheck_withChildHealthChecks (11.58s)
=== CONT TestAccRoute53HealthCheck_disappears
--- PASS: TestAccRoute53HealthCheck_withSearchString (18.19s)
=== CONT TestAccRoute53HealthCheck_withRoutingControlARN
--- PASS: TestAccRoute53HealthCheck_disappears (9.22s)
=== CONT TestAccRoute53HealthCheck_withSNI
--- PASS: TestAccRoute53HealthCheck_disabled (24.26s)
=== CONT TestAccRoute53HealthCheck_tags
--- PASS: TestAccRoute53HealthCheck_withSNI (24.04s)
=== CONT TestAccRoute53HealthCheck_ip
--- PASS: TestAccRoute53HealthCheck_tags (23.93s)
=== CONT TestAccRoute53HealthCheck_triggers
--- PASS: TestAccRoute53HealthCheck_ip (17.52s)
--- PASS: TestAccRoute53HealthCheck_triggers (21.71s)
--- PASS: TestAccRoute53HealthCheck_withRoutingControlARN (81.51s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/route53 119.239s
This functionality has been released in v5.84.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
This argument will allow for the health check to be synchronized with the upstream CloudWatch alarm when changes are made.
Relations
Closes #29251
References
Output from Acceptance Testing