Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup tfprovlint001 (Remove d.SetId() in Delete) #4191

Closed
91 tasks
bflad opened this issue Apr 12, 2018 · 1 comment · Fixed by #4415
Closed
91 tasks

Cleanup tfprovlint001 (Remove d.SetId() in Delete) #4191

bflad opened this issue Apr 12, 2018 · 1 comment · Fixed by #4415
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Apr 12, 2018

Experimenting with: https://github.com/paultyng/tfprovlint

Calling d.SetId() is not necessary in resource deletion functions.

  • [resource.aws_acm_certificate] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_acm_certificate.go:254:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_acm_certificate_validation] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_acm_certificate_validation.go:163:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_alb_target_group_attachment] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_lb_target_group_attachment.go:107:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_ami] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_ami.go:311:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_ami_copy] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_ami.go:311:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_ami_from_instance] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_ami.go:311:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_api_gateway_account] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_api_gateway_account.go:125:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_appautoscaling_policy] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_appautoscaling_policy.go:352:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_appautoscaling_scheduled_action] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_appautoscaling_scheduled_action.go:187:11: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_appautoscaling_target] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_appautoscaling_target.go:133:10: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_autoscaling_group] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_autoscaling_group.go:749:10: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_autoscaling_lifecycle_hook] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_autoscaling_lifecycle_hook.go:134:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_autoscaling_policy] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_autoscaling_policy.go:276:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_batch_job_definition] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_batch_job_definition.go:140:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_cloudformation_stack] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_cloudformation_stack.go:562:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_cloudfront_distribution] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_cloudfront_distribution.go:702:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_cloudfront_origin_access_identity] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_cloudfront_origin_access_identity.go:123:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_cloudwatch_dashboard] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_cloudwatch_dashboard.go:106:11: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_cloudwatch_event_rule] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_cloudwatch_event_rule.go:218:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_cloudwatch_event_target] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_cloudwatch_event_target.go:274:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_cloudwatch_log_destination] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_cloudwatch_log_destination.go:124:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_cloudwatch_log_destination_policy] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_cloudwatch_log_destination_policy.go:86:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_cloudwatch_log_group] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_cloudwatch_log_group.go:270:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_cloudwatch_log_metric_filter] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_cloudwatch_log_metric_filter.go:192:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_cloudwatch_log_subscription_filter] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_cloudwatch_log_subscription_filter.go:183:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_cloudwatch_metric_alarm] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_cloudwatch_metric_alarm.go:227:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_codebuild_project] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_codebuild_project.go:629:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_codedeploy_app] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_codedeploy_app.go:113:11: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_codedeploy_deployment_group] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_codedeploy_deployment_group.go:611:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_codepipeline] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_codepipeline.go:491:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_config_config_rule] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_config_config_rule.go:298:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_config_configuration_recorder] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_config_configuration_recorder.go:147:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_config_configuration_recorder_status] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_config_configuration_recorder_status.go:120:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_config_delivery_channel] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_config_delivery_channel.go:181:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_customer_gateway] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_customer_gateway.go:239:11: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_dax_cluster] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_dax_cluster.go:488:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_default_network_acl] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_default_network_acl.go:246:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_default_route_table] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_default_route_table.go:158:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_dms_replication_task] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_dms_replication_task.go:261:11: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_ecr_lifecycle_policy] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_ecr_lifecycle_policy.go:98:11: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_ecr_repository] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_ecr_repository.go:148:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_ecr_repository_policy] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_ecr_repository_policy.go:156:12: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_ecs_service] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_ecs_service.go:597:10: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_eip] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_eip.go:221:10: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_elastic_beanstalk_application_version] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_elastic_beanstalk_application_version.go:156:12: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_elasticsearch_domain_policy] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_elasticsearch_domain_policy.go:125:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_emr_cluster] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_emr_cluster.go:830:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_emr_security_configuration] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_emr_security_configuration.go:109:11: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_iam_account_alias] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_iam_account_alias.go:91:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_iam_account_password_policy] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_iam_account_password_policy.go:164:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_iam_instance_profile] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_iam_instance_profile.go:298:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_iam_server_certificate] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_iam_server_certificate.go:190:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_inspector_resource_group] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_inspector_resource_group.go:73:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_instance] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_instance.go:1097:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_kinesis_firehose_delivery_stream] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_kinesis_firehose_delivery_stream.go:1602:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_kinesis_stream] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_kinesis_stream.go:232:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_kms_alias] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_kms_alias.go:169:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_kms_key] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_kms_key.go:476:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_lambda_alias] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_lambda_alias.go:122:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_lambda_event_source_mapping] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_lambda_event_source_mapping.go:178:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_lambda_function] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_lambda_function.go:584:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_lambda_permission] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_lambda_permission.go:324:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_lb_target_group_attachment] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_lb_target_group_attachment.go:107:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_lightsail_instance] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_lightsail_instance.go:233:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_lightsail_key_pair] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_lightsail_key_pair.go:223:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_load_balancer_backend_server_policy] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_load_balancer_backend_server_policy.go:131:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_load_balancer_listener_policy] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_load_balancer_listener_policy.go:131:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_load_balancer_policy] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_load_balancer_policy.go:208:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_media_store_container] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_media_store_container.go:121:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_network_interface_sg_attachment] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_network_interface_sg_attachment.go:119:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_opsworks_instance] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_opsworks_instance.go:862:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_placement_group] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_placement_group.go:151:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_proxy_protocol_policy] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_proxy_protocol_policy.go:170:11: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_route53_record] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_route53_record.go:705:11: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_route53_zone] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_route53_zone.go:281:11: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_route] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_route.go:428:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_s3_bucket_metric] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_s3_bucket_metric.go:113:11: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_s3_bucket_notification] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_s3_bucket_notification.go:349:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_security_group_rule] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_security_group_rule.go:357:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_service_discovery_private_dns_namespace] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_service_discovery_private_dns_namespace.go:130:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_service_discovery_public_dns_namespace] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_service_discovery_public_dns_namespace.go:129:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_simpledb_domain] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_simpledb_domain.go:82:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_ssm_document] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_ssm_document.go:350:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_ssm_parameter] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_ssm_parameter.go:170:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_volume_attachment] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_volume_attachment.go:253:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_vpc_dhcp_options_association] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_vpc_dhcp_options_association.go:97:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_vpc_peering_connection_accepter] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_vpc_peering_connection_accepter.go:72:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_vpn_connection] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_vpn_connection.go:464:11: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_vpn_connection_route] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_vpn_connection_route.go:109:11: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_vpn_gateway_attachment] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_vpn_gateway_attachment.go:166:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
  • [resource.aws_vpn_gateway_route_propagation] [tfprovlint001] /Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_vpn_gateway_route_propagation.go:67:9: DeleteFunc should not call (*github.com/hashicorp/terraform/helper/schema.ResourceData).SetId
@bflad bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. provider Pertains to the provider itself, rather than any interaction with AWS. labels Apr 12, 2018
@bflad bflad added this to the v1.17.0 milestone May 1, 2018
@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
1 participant