Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_cognito_user_group passes group description in AWS request as role_arn property #4236

Closed
npellegrin opened this issue Apr 17, 2018 · 5 comments · Fixed by #4237
Closed
Labels
bug Addresses a defect in current functionality.
Milestone

Comments

@npellegrin
Copy link
Contributor

npellegrin commented Apr 17, 2018

Hello.

I am facing a very strange behavior, I believe that it is a Terraform provider bug, but feel free to close the ticket if not :)

Terraform Version

Terraform v0.11.6

  • provider.aws v1.14.1
  • provider.external v1.0.0
  • provider.local v1.1.0
  • provider.null v1.0.0

Affected Resource(s)

  • aws_cognito_user_group

Terraform Configuration Files

resource "aws_cognito_user_group" "team" {
  name        = "team"
  description = Team group (managed by Terraform)"

  user_pool_id = "${aws_cognito_user_pool.api_users.id}"
  role_arn     = "${aws_iam_role.opteam_role.arn}"
}

Debug Output

https://gist.github.com/npellegrin/72b9d54bc494d95e712df5ab4d2e5061
Error message is: Invalid ARN format Team group (managed by Terraform)

Expected Behavior

The group should have been modified with the correct role ARN.

Actual Behavior

It seems that in the request performed to Amazon, Terraform sends the group description as role_arn (as seen in the error message) preventing to update the resource.

Steps to Reproduce

terraform apply

@bflad bflad added bug Addresses a defect in current functionality. service/cognito labels Apr 17, 2018
@bflad
Copy link
Contributor

bflad commented Apr 17, 2018

Hi @npellegrin 👋 Thanks for reporting this and sorry you ran into the unexpected behavior.

It does indeed look like there is a bug with updating the role_arn with the aws_cognito_user_group resource:

https://github.com/terraform-providers/terraform-provider-aws/blob/29a75f23e19a1047fed36345c0221657cc06e49b/aws/resource_aws_cognito_user_group.go#L132-L134

Submitting a bugfix PR shortly.

@bflad
Copy link
Contributor

bflad commented Apr 17, 2018

Bugfix PR submitted: #4237

@npellegrin
Copy link
Contributor Author

Thank you for the fix :)

@bflad
Copy link
Contributor

bflad commented Apr 18, 2018

This has been released in version 1.15.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@bflad bflad added this to the v1.15.0 milestone Apr 18, 2018
@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants