aws_spot_fleet_request not respect key_name and iam_instance_profile

[hashibot]

This issue was originally opened by @benjah1 as hashicorp/terraform#11447. It was migrated here as part of the provider split. The original body of the issue is below.

---

Terraform Version

Terraform v0.8.4

Affected Resource(s)

• aws_spot_fleet_request

Terraform Configuration Files

resource "aws_spot_fleet_request" "spot" {
        iam_fleet_role = "arn:aws:iam::xxx:role/aws-ec2-spot-fleet-role"
        allocation_strategy = "lowestPrice"
        target_capacity = 1
        valid_until = "2018-01-01T00:00:00Z"
        spot_price = "0.108"

        launch_specification {
                instance_type = "m4.large"
                ami = "ami-64270201"
                iam_instance_profile = "ecsInstanceRole"
                spot_price = "0.108"
                availability_zone = "us-east-2a"
                subnet_id = "${data.aws_subnet.subnet.id}"
                vpc_security_group_ids = ["${data.aws_security_group.sg.id}"]
                ebs_optimized = true
    }
}

Expected Behavior

To create spot fleet request,

1. without key pair
2. with IAM role "ecsInstanceRole"

Actual Behavior

1. Instance fail to start with failed: Invalid value '' for keyPairNames. It should not be blank.
2. IAM role is empty.

Note

I also try with key_name = false, but it just convert to "0".

[svenwltr]

This is still an issue with v0.9.11. If I see it correctly it is because Terraform sends an empty key_name, but it would work if the field wouldn't get sent at all.

[svenwltr]

1. Got solved in fix empty key_name on aws_spot_fleet_request #1203 and will probably part of the next release (0.1.4).
2. The IAM role doesn't get created by Terraform nor implicitly by the AWS API (but yes, the AWS Web UI implicitly does this). This should be an existing role with the proper access rights.

[Ninir]

Hey @svenwltr

Since the UI does it for you, it is part of the process of doing it. I personally don't think Terraform should handle it, and hide some magic.

I would like to close the issue since the bug has been fixed. Tell me what you think 😄

[svenwltr]

@Ninir I fully agree with not doing any magic in Terraform. Also, I am already slightly annoyed by the UI, when it created some random roles in the background.

Yes, this issue is resolved to me too.

[Ninir]

Thank you for the quick answer @svenwltr :) 👍

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!