r/aws_default_subnet: Full resource lifecycle

[ewbankkit]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Now that default subnets can be created we should think about a "next generation" aws_default_subnet resource that can do full resource lifecycle operations (Create and Delete along with Read and Update).

[ewbankkit]

Replaces #2254.

[gdavison]

The Delete operation gets potentially dangerous here, since the old behaviour was to simply remove from state.

We could leverage the diagnostic warnings added in Plugin SDK v2.

[ewbankkit]

v4.0.0 Design

Modify the aws_default_subnet resource to be able to Create and Delete default subnets.
This will be implemented so as to maximize infrastructure safety and minimize practitioner surprise.
If a default subnet already exists in the specified Availability Zone, on resource Create adopt the resource into management, otherwise call the CreateDefaultSubnet API to create a new default subnet.
On resource Delete the default subnet is not deleted (it is removed from Terraform state), unless the configuration sets the new argument force_destroy = true. This argument’s default value will be false.

[anGie44]

Implementation complete with merge of #22253

[github-actions]

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.