Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

point in time restore support for aws rds instances #5286

Closed
psura opened this issue Jul 20, 2018 · 9 comments
Closed

point in time restore support for aws rds instances #5286

psura opened this issue Jul 20, 2018 · 9 comments
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@psura
Copy link

psura commented Jul 20, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Today terraform aws provider support managing rds instances through aws_db_instace resource.
https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/resource_aws_db_instance.go
This resource also supports restoring from a snapshot if snapshot_identifier is passed and also supports restore db instance from s3.
We don't seem to have support for restoring to a specific point in time. This maps to below AWS API
https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_RestoreDBInstanceToPointInTime.html

We are trying to reduce the restore times when an incident occurs that requires db instance restore so that we can meet our RTO (and RPO) and quickly bring the production back to business.
Having an automated restore procedure in place is very critical. In our case we are using aws rds postgres and also have plans to move to aurora in future.
Since we would like Terraform to manage the existing and newly created resources (from restore), we are looking forward for the restore to a point in time support in terraform (for rds instances as of now).

Is this in the road map? Can some one share details on timeline or what is needed to get this feature support? I am new to the go programming but am myself looking at the aws provider code base to see what can be done. Any help is appreciated.

New or Affected Resource(s)

  • aws_db_instance

References

I see some discussion in google group here https://groups.google.com/d/topic/terraform-tool/vDUw9YmqtN4/discussion and a suggestion from Paul Hinze.
AWS API
https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_RestoreDBInstanceToPointInTime.html

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. labels Jul 21, 2018
@ewbankkit
Copy link
Contributor

Aurora point-in-time restore: #7031.

@chadmyers
Copy link

Is there any way to bump this up in priority to get the PR reviewed and merged? Is there anything I can do to help. Thanks!

@dilunika
Copy link

dilunika commented Aug 19, 2020

Since this is open from 2018, I assume there would be a work around. Can anyone suggest what would be the workaround let Terraform to mange the point-in-time recovery or let terraform to manage both instances when we restore from a snapshot?

Thanks,
Kasun

@bflad bflad added this to the Roadmap milestone Aug 20, 2020
@maryelizbeth
Copy link
Contributor

@chadmyers This issue is prioritized as part of our roadmap work for August-October. We haven't yet started work for it, but will reach out to the contributing PR author as well as on this issue as we work through the items in our roadmap and begin work on point in time restore.

Once this feature is scheduled for release, it will move from the roadmap milestone into a release milestone (e.g. v3.3.0).

Hope this clears things up, and please reach out if you have any questions!

@mdykes-gw
Copy link

Checking in... haven't seen it in 3.10 or 3.11... how's it looking?

@jbhennin
Copy link

@maryelizbeth Any update on this enhancement. Being able to do PITR via TF is a very needed feature as it has been in the AWS apis for some time

@anGie44
Copy link
Contributor

anGie44 commented Nov 12, 2020

Support for PointInTimeRestore has been merged for both rds_cluster and db_instance resources and will release with v3.15.0 of the Terraform AWS Provider, expected out later today.

@anGie44 anGie44 closed this as completed Nov 12, 2020
@ghost
Copy link

ghost commented Nov 12, 2020

This has been released in version 3.15.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
Development

No branches or pull requests

9 participants