Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AWS ALB redirect action #5475

Closed
fdearle opened this issue Aug 8, 2018 · 3 comments
Closed

Add support for AWS ALB redirect action #5475

fdearle opened this issue Aug 8, 2018 · 3 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service.

Comments

@fdearle
Copy link

fdearle commented Aug 8, 2018

Amazon have recently announced support for redirects natively within Application Load Balancers. See Announcement.

This is a useful addition to the ALB as is removes the need to have a separate web server to handle HTTP -> HTTPS redirects.

Configuring the feature requires changes to the aws_lb_listener in terraform. Specifically the default_action needs to support redirect as a type and must also implement a new field type to support the new RedirectActionConfig that has been added to default_action.

The AWS Go SDK has already been updated to support RedirectActionConfig in version 1.14.33.

I would attempt to implement this myself except my limited Go experience does not extend to the schema changes that would need to be implemented to support a new redirect_action_config field type.

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

New or Affected Resource(s)

  • aws_lb_listener

Potential Terraform Configuration

# The default action will need to support a redirect_action_config, something like:
resource "aws_lb_listener" "default_listener"  {
    ....
    default_action {
        type = "redirect"
        redirect_action_config = {
            protocol = "HTTPS | HTTP | #{protocol}"
            host = "hostname | #{host}"
            port = "port | #{port}"
            path = "path | #{path}"
            query = "query | #{query}"
        }
    }
}

References

  • #0000
@ghost
Copy link

ghost commented Aug 8, 2018

There is already an issue filled for this and a PR pending:
#5344
#5430

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Aug 8, 2018
@bflad
Copy link
Contributor

bflad commented Aug 8, 2018

Closing as duplicate of the above mentioned issue and PR to consolidate discussions/efforts. Please track those for further updates. 👍

@bflad bflad closed this as completed Aug 8, 2018
@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service.
Projects
None yet
Development

No branches or pull requests

2 participants