Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_flow_log - add support for sending to S3 #5482

Closed
ryandeivert opened this issue Aug 8, 2018 · 4 comments · Fixed by #5509
Closed

aws_flow_log - add support for sending to S3 #5482

ryandeivert opened this issue Aug 8, 2018 · 4 comments · Fixed by #5509
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@ryandeivert
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Support S3 as a delivery destination for VPC Flow Logs. As of 2018-08-08, AWS announced support for sending vpc flow logs to s3 (as oppose to the currently supported CloudWatch Logs group). The API docs are updated to include this support, and the aws-sdk-go has been updated to support this. The interface has changed a bit for this API, and different parameters are now used.

New or Affected Resource(s)

  • aws_flow_log

Potential Terraform Configuration

resource "aws_flow_log" "test_flow_log" {
  log_destination_type = "s3"
  log_destination      = "${aws_s3_bucket.test_bucket.arn}"
  iam_role_arn         = "${aws_iam_role.test_role.arn}"
  resource_type        = "VPC"
  resource_ids         = ["${aws_vpc.default.id}"]
  traffic_type         = "ALL"
}

References

  • N/A
@ryandeivert
Copy link
Contributor Author

note - I am happy to work on this (can you assign to me?)

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. labels Aug 8, 2018
@bflad bflad added this to the v1.42.0 milestone Oct 25, 2018
@bflad
Copy link
Contributor

bflad commented Oct 25, 2018

Support for new log_destination and log_destination_type arguments to enable sending to S3 has been merged and will release with version 1.42.0 of the AWS provider sometime in the next week or so. Thanks @ryandeivert and @ewbankkit!

@bflad
Copy link
Contributor

bflad commented Nov 1, 2018

This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants