ecr_registry: repositry_url output doesn't support china/gov region

[ofirnn]

Terraform Version

0.11.3

Affected Resource(s)

• aws_ecr_repository

Terraform Configuration Files

output "e2e_ecr_url" {
value = "${aws_ecr_repository.attribution-cf-e2e.repository_url}"
}

Debug Output

Expected Behavior

URL ends with com.cn for cn-north-1 region

Actual Behavior

URL ends with com for cn-north-1 region

Steps to Reproduce

Create ECR repository in china
Try to output the URL

[ofirnn]

https://github.com/terraform-providers/terraform-provider-aws/blob/269f4095e9c285fbc0468805a350ee0938a2e4d9/aws/resource_aws_ecr_repository.go#L103

[bflad]

I have submitted a bug fix pull request for this resource to use the RepositoryUri attribute from the API (was not available when the resource was first created) instead of building it ourselves: #5748

[bflad]

The fix for this has been merged into master and will release with version 1.35.0 of the AWS provider, likely middle of next week. 👍

[bflad]

This has been released in version 1.35.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!