Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support for Aurora Parallel Queries #5977

Closed
chrisdewar opened this issue Sep 25, 2018 · 4 comments · Fixed by #5980
Closed

Feature Request: Support for Aurora Parallel Queries #5977

chrisdewar opened this issue Sep 25, 2018 · 4 comments · Fixed by #5980
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@chrisdewar
Copy link

chrisdewar commented Sep 25, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

See feature here:
https://aws.amazon.com/blogs/aws/new-parallel-query-for-amazon-aurora/

It would seem that most of the groundwork is already in place to support this feature, however some validation of the engine_mode argument seems to be preventing this from going through. Maybe that is an oversimiplification of the problem though...

New or Affected Resource(s)

  • aws_rds_cluster

Potential Terraform Configuration

resource "aws_rds_cluster" "default" {
  cluster_identifier      = "aurora-cluster-demo"
  availability_zones      = ["us-west-2a", "us-west-2b", "us-west-2c"]
  database_name           = "mydb"
  master_username         = "foo"
  master_password         = "bar"
  backup_retention_period = 5
  preferred_backup_window = "07:00-09:00"
  engine                  = "aurora"
  engine_mode             = "parallelquery"
}

Current error:

Error: aws_rds_cluster.persistence-platform-master: expected engine_mode to be one of [provisioned serverless], got parallelquery

References

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. labels Sep 25, 2018
@bflad
Copy link
Contributor

bflad commented Sep 25, 2018

Hi @chrisdewar 👋 Thanks for submitting this! Indeed it looks like we just needed to open up the engine_mode validation for this new value. I have submitted a pull request with updated validation, testing, and documentation here: #5980

@bflad bflad added this to the v1.38.0 milestone Sep 25, 2018
@bflad
Copy link
Contributor

bflad commented Sep 25, 2018

Support for parallelquery has been merged in and will release with version 1.38.0 of the AWS provider, likely tomorrow. 👍

@bflad
Copy link
Contributor

bflad commented Sep 26, 2018

This has been released in version 1.38.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants