Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDS Deletion Protection API Support (aws_rds_cluster) #6007

Closed
bflad opened this issue Sep 27, 2018 · 4 comments · Fixed by #6010
Closed

RDS Deletion Protection API Support (aws_rds_cluster) #6007

bflad opened this issue Sep 27, 2018 · 4 comments · Fixed by #6010
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Sep 27, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS Go SDK v1.15.43 (dependency PR #6002) includes a new DeletionProtection boolean parameter:

	// Indicates if the DB cluster should have deletion protection enabled. The
 	// database can't be deleted when this value is set to true. The default is
 	// false.
 	DeletionProtection *bool `type:"boolean"`

It is implemented in the following API types:

  • CreateDBClusterInput
  • ModifyDBClusterInput
  • RestoreDBClusterFromSnapshotInput
  • RestoreDBClusterFromS3Input

New or Affected Resource(s)

  • aws_rds_cluster

Potential Terraform Configuration

# Example implementation, details may change during development
resource "aws_rds_cluster" "example" {
  # ... other configuration ...

  deletion_protection = true
}

References

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. labels Sep 27, 2018
@bflad
Copy link
Contributor Author

bflad commented Sep 27, 2018

Pull request submitted: #6010

@bflad bflad added this to the v1.39.0 milestone Oct 3, 2018
@bflad
Copy link
Contributor Author

bflad commented Oct 3, 2018

Support for this has been merged and will release with version 1.39.0 of the AWS provider, likely later today.

@ghost
Copy link

ghost commented Oct 3, 2018

This has been released in version 1.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "aws" {
	version = "~> 1.39.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant