Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_launch_template network interfaces default settings #6080

Closed
jasonrojas opened this issue Oct 5, 2018 · 2 comments · Fixed by #8612
Closed

aws_launch_template network interfaces default settings #6080

jasonrojas opened this issue Oct 5, 2018 · 2 comments · Fixed by #8612
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@jasonrojas
Copy link

aws_launch_template network_network interfaces should set "delete_on_termination" to true as a default setting.

Per a support case I opened with aws, if this key is not set to true then autoscaling policies will orphan network interfaces without re-using them and essentially cause your account to hit a network interface limit over time.

Currently the key defaults to false which causes this behavior.

From aws support:

With an AutoScaling Launch Configuration this option is not configurable and is set to "True" by default. However, when using an EC2 Launch Template (the replacement mechanism for AutoScaling Launch Configurations), this option is exposed and configurable.

Can you please check your EC2 Launch Templates and ensure that the setting "Delete on termination" for ENIs is set to "Yes" or set the entire Networks Interfaces section to "Don't include on launch template" or delete the row entirely.?

If you have "upgraded" your Launch Configuration to a Launch Template, the default setting for ENIs is either "NOT_SET" or the entire row for the Network Interfaces section is not defined. In either case, the default behavior is to "Delete on Termination = True". To edit existing Launch Templates, click on the 'Create launch template' button and select "Create a new template version" and select the existing Launch Template for 'Launch template name' as well as the 'Source template'. Ensure to set a version description such as "ENI Delete on Termination set" or the like. Then in the Network Interfaces section, either delete the existing setting or change the 'Delete on Termination' setting to "Yes". Then finish by creating the launch template.

It sounds like there is a difference between what the terraform provider's defaults are and what the aws defaults are.

@bflad bflad added the service/ec2 Issues and PRs that pertain to the ec2 service. label Nov 13, 2018
@aeschright aeschright added the needs-triage Waiting for first response or review from a maintainer. label Jun 24, 2019
@aeschright aeschright added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 8, 2019
@bflad bflad linked a pull request Jul 2, 2020 that will close this issue
@bflad bflad added this to the v3.0.0 milestone Jul 2, 2020
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
3 participants