Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_appsync_graphql_api.authentication_type=OPENID_CONNECT is omitted #6134

Closed
deptno opened this issue Oct 12, 2018 · 4 comments · Fixed by #6138
Closed

aws_appsync_graphql_api.authentication_type=OPENID_CONNECT is omitted #6134

deptno opened this issue Oct 12, 2018 · 4 comments · Fixed by #6138
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appsync Issues and PRs that pertain to the appsync service.
Milestone

Comments

@deptno
Copy link

deptno commented Oct 12, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

appsync authentication_type 'OPENID_CONNECT' is omitted

https://github.com/aws/aws-sdk-go/blob/2742e2e94dd2980c04c4fbe6c342f647f8e6d376/service/appsync/api.go#L5854

It is defined in aws-sdk-go, but can't not use.

I think here is related code

https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/resource_aws_appsync_graphql_api.go#L30-L32

but I'm not go developer 😭

Terraform Version

Terraform v0.11.8
+ provider.aws v1.39.0

Affected Resource(s)

  • aws_appsync

Terraform Configuration Files

resource "aws_appsync_graphql_api" "dev_readish_oidc" {
  authentication_type = "OPENID_CONNECT"
  name = "some name"
}

Expected Behavior

Run

Actual Behavior

Error: aws_appsync_graphql_api.xxx: expected authentication_type to be one of [API_KEY AWS_IAM AMAZON_COGNITO_USER_POOLS], got OPENID_CONNECT
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/appsync Issues and PRs that pertain to the appsync service. labels Oct 12, 2018
@bflad
Copy link
Contributor

bflad commented Oct 12, 2018

Pull request submitted to support OPENID_CONNECT authentication and its required configuration options: #6138

@bflad bflad added this to the v1.41.0 milestone Oct 18, 2018
@bflad
Copy link
Contributor

bflad commented Oct 18, 2018

The above feature has been merged and will release with version 1.41.0 of the AWS provider, likely later today. 👍

@bflad
Copy link
Contributor

bflad commented Oct 18, 2018

This has been released in version 1.41.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appsync Issues and PRs that pertain to the appsync service.
Projects
None yet
2 participants