Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route53 Health check error #6346

Closed
ghost opened this issue Nov 3, 2018 · 5 comments · Fixed by #6460
Closed

Route53 Health check error #6346

ghost opened this issue Nov 3, 2018 · 5 comments · Fixed by #6460
Labels
service/route53 Issues and PRs that pertain to the route53 service.

Comments

@ghost
Copy link

ghost commented Nov 3, 2018

This issue was originally opened by @willettmeister as hashicorp/terraform#19272. It was migrated here as a result of the provider split. The original body of the issue is below.


Terraform Version


Terraform version output:

Terraform v0.11.8

provider.aws v1.41.0
provider.template v1.0.0

Terraform Configuration Files

resource "aws_route53_health_check" "xxxx_hc" {
  fqdn               = "${aws_cloudfront_distribution.s3_distribution.domain_name}"
  port               = 443
  type               = "HTTPS"
  resource_path      = "/clients/xxxx/xxxx.json"
  failure_threshold  = "1"
  request_interval   = "30"
  search_string      = "true"
  invert_healthcheck = true

  tags = {
    Name            = "xxxx-HC"
    ASV             = "${var.asv}"
    CMDBEnvironment = "${var.cmdb_environment}"
    OwnerContact    = "${var.owner_contact}"
  }
}

Expected Behavior

Terraform creates a health check in AWS with a search string specified.

Actual Behavior

terraform errors out saying that a search string can not be created for HTTPS health checks.

Steps to Reproduce

Additional Context

@tomelliff
Copy link
Contributor

I think you want the type to be HTTPS_STR_MATCH instead of HTTPS if you are going to use a string_match. The aws_route53_health_check resource docs briefly cover the options but the docs could probably do with some further explanation at the string_match attribute and maybe even a HTTPS_STR_MATCH type example.

@willettmeister
Copy link

Great I didn't even see that in the documentation on the terraform site. It's definitely easy to jump over.

@bflad bflad added the service/route53 Issues and PRs that pertain to the route53 service. label Nov 14, 2018
@bflad
Copy link
Contributor

bflad commented Nov 14, 2018

I've submitted #6460 which includes some (hopefully helpful) documentation updates. 👍

@bflad
Copy link
Contributor

bflad commented Nov 14, 2018

The documentation update has been merged and will go out with version 1.44.0 of the AWS provider release later today. 😄

@ghost
Copy link
Author

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/route53 Issues and PRs that pertain to the route53 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants