Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing period should be omitted from domain name #6389

Closed
Geartrixy opened this issue Nov 7, 2018 · 9 comments · Fixed by #14220
Closed

Trailing period should be omitted from domain name #6389

Geartrixy opened this issue Nov 7, 2018 · 9 comments · Fixed by #14220
Assignees
Labels
bug Addresses a defect in current functionality. service/apigateway Issues and PRs that pertain to the apigateway service.
Milestone

Comments

@Geartrixy
Copy link

Error: Error applying plan:

1 error(s) occurred:

* aws_api_gateway_domain_name.iot_api_gateway_domain_name: 1 error(s) occurred:

* aws_api_gateway_domain_name.iot_api_gateway_domain_name: Error creating API Gateway Domain Name: BadRequestException: Trailing period should be omitted from domain
name

Terraform and provider versions:

Terraform v0.11.8
+ provider.aws v1.42.0
+ provider.random v2.0.0
+ provider.template v1.0.0
@Geartrixy
Copy link
Author

After some experimenting with different provider versions, I'm thinking aws made a change in their api, where by a dot is now returned when you call the name attribute of a route 53 dns entry.

@eperdeme
Copy link

eperdeme commented Nov 8, 2018

We've been plagued with problems due to this additional period. Does it come from the latest provider from TF when using r53 resources ?

@bflad
Copy link
Contributor

bflad commented Nov 8, 2018

I'm not aware of any recent changes to the aws_route53_record resource. Last one noted in the CHANGELOG is from version 1.29.0 in July: https://github.com/terraform-providers/terraform-provider-aws/blob/master/CHANGELOG.md#1290-july-26-2018

resource/aws_route53_record: Prevent DomainLabelEmpty errors when expanding record names with trailing period (#5312)

@bflad bflad added the service/apigateway Issues and PRs that pertain to the apigateway service. label Nov 8, 2018
@Geartrixy
Copy link
Author

Geartrixy commented Nov 16, 2018

I asked AWS if they had changed anything with the API:

"Good day Graham,

I have received feedback that no known changes were made to the API, however if you can provide a time when you experienced a discrepancy then the service team can look deeper into the period in question.

I will be looking forward to your feedback.

Best regards,

Kevin D.
Amazon Web Services

Check out the AWS Support Knowledge Center, a knowledge base of articles and videos that answer customer questions about AWS services: https://aws.amazon.com/premiumsupport/knowledge-center/?icmpid=support_email_category

"

@markokr
Copy link

markokr commented Dec 20, 2018

The dot appears in 1.42 during "refresh", without doing the vpc_id -> vpc { vpc_id } change

It appears in aws_route53_zone.name and spreads from there.

The dot does not apper when doing "refresh" with 1.41. Although when downgrading from 42->41
the dot will stay.

Looks like terraform-provider-aws problem.

(Using terrafrom 0.11.11)

@markokr
Copy link

markokr commented Dec 20, 2018

Note: this is without apigateway, just plain aws_route53_zone for internal use in VPC.

@nicwise
Copy link
Contributor

nicwise commented Dec 20, 2018

#6535 has a similar fix for certificates, but I guess it needs to be applied quite widely. I had to work around it with the reg-ex in that issue.

@aeschright aeschright added the needs-triage Waiting for first response or review from a maintainer. label Jun 24, 2019
@ryndaniels ryndaniels added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 5, 2019
@bflad bflad added this to the v3.0.0 milestone Jul 7, 2020
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/apigateway Issues and PRs that pertain to the apigateway service.
Projects
None yet
8 participants