Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_security_group_rule: Additional Multi-Rule Acceptance Test Coverage #6422

Closed
bflad opened this issue Nov 10, 2018 · 2 comments
Closed
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. stale Old or inactive issues managed by automation, if no further action taken these will get closed. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Comments

@bflad
Copy link
Contributor

bflad commented Nov 10, 2018

Details

The aws_security_group_rule rule matching logic is heavily affected by other security group rules present in the same group since there is no stable identifier for individual rules. Crashes like #6416 highlight the need for additional testing coverage. While the fix for these specific scenarios mentioned below should be covered by #6419, the testing should be in place to prevent future regressions.

For reference, this testing should look like TestAccAWSSecurityGroupRule_MultipleRuleSearching_AllProtocolCrash and cover the following scenarios with multiple rules:

  • ✅ Test rule containing FromPort/ToPort while other rule is missing FromPort/ToPort (protocol ALL/-1)
  • Test rule containing PrefixListIds while other rule is missing PrefixListIds
  • Test rule containing IpRanges while other rule is missing IpRanges
  • Test rule containing Ipv6Ranges while other rule is missing Ipv6Ranges
  • Test rule containing UserIdGroupPairs while other rule is missing UserIdGroupPairs
@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Nov 10, 2018
@github-actions
Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Oct 30, 2020
@ghost
Copy link

ghost commented Dec 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. stale Old or inactive issues managed by automation, if no further action taken these will get closed. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

No branches or pull requests

1 participant