resource/aws_security_group_rule: Additional Multi-Rule Acceptance Test Coverage #6422
Labels
service/ec2
Issues and PRs that pertain to the ec2 service.
stale
Old or inactive issues managed by automation, if no further action taken these will get closed.
technical-debt
Addresses areas of the codebase that need refactoring or redesign.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Details
The
aws_security_group_rule
rule matching logic is heavily affected by other security group rules present in the same group since there is no stable identifier for individual rules. Crashes like #6416 highlight the need for additional testing coverage. While the fix for these specific scenarios mentioned below should be covered by #6419, the testing should be in place to prevent future regressions.For reference, this testing should look like
TestAccAWSSecurityGroupRule_MultipleRuleSearching_AllProtocolCrash
and cover the following scenarios with multiple rules:PrefixListIds
while other rule is missingPrefixListIds
IpRanges
while other rule is missingIpRanges
Ipv6Ranges
while other rule is missingIpv6Ranges
UserIdGroupPairs
while other rule is missingUserIdGroupPairs
The text was updated successfully, but these errors were encountered: