Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import functionality to iam_group_policy_attachment and iam_user_policy_attachment #6602

Closed
rwolfson opened this issue Nov 27, 2018 · 5 comments · Fixed by #6487 or #6625
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service.
Milestone

Comments

@rwolfson
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

It would be useful if resources aws_iam_group_policy_attachment and aws_iam_user_policy_attachment had imports implemented, similar to what aws_iam_role_policy_attachment currently has. A similar parsing mechanic could be used and I would imagine the logic is about the same. Having this implemented would help facilitate bringing Terraform into live environments where these attachment styles are preferred.

New or Affected Resource(s)

  • aws_iam_group_policy_attachment
  • aws_iam_user_policy_attachment

Potential Terraform Configuration

resource "aws_iam_group_policy_attachment" "test-attach" {
  group      = "${aws_iam_group.group.name}"
  policy_arn = "${aws_iam_policy.policy.arn}"
}

References

@bflad bflad added service/iam Issues and PRs that pertain to the iam service. enhancement Requests to existing resources that expand the functionality or scope. labels Nov 27, 2018
@rwolfson
Copy link
Contributor Author

That looks great! That looks like it touches aws_iam_user_policy_attachment, it also possible to address aws_iam_group_policy_attachment? I believe it should be nearly the same change. I can also take a shot at it, but I don't believe I have the environment set up to test to make sure the change works and the tests pass.

@rwolfson
Copy link
Contributor Author

Thank you!

@bflad bflad added this to the v1.51.0 milestone Dec 2, 2018
@bflad
Copy link
Contributor

bflad commented Dec 2, 2018

Support for importing aws_iam_group_policy_attachment and aws_iam_user_policy_attachment resources has been merged and will release with version 1.51.0 of the AWS provider, likely middle of this week. 👍

@bflad
Copy link
Contributor

bflad commented Dec 5, 2018

This has been released in version 1.51.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service.
Projects
None yet
2 participants