[regression] providers/aws: Setting MaxFrameRate on ElasticTranscoderPreset breaks fixed frame rate

[hashibot]

This issue was originally opened by @svanzoest as hashicorp/terraform#13638. It was migrated here as part of the provider split. The original body of the issue is below.

---

@catsby hashicorp/terraform#13422 broke hashicorp/terraform#9847 and undid hashicorp/terraform#11340, I can no longer set a preset with a fixed frame rate in 0.9.3, this was the reason the default was removed in the first place.

I now get:

* aws_elastictranscoder_preset.proxy: Error creating Elastic Transcoder Preset: ValidationException: When you specify a value for MaxFrameRate, you must also specify 'FrameRate':'Auto'. Either change the value of FrameRate or remove the MaxFrameRate object, and resubmit the request.
    status code: 400, request id: 8cf3908f-207e-11e7-84a3-01d702018b22

[polython]

Also encountered this when declaring a fixed frame rate and no max frame rate:

* aws_elastictranscoder_preset.olympics: Error creating Elastic Transcoder Preset: ValidationException: When you specify a value for MaxFrameRate, you must also specify 'FrameRate':'Auto'. Either change the value of FrameRate or remove the MaxFrameRate object, and resubmit the request. status code: 400, request id: 5570e180-5d05-11e7-8604-01f6ba4419fa

[svanzoest]

Re-adding my reply to @catsby from hashicorp/terraform#13638 for background, as that got lost in the transfer of the repo.

Hopefully I understand your situation correct; you're setting frame_rate to something that is not auto, and you are omitting max_frame_rate, correct?

Correct. Just for reference I am setting the FrameRate to29.97 forcing a consistent FrameRate among all transcodings done using this preset regardless of the FrameRate of the input. Since the FrameRate is not auto, you should not set MaxFrameRate at all. The default of 30 only applies when you set the FrameRate to auto, but do not specify a MaxFrameRate.

So, MaxFrameRate only applies when you assume the frame rate from the media file, but want to make sure you do not have a high frame rate.

Exactly.

Terraform clearly isn't handling reading the default MaxFrameRate correctly, thus our test TestAccAWSElasticTranscoderPreset_basic was failing. I suppose I'm confused on when to set max_frame_rate, it seems you can only set this property if frame_rate is auto? I didn't feel that the AWS docs said that explicitly, but I feel like that' what we're getting.

Yes, that is it and if you read the docs carefully, it states that as well.

FrameRate: If you want to preserve the frame rate of the input file and use it for the output file, specify auto.
MaxFrameRate: If you specify auto for FrameRate, Elastic Transcoder uses the frame rate of the input video for the frame rate of the output video, up to the maximum frame rate. If you do not specify a MaxFrameRate, Elastic Transcoder will use a default of 30.

MaxFrameRate only applies to auto FrameRate.

[github-actions]

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!