Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech Debt: Consistently Handle ISO-8601 Attributes #7045

Closed
bflad opened this issue Jan 7, 2019 · 4 comments
Closed

Tech Debt: Consistently Handle ISO-8601 Attributes #7045

bflad opened this issue Jan 7, 2019 · 4 comments
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/pinpoint Issues and PRs that pertain to the pinpoint service. service/ssm Issues and PRs that pertain to the ssm service. stale Old or inactive issues managed by automation, if no further action taken these will get closed. technical-debt Addresses areas of the codebase that need refactoring or redesign.

Comments

@bflad
Copy link
Contributor

bflad commented Jan 7, 2019

Description

We have a few places that require ISO-8601 timestamp handling instead of Terraform's preferred RFC3339 timestamp handling:

  • aws_autoscaling_schedule resource end_time and start_time attributes
  • aws_pinpoint_app resource quiet_time configuration block end and start attributes
  • aws_ssm_maintenance_window resource end_date and start_date attributes
  • Potentially others that are not documented with "8601" in the resource documentation

Currently plan-time validation is inconsistently applied or unapplied to these attributes. We should come up with a consistent plan for handling date formats outside of RFC3339 and implement it for these attributes. Various options include:

  • Continuing to accept them passthrough in ISO-8601 format with plan-time validation implemented in the Terraform AWS provider codebase
  • Continuing to accept them passthrough in ISO-8601 format with plan-time validation implemented in the Terraform provider SDK codebase
  • Converting them (breaking change) to RFC3339 with plan-time validation implemented with the upstream Terraform provider SDK RFC3339 timestamp validation
@bflad bflad added service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ssm Issues and PRs that pertain to the ssm service. technical-debt Addresses areas of the codebase that need refactoring or redesign. provider Pertains to the provider itself, rather than any interaction with AWS. service/pinpoint Issues and PRs that pertain to the pinpoint service. labels Jan 7, 2019
@firasnajjar
Copy link

Maybe something like this can be used as a workaround for now:

"${replace(timeadd(timestamp(), "10h"), "/(:\\d{2}Z)/", "Z")}"

@relnetops
Copy link

relnetops commented Jan 23, 2020

What is the status of this issue? I'm still getting this error as of today:

Error: "2020-23-01T00:30:00-0600" cannot be parsed as iso8601 Timestamp Format

@github-actions
Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Jan 13, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/pinpoint Issues and PRs that pertain to the pinpoint service. service/ssm Issues and PRs that pertain to the ssm service. stale Old or inactive issues managed by automation, if no further action taken these will get closed. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

No branches or pull requests

3 participants