Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support resource tags for aws_resourcegroups_group resource #7109

Closed
bflad opened this issue Jan 10, 2019 · 3 comments · Fixed by #10640
Closed

Support resource tags for aws_resourcegroups_group resource #7109

bflad opened this issue Jan 10, 2019 · 3 comments · Fixed by #10640
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/resourcegroups Issues and PRs that pertain to the resourcegroups service.
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Jan 10, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

We recently merged in the initial aws_resourcegroups_group resource for managing the group, but it is currently missing resource tag support. It can be implemented similar to other AWS service resources that support tags via the Tag, UnTag, and GetTags API calls. Please note: this feature request is for tagging the group itself, not to support tagging other resources via the group.

New or Affected Resource(s)

  • aws_resourcegroups_group

Potential Terraform Configuration

resource "aws_resourcegroups_group" "example" {
  # ... other configuration ...
  tags = {
    Key1 = "Value1"
  }
}

References

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/resourcegroups Issues and PRs that pertain to the resourcegroups service. labels Jan 10, 2019
@bflad bflad added this to the v2.39.0 milestone Nov 19, 2019
@bflad
Copy link
Contributor Author

bflad commented Nov 19, 2019

Support for resource tagging of the aws_resourcegroups_group resource itself has been merged and will release with version 2.39.0 of the Terraform AWS Provider by Thursday. Thanks to @joestump, @vnguyen7, and @DrFaust92 for their implementation efforts. 👍

@ghost
Copy link

ghost commented Nov 21, 2019

This has been released in version 2.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/resourcegroups Issues and PRs that pertain to the resourcegroups service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant