Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_vpc_peering_connection_accepter: vpc_id and peer_vpc_id not set correctly for same-account peerings #7703

Closed
ewbankkit opened this issue Feb 24, 2019 · 4 comments
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.

Comments

@ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Discovered while testing #7627.
For same-account VPC peering connections the aws_vpc_peering_connection_accepter resource is not correctly setting the vpc_id and peer_vpc_id attributes.

@bflad bflad added the service/ec2 Issues and PRs that pertain to the ec2 service. label Apr 10, 2019
@aeschright aeschright added the needs-triage Waiting for first response or review from a maintainer. label Jun 24, 2019
@aeschright
Copy link
Contributor

Hi @ewbankkit! Thanks for noting this. Can you attach a config that demonstrates the problem, so someone could work on it?

@aeschright aeschright added bug Addresses a defect in current functionality. waiting-response Maintainers are waiting on response from community or contributor. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 22, 2019
@ewbankkit
Copy link
Contributor Author

@aeschright We can use the testAccAwsVPCPeeringConnectionAccepterConfigSameRegionSameAccount configuration from aws/resource_aws_vpc_peering_connection_accepter_test.go:

resource "aws_vpc" "main" {
  cidr_block = "10.0.0.0/16"
  tags = {
    Name = "test"
  }
}

resource "aws_vpc" "peer" {
  cidr_block = "10.1.0.0/16"
  tags = {
    Name = "test"
  }
}

// Requester's side of the connection.
resource "aws_vpc_peering_connection" "main" {
  vpc_id      = "${aws_vpc.main.id}"
  peer_vpc_id = "${aws_vpc.peer.id}"
  auto_accept = false
  tags = {
    Name = "test"
  }
}

// Accepter's side of the connection.
resource "aws_vpc_peering_connection_accepter" "peer" {
  vpc_peering_connection_id = "${aws_vpc_peering_connection.main.id}"
  auto_accept               = true
  tags = {
    Name = "test"
  }
}

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Nov 23, 2019
@github-actions
Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Nov 12, 2021
@github-actions github-actions bot closed this as completed Jan 1, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.
Projects
None yet
Development

No branches or pull requests

3 participants