Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout support for aws_ebs_volume #8349

Closed
dawidmalina opened this issue Apr 17, 2019 · 2 comments · Fixed by #24745
Closed

Add timeout support for aws_ebs_volume #8349

dawidmalina opened this issue Apr 17, 2019 · 2 comments · Fixed by #24745
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.

Comments

@dawidmalina
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The problem comes when I am trying to detach volume (volume is attach during cloud-init phase) on node which are not yet fully stopped and volume is still in use. Usually 5 minute timeout is enough but there are some cases where I would need few minutes more to finish terraform destroy successfully.

Proposal

Increase default timeout for the AWS provider or provide timeout configuration.

New or Affected Resource(s)

  • aws_ebs_snapshot
  • Terraform v0.11.13

Potential Terraform Configuration

resource "aws_ebs_volume" "etcd_data" {
  size     = 10
  timeouts {
    create = "10m"
    delete = "10m"
  }
}

References

@dawidmalina dawidmalina added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 17, 2019
@nywilken nywilken added the service/ec2 Issues and PRs that pertain to the ec2 service. label Apr 18, 2019
@bflad bflad modified the milestone: v2.19.0 Jul 9, 2019
@chewvader
Copy link

I've run into a similar issue but on volume creation. My use case is standing up a larger volume (few hundred GB) with type io2 built from an encrypted snapshot. I was routinely hitting the 5m timeout. With the above PR, I was able to get passed the timeout issue, but ran into something else that I assume is aws related:

module.main.module.ec2.aws_ebs_volume.test: Still creating... [48m41s elapsed]
module.main.module.ec2.aws_ebs_volume.test: Still creating... [48m51s elapsed]

Error: Error waiting for Volume (vol-xyz) to become available: InvalidVolume.NotFound: The volume 'vol-xyz' does not exist.
	status code: 400, request id: xyz

Since ^ appears to be unrelated to this issue, I'll create a new issue for it if I can't find a workaround.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
4 participants