Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support import on aws_backup_vault resource #8821

Closed
martcollins opened this issue May 31, 2019 · 5 comments · Fixed by #9041
Closed

Support import on aws_backup_vault resource #8821

martcollins opened this issue May 31, 2019 · 5 comments · Fixed by #9041
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/backup Issues and PRs that pertain to the backup service.
Milestone

Comments

@martcollins
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The aws_backup_vault resource doesn't yet allow import. This would be useful for users with existing backup vaults. Issue found using version 2.12 of the provider.

$ terraform import aws_backup_vault.test-vault test-vault
aws_backup_vault.test-vault: Importing from ID "test-vault"...

Error: aws_backup_vault.test-vault (import id: test-vault): import aws_backup_vault.test-vault (id: test-vault): resource aws_backup_vault doesn't support import

New or Affected Resource(s)

  • aws_backup_vault

Potential Terraform Configuration

resource "aws_backup_vault" "test-vault" {
  name = "TestVault"
}
@martcollins martcollins added the enhancement Requests to existing resources that expand the functionality or scope. label May 31, 2019
@bflad bflad added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/backup Issues and PRs that pertain to the backup service. labels Jun 10, 2019
@programmer04
Copy link
Contributor

My PR #9041 adds it, but there is a bug in AWS API for non-existent backup_vault, returns the misleading error code (403 instead of 404). Bug's been reported to AWS here and should be fixed, but it is independent of merging this PR.

@bflad bflad added this to the v2.16.0 milestone Jun 19, 2019
@bflad
Copy link
Contributor

bflad commented Jun 19, 2019

Support for importing aws_backup_vault resources has been merged and will be released in version 2.16.0 of the Terraform AWS Provider, likely tomorrow. 👍 Thanks, @programmer04!

@martcollins
Copy link
Author

Thanks @programmer04, awesome!

@bflad
Copy link
Contributor

bflad commented Jun 20, 2019

This has been released in version 2.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/backup Issues and PRs that pertain to the backup service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants