Add Lex bot data source and resoruce

[jzbruno]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #905 and split from PR #2616

Release note for CHANGELOG:

FEATURES:
* **New Data Source:** `aws_lex_bot`
* **New Resource:** `aws_lex_bot`

Output from acceptance testing:

The acceptance tests for this resource depend on PR #8917 being merged. I will enable tests and update once that happens.

$ make testacc TESTARGS='-run=TestAccDataSourceAwsLexBot'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccDataSourceAwsLexBot -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccDataSourceAwsLexBot
--- SKIP: TestAccDataSourceAwsLexBot (0.00s)
    data_source_aws_lex_bot_test.go:12: The Lex intent PR https://github.com/terraform-providers/terraform-provider-aws/pull/8917 must be merged for this test to pass.
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	0.041s

$ make testacc TESTARGS='-run=TestAccAwsLexBot'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAwsLexBot -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAwsLexBot
--- SKIP: TestAccAwsLexBot (0.00s)
    resource_aws_lex_bot_test.go:15: The Lex intent PR https://github.com/terraform-providers/terraform-provider-aws/pull/8917 must be merged for this test to pass.
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	0.044s

[nywilken]

@jzbruno, and folks following along, my apologies for the longer than normal delays on pushing forward this feature. I haven't had the chance to devote the needed time get the other pull-requests into a mergable state 😳 I appreciate your patience as we continue to work through this resource.

While I can't say that it will get into the next upcoming release(s), I can say that the resource is still a priority for us.

To not give false expectations around the release of this resource I am going to remove the milestone. But let's coordinate on when would be ideal to continue pushing forward. If you find that your availability has also slowed please let me know if we should consider having another community member or the maintainers take over the pull-request(s).

Cheers

[jzbruno]

@nywilken I will look at this tonight.

[jzbruno]

@nywilken Asked a couple questions but otherwise this one is ready for review.

[nbmustafa]

any update on the progress of reviewing this PR?

[jzbruno]

@nashvan We were able to get slot type reviewed and merged. The remaining PRs will need to be updated with the same changes and merged one by one. As I have time this week I will try to get them ready for review.

[gdavison]

I've added a number of suggestions

[jzbruno]

@gdavison Just a heads up. I have pushed initial changes for this PR. I still need to expand on the resource tests. I rebased this on top of the Intent PR so we will want to get that merged first. This is the only reasonable way to test the bot resource.

[jzbruno]

@gdavison Ok. Tests have been committed. I have a question though, there is an internal AWS API timeout I cannot set, which causes timeouts when running all the tests in parallel. Any ideas?

Error: error creating bot test_bot_idyrjilt: timeout while waiting for state to become 'success' (timeout: 1m0s)

[gdavison]

LGTM 🚀

--- PASS: TestAccDataSourceAwsLexBot_basic (166.41s)
--- PASS: TestAccAwsLexBot_disappears (181.14s)
--- PASS: TestAccAwsLexBot_basic (201.66s)
--- PASS: TestAccAwsLexBot_abortStatement (300.91s)
--- PASS: TestAccAwsLexBot_locale (302.35s)
--- PASS: TestAccAwsLexBot_voiceId (308.37s)
--- PASS: TestAccAwsLexBot_intents (310.30s)
--- PASS: TestAccAwsLexBot_enableModelImprovements (312.01s)
--- PASS: TestAccAwsLexBot_clarificationPrompt (313.13s)
--- PASS: TestAccAwsLexBot_idleSessionTtlInSeconds (315.98s)
--- PASS: TestAccAwsLexBot_detectSentiment (317.44s)
--- PASS: TestAccAwsLexBot_childDirected (319.52s)
--- PASS: TestAccAwsLexBot_description (328.22s)
--- PASS: TestAccDataSourceAwsLexBot_withVersion (45.35s)
--- PASS: TestAccAwsLexBot_createVersion (69.65s)

[ghost]

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!