Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: Test defaults for full Cloudwatch Event Target config #9857

Closed
aeschright opened this issue Aug 23, 2019 · 2 comments
Closed

Tech debt: Test defaults for full Cloudwatch Event Target config #9857

aeschright opened this issue Aug 23, 2019 · 2 comments
Labels
stale Old or inactive issues managed by automation, if no further action taken these will get closed. technical-debt Addresses areas of the codebase that need refactoring or redesign.

Comments

@aeschright
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

AWS provider 2.25.0

Affected Resource(s)

  • cloudwatch_event_target

Details

Following on #9773 it makes sense to rework the cloudwatch_event_target ECS tests to verify all defaults are set. There should be a base test that uses the defaults, and additional tests for config validation.

Important Factoids

References

@aeschright aeschright added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Aug 23, 2019
@aeschright aeschright self-assigned this Aug 23, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 23, 2019
@aeschright aeschright removed the needs-triage Waiting for first response or review from a maintainer. label Sep 12, 2019
@github-actions
Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Jan 24, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale Old or inactive issues managed by automation, if no further action taken these will get closed. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

No branches or pull requests

1 participant