Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AppMesh Route data source #26695

Merged
merged 26 commits into from
Mar 23, 2023
Merged

Add AppMesh Route data source #26695

merged 26 commits into from
Mar 23, 2023

Conversation

stefangrosaru
Copy link
Contributor

@stefangrosaru stefangrosaru commented Sep 7, 2022 •
edited by ewbankkit
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS='TestAccAppMeshRouteDataSource_' PKG=appmesh
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run='TestAccAppMeshRouteDataSource_'  -timeout 180m
=== RUN   TestAccAppMeshRouteDataSource_http2Route
=== PAUSE TestAccAppMeshRouteDataSource_http2Route
=== RUN   TestAccAppMeshRouteDataSource_httpRoute
=== PAUSE TestAccAppMeshRouteDataSource_httpRoute
=== RUN   TestAccAppMeshRouteDataSource_grpcRoute
=== PAUSE TestAccAppMeshRouteDataSource_grpcRoute
=== RUN   TestAccAppMeshRouteDataSource_tcpRoute
=== PAUSE TestAccAppMeshRouteDataSource_tcpRoute
=== CONT  TestAccAppMeshRouteDataSource_http2Route
=== CONT  TestAccAppMeshRouteDataSource_grpcRoute
=== CONT  TestAccAppMeshRouteDataSource_tcpRoute
=== CONT  TestAccAppMeshRouteDataSource_httpRoute
--- PASS: TestAccAppMeshRouteDataSource_http2Route (26.96s)
--- PASS: TestAccAppMeshRouteDataSource_httpRoute (28.12s)
--- PASS: TestAccAppMeshRouteDataSource_grpcRoute (28.28s)
--- PASS: TestAccAppMeshRouteDataSource_tcpRoute (28.51s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appmesh    30.923s

Closes #26911.
Closes #21202.
Relates #17590.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. service/appmesh Issues and PRs that pertain to the appmesh service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 7, 2022
github-actions[bot]
github-actions bot reviewed Sep 7, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @stefangrosaru 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Sep 7, 2022
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 13, 2022
@stefangrosaru stefangrosaru mentioned this pull request Sep 22, 2022
Closed
@shogohida shogohida mentioned this pull request Oct 30, 2022
Merged
ewbankkit added 15 commits March 22, 2023 08:45
@ewbankkit
Merge branch 'main' into HEAD
1579422
@ewbankkit
r/aws_appmesh_mesh: Alphabetize attributes.
3b6cd8b
@ewbankkit
r/aws_appmesh_mesh: Tidy up resource Create, Update and Delete.
dff4209
@ewbankkit
r/aws_appmesh_mesh: Tidy up resource Read.
3b0fc67
@ewbankkit
r/aws_appmesh_mesh: Tidy up acceptance tests.
c7b6ebc 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccAppMesh_serial/^Mesh$$' PKG=appmesh
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20  -run=TestAccAppMesh_serial/^Mesh$ -timeout 180m
=== RUN   TestAccAppMesh_serial
=== PAUSE TestAccAppMesh_serial
=== CONT  TestAccAppMesh_serial
=== RUN   TestAccAppMesh_serial/Mesh
=== RUN   TestAccAppMesh_serial/Mesh/basic
=== RUN   TestAccAppMesh_serial/Mesh/disappears
=== RUN   TestAccAppMesh_serial/Mesh/egressFilter
=== RUN   TestAccAppMesh_serial/Mesh/tags
=== RUN   TestAccAppMesh_serial/Mesh/dataSourceBasic
=== RUN   TestAccAppMesh_serial/Mesh/dataSourceMeshOwner
=== RUN   TestAccAppMesh_serial/Mesh/dataSourceSpecAndTagsSet
--- PASS: TestAccAppMesh_serial (141.49s)
    --- PASS: TestAccAppMesh_serial/Mesh (141.49s)
        --- PASS: TestAccAppMesh_serial/Mesh/basic (18.02s)
        --- PASS: TestAccAppMesh_serial/Mesh/disappears (11.18s)
        --- PASS: TestAccAppMesh_serial/Mesh/egressFilter (35.47s)
        --- PASS: TestAccAppMesh_serial/Mesh/tags (35.17s)
        --- PASS: TestAccAppMesh_serial/Mesh/dataSourceBasic (13.69s)
        --- PASS: TestAccAppMesh_serial/Mesh/dataSourceMeshOwner (14.72s)
        --- PASS: TestAccAppMesh_serial/Mesh/dataSourceSpecAndTagsSet (13.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appmesh	149.261s
@ewbankkit
d/aws_appmesh_mesh: Tidy up.
b5e25f6 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccAppMesh_serial/^Mesh$$/dataSource' PKG=appmesh
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20  -run=TestAccAppMesh_serial/^Mesh$/dataSource -timeout 180m
=== RUN   TestAccAppMesh_serial
=== PAUSE TestAccAppMesh_serial
=== CONT  TestAccAppMesh_serial
=== RUN   TestAccAppMesh_serial/Mesh
=== RUN   TestAccAppMesh_serial/Mesh/dataSourceSpecAndTagsSet
=== RUN   TestAccAppMesh_serial/Mesh/dataSourceBasic
=== RUN   TestAccAppMesh_serial/Mesh/dataSourceMeshOwner
--- PASS: TestAccAppMesh_serial (42.20s)
    --- PASS: TestAccAppMesh_serial/Mesh (42.20s)
        --- PASS: TestAccAppMesh_serial/Mesh/dataSourceSpecAndTagsSet (15.28s)
        --- PASS: TestAccAppMesh_serial/Mesh/dataSourceBasic (12.89s)
        --- PASS: TestAccAppMesh_serial/Mesh/dataSourceMeshOwner (14.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appmesh	47.909s
@ewbankkit
r/aws_appmesh_virtual_service: Alphabetize attributes.
811ad00
@ewbankkit
r/aws_appmesh_virtual_service: Tidy up resource Create, Update and De…
865b93d 
…lete.
@ewbankkit
r/aws_appmesh_virtual_service: Tidy up resource Read.
0855dc3
@ewbankkit
r/aws_appmesh_virtual_service: Tidy up resource Import.
b4c866e
@ewbankkit
r/aws_appmesh_virtual_service: Tidy up acceptance tests.
e50176f 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccAppMesh_serial/^VirtualService$$' PKG=appmesh
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20  -run=TestAccAppMesh_serial/^VirtualService$ -timeout 180m
=== RUN   TestAccAppMesh_serial
=== PAUSE TestAccAppMesh_serial
=== CONT  TestAccAppMesh_serial
=== RUN   TestAccAppMesh_serial/VirtualService
=== RUN   TestAccAppMesh_serial/VirtualService/tags
=== RUN   TestAccAppMesh_serial/VirtualService/dataSourceVirtualNode
=== RUN   TestAccAppMesh_serial/VirtualService/dataSourceVirtualRouter
=== RUN   TestAccAppMesh_serial/VirtualService/disappears
=== RUN   TestAccAppMesh_serial/VirtualService/virtualNode
=== RUN   TestAccAppMesh_serial/VirtualService/virtualRouter
--- PASS: TestAccAppMesh_serial (140.21s)
    --- PASS: TestAccAppMesh_serial/VirtualService (140.21s)
        --- PASS: TestAccAppMesh_serial/VirtualService/tags (42.80s)
        --- PASS: TestAccAppMesh_serial/VirtualService/dataSourceVirtualNode (15.36s)
        --- PASS: TestAccAppMesh_serial/VirtualService/dataSourceVirtualRouter (15.61s)
        --- PASS: TestAccAppMesh_serial/VirtualService/disappears (13.90s)
        --- PASS: TestAccAppMesh_serial/VirtualService/virtualNode (27.55s)
        --- PASS: TestAccAppMesh_serial/VirtualService/virtualRouter (24.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appmesh	146.586s
@ewbankkit
d/aws_appmesh_virtual_service: Tidy up.
3cd5409 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccAppMesh_serial/^VirtualService$$' PKG=appmesh
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20  -run=TestAccAppMesh_serial/^VirtualService$ -timeout 180m
=== RUN   TestAccAppMesh_serial
=== PAUSE TestAccAppMesh_serial
=== CONT  TestAccAppMesh_serial
=== RUN   TestAccAppMesh_serial/VirtualService
=== RUN   TestAccAppMesh_serial/VirtualService/disappears
=== RUN   TestAccAppMesh_serial/VirtualService/virtualNode
=== RUN   TestAccAppMesh_serial/VirtualService/virtualRouter
=== RUN   TestAccAppMesh_serial/VirtualService/tags
=== RUN   TestAccAppMesh_serial/VirtualService/dataSourceVirtualNode
=== RUN   TestAccAppMesh_serial/VirtualService/dataSourceVirtualRouter
--- PASS: TestAccAppMesh_serial (147.73s)
    --- PASS: TestAccAppMesh_serial/VirtualService (147.73s)
        --- PASS: TestAccAppMesh_serial/VirtualService/disappears (15.75s)
        --- PASS: TestAccAppMesh_serial/VirtualService/virtualNode (29.07s)
        --- PASS: TestAccAppMesh_serial/VirtualService/virtualRouter (25.88s)
        --- PASS: TestAccAppMesh_serial/VirtualService/tags (42.00s)
        --- PASS: TestAccAppMesh_serial/VirtualService/dataSourceVirtualNode (17.03s)
        --- PASS: TestAccAppMesh_serial/VirtualService/dataSourceVirtualRouter (18.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appmesh	153.175s
@ewbankkit
r/aws_appmesh_route: Alphabetize attributes.
d429db8
@ewbankkit
r/aws_appmesh_route: Tidy up resource Create, Update and Delete.
b563c66
@ewbankkit
r/aws_appmesh_route: Tidy up resource Read.
22537ed
@ewbankkit
r/aws_appmesh_route: Tidy up acceptance tests.
d6e251b 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccAppMesh_serial/^Route$$' PKG=appmesh
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20  -run=TestAccAppMesh_serial/^Route$ -timeout 180m
=== RUN   TestAccAppMesh_serial
=== PAUSE TestAccAppMesh_serial
=== CONT  TestAccAppMesh_serial
=== RUN   TestAccAppMesh_serial/Route
=== RUN   TestAccAppMesh_serial/Route/tcpRouteTimeout
=== RUN   TestAccAppMesh_serial/Route/grpcRoute
=== RUN   TestAccAppMesh_serial/Route/grpcRouteWithPortMatch
=== RUN   TestAccAppMesh_serial/Route/httpHeader
=== RUN   TestAccAppMesh_serial/Route/httpRetryPolicy
=== RUN   TestAccAppMesh_serial/Route/httpRouteTimeout
=== RUN   TestAccAppMesh_serial/Route/tcpRouteWithPortMatch
=== RUN   TestAccAppMesh_serial/Route/disappears
=== RUN   TestAccAppMesh_serial/Route/grpcRouteEmptyMatch
=== RUN   TestAccAppMesh_serial/Route/httpRouteWithPortMatch
=== RUN   TestAccAppMesh_serial/Route/routePriority
=== RUN   TestAccAppMesh_serial/Route/tags
=== RUN   TestAccAppMesh_serial/Route/grpcRouteTimeout
=== RUN   TestAccAppMesh_serial/Route/http2Route
=== RUN   TestAccAppMesh_serial/Route/http2RouteWithPortMatch
=== RUN   TestAccAppMesh_serial/Route/httpRoute
=== RUN   TestAccAppMesh_serial/Route/tcpRoute
=== RUN   TestAccAppMesh_serial/Route/http2RouteTimeout
--- PASS: TestAccAppMesh_serial (577.95s)
    --- PASS: TestAccAppMesh_serial/Route (577.95s)
        --- PASS: TestAccAppMesh_serial/Route/tcpRouteTimeout (28.33s)
        --- PASS: TestAccAppMesh_serial/Route/grpcRoute (49.53s)
        --- PASS: TestAccAppMesh_serial/Route/grpcRouteWithPortMatch (49.50s)
        --- PASS: TestAccAppMesh_serial/Route/httpHeader (27.18s)
        --- PASS: TestAccAppMesh_serial/Route/httpRetryPolicy (38.14s)
        --- PASS: TestAccAppMesh_serial/Route/httpRouteTimeout (27.14s)
        --- PASS: TestAccAppMesh_serial/Route/tcpRouteWithPortMatch (38.03s)
        --- PASS: TestAccAppMesh_serial/Route/disappears (13.48s)
        --- PASS: TestAccAppMesh_serial/Route/grpcRouteEmptyMatch (16.17s)
        --- PASS: TestAccAppMesh_serial/Route/httpRouteWithPortMatch (37.83s)
        --- PASS: TestAccAppMesh_serial/Route/routePriority (27.04s)
        --- PASS: TestAccAppMesh_serial/Route/tags (37.77s)
        --- PASS: TestAccAppMesh_serial/Route/grpcRouteTimeout (27.63s)
        --- PASS: TestAccAppMesh_serial/Route/http2Route (28.18s)
        --- PASS: TestAccAppMesh_serial/Route/http2RouteWithPortMatch (27.32s)
        --- PASS: TestAccAppMesh_serial/Route/httpRoute (38.09s)
        --- PASS: TestAccAppMesh_serial/Route/tcpRoute (38.84s)
        --- PASS: TestAccAppMesh_serial/Route/http2RouteTimeout (27.75s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appmesh	583.190s
@ewbankkit
d/aws_appmesh_mesh: Add and use 'dataSourcePropertyFromResourceProper…
e37ed10 
…ty'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccAppMesh_serial/^Mesh$$' PKG=appmesh
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20  -run=TestAccAppMesh_serial/^Mesh$ -timeout 180m
=== RUN   TestAccAppMesh_serial
=== PAUSE TestAccAppMesh_serial
=== CONT  TestAccAppMesh_serial
=== RUN   TestAccAppMesh_serial/Mesh
=== RUN   TestAccAppMesh_serial/Mesh/tags
=== RUN   TestAccAppMesh_serial/Mesh/dataSourceBasic
=== RUN   TestAccAppMesh_serial/Mesh/dataSourceMeshOwner
=== RUN   TestAccAppMesh_serial/Mesh/dataSourceSpecAndTagsSet
=== RUN   TestAccAppMesh_serial/Mesh/basic
=== RUN   TestAccAppMesh_serial/Mesh/disappears
=== RUN   TestAccAppMesh_serial/Mesh/egressFilter
--- PASS: TestAccAppMesh_serial (137.21s)
    --- PASS: TestAccAppMesh_serial/Mesh (137.21s)
        --- PASS: TestAccAppMesh_serial/Mesh/tags (41.34s)
        --- PASS: TestAccAppMesh_serial/Mesh/dataSourceBasic (13.35s)
        --- PASS: TestAccAppMesh_serial/Mesh/dataSourceMeshOwner (13.61s)
        --- PASS: TestAccAppMesh_serial/Mesh/dataSourceSpecAndTagsSet (13.37s)
        --- PASS: TestAccAppMesh_serial/Mesh/basic (14.27s)
        --- PASS: TestAccAppMesh_serial/Mesh/disappears (10.24s)
        --- PASS: TestAccAppMesh_serial/Mesh/egressFilter (31.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appmesh	142.992s
@ewbankkit
d/aws_appmesh_virtual_service: Use 'dataSourcePropertyFromResourcePro…
dfcf92e 
…perty'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccAppMesh_serial/^VirtualService$$' PKG=appmesh
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20  -run=TestAccAppMesh_serial/^VirtualService$ -timeout 180m
=== RUN   TestAccAppMesh_serial
=== PAUSE TestAccAppMesh_serial
=== CONT  TestAccAppMesh_serial
=== RUN   TestAccAppMesh_serial/VirtualService
=== RUN   TestAccAppMesh_serial/VirtualService/disappears
=== RUN   TestAccAppMesh_serial/VirtualService/virtualNode
=== RUN   TestAccAppMesh_serial/VirtualService/virtualRouter
=== RUN   TestAccAppMesh_serial/VirtualService/tags
=== RUN   TestAccAppMesh_serial/VirtualService/dataSourceVirtualNode
=== RUN   TestAccAppMesh_serial/VirtualService/dataSourceVirtualRouter
--- PASS: TestAccAppMesh_serial (137.73s)
    --- PASS: TestAccAppMesh_serial/VirtualService (137.73s)
        --- PASS: TestAccAppMesh_serial/VirtualService/disappears (14.75s)
        --- PASS: TestAccAppMesh_serial/VirtualService/virtualNode (28.11s)
        --- PASS: TestAccAppMesh_serial/VirtualService/virtualRouter (24.70s)
        --- PASS: TestAccAppMesh_serial/VirtualService/tags (39.02s)
        --- PASS: TestAccAppMesh_serial/VirtualService/dataSourceVirtualNode (15.60s)
        --- PASS: TestAccAppMesh_serial/VirtualService/dataSourceVirtualRouter (15.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appmesh	143.268s
@ewbankkit
d/aws_appmesh_route: Use 'dataSourcePropertyFromResourceProperty'.
7055369 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccAppMesh_serial/^Route$$' PKG=appmesh
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20  -run=TestAccAppMesh_serial/^Route$ -timeout 180m
=== RUN   TestAccAppMesh_serial
=== PAUSE TestAccAppMesh_serial
=== CONT  TestAccAppMesh_serial
=== RUN   TestAccAppMesh_serial/Route
=== RUN   TestAccAppMesh_serial/Route/httpRoute
=== RUN   TestAccAppMesh_serial/Route/httpRouteWithPortMatch
=== RUN   TestAccAppMesh_serial/Route/tags
=== RUN   TestAccAppMesh_serial/Route/dataSourceGRPCRoute
=== RUN   TestAccAppMesh_serial/Route/dataSourceTCPRoute
=== RUN   TestAccAppMesh_serial/Route/grpcRouteTimeout
=== RUN   TestAccAppMesh_serial/Route/httpHeader
=== RUN   TestAccAppMesh_serial/Route/tcpRouteWithPortMatch
=== RUN   TestAccAppMesh_serial/Route/httpRetryPolicy
=== RUN   TestAccAppMesh_serial/Route/httpRouteTimeout
=== RUN   TestAccAppMesh_serial/Route/routePriority
=== RUN   TestAccAppMesh_serial/Route/tcpRoute
=== RUN   TestAccAppMesh_serial/Route/dataSourceHTTP2Route
=== RUN   TestAccAppMesh_serial/Route/grpcRoute
=== RUN   TestAccAppMesh_serial/Route/grpcRouteEmptyMatch
=== RUN   TestAccAppMesh_serial/Route/http2Route
=== RUN   TestAccAppMesh_serial/Route/dataSourceHTTPRoute
=== RUN   TestAccAppMesh_serial/Route/http2RouteTimeout
=== RUN   TestAccAppMesh_serial/Route/tcpRouteTimeout
=== RUN   TestAccAppMesh_serial/Route/disappears
=== RUN   TestAccAppMesh_serial/Route/grpcRouteWithPortMatch
=== RUN   TestAccAppMesh_serial/Route/http2RouteWithPortMatch
--- PASS: TestAccAppMesh_serial (649.12s)
    --- PASS: TestAccAppMesh_serial/Route (649.12s)
        --- PASS: TestAccAppMesh_serial/Route/httpRoute (39.04s)
        --- PASS: TestAccAppMesh_serial/Route/httpRouteWithPortMatch (38.09s)
        --- PASS: TestAccAppMesh_serial/Route/tags (38.12s)
        --- PASS: TestAccAppMesh_serial/Route/dataSourceGRPCRoute (14.93s)
        --- PASS: TestAccAppMesh_serial/Route/dataSourceTCPRoute (14.79s)
        --- PASS: TestAccAppMesh_serial/Route/grpcRouteTimeout (27.14s)
        --- PASS: TestAccAppMesh_serial/Route/httpHeader (27.29s)
        --- PASS: TestAccAppMesh_serial/Route/tcpRouteWithPortMatch (39.36s)
        --- PASS: TestAccAppMesh_serial/Route/httpRetryPolicy (39.26s)
        --- PASS: TestAccAppMesh_serial/Route/httpRouteTimeout (27.52s)
        --- PASS: TestAccAppMesh_serial/Route/routePriority (27.09s)
        --- PASS: TestAccAppMesh_serial/Route/tcpRoute (39.31s)
        --- PASS: TestAccAppMesh_serial/Route/dataSourceHTTP2Route (15.71s)
        --- PASS: TestAccAppMesh_serial/Route/grpcRoute (51.35s)
        --- PASS: TestAccAppMesh_serial/Route/grpcRouteEmptyMatch (16.72s)
        --- PASS: TestAccAppMesh_serial/Route/http2Route (28.70s)
        --- PASS: TestAccAppMesh_serial/Route/dataSourceHTTPRoute (16.06s)
        --- PASS: TestAccAppMesh_serial/Route/http2RouteTimeout (28.80s)
        --- PASS: TestAccAppMesh_serial/Route/tcpRouteTimeout (27.79s)
        --- PASS: TestAccAppMesh_serial/Route/disappears (13.90s)
        --- PASS: TestAccAppMesh_serial/Route/grpcRouteWithPortMatch (50.50s)
        --- PASS: TestAccAppMesh_serial/Route/http2RouteWithPortMatch (27.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appmesh	654.457s
@ewbankkit
d/aws_appmesh_mesh: Don't attempt to list tags if the current AWS acc…
b78a3a4 
…ount is not the mesh owner.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccAppMesh_serial/^Mesh$$/dataSourceShared' PKG=appmesh
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20  -run=TestAccAppMesh_serial/^Mesh$/dataSourceShared -timeout 180m
=== RUN   TestAccAppMesh_serial
=== PAUSE TestAccAppMesh_serial
=== CONT  TestAccAppMesh_serial
=== RUN   TestAccAppMesh_serial/Mesh
=== RUN   TestAccAppMesh_serial/Mesh/dataSourceShared
--- PASS: TestAccAppMesh_serial (28.44s)
    --- PASS: TestAccAppMesh_serial/Mesh (28.44s)
        --- PASS: TestAccAppMesh_serial/Mesh/dataSourceShared (28.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appmesh	35.884s
@ewbankkit
d/aws_appmesh_virtual_service: Don't attempt to list tags if the curr…
a40da1c 
…ent AWS account is not the mesh owner.
@ewbankkit
d/aws_appmesh_route: Don't attempt to list tags if the current AWS ac…
c027741 
…count is not the mesh owner.
@github-actions github-actions bot added generators Relates to code generators. and removed provider Pertains to the provider itself, rather than any interaction with AWS. labels Mar 23, 2023
ewbankkit
ewbankkit approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppMesh_serial' PKG=appmesh 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20  -run=TestAccAppMesh_serial -timeout 180m
=== RUN   TestAccAppMesh_serial
=== PAUSE TestAccAppMesh_serial
=== CONT  TestAccAppMesh_serial
=== RUN   TestAccAppMesh_serial/VirtualGateway
=== RUN   TestAccAppMesh_serial/VirtualGateway/backendDefaultsCertificate
=== RUN   TestAccAppMesh_serial/VirtualGateway/listenerConnectionPool
=== RUN   TestAccAppMesh_serial/VirtualGateway/listenerHealthChecks
=== RUN   TestAccAppMesh_serial/VirtualGateway/listenerTls
=== RUN   TestAccAppMesh_serial/VirtualGateway/listenerValidation
=== RUN   TestAccAppMesh_serial/VirtualGateway/multiListenerValidation
=== RUN   TestAccAppMesh_serial/VirtualGateway/logging
=== RUN   TestAccAppMesh_serial/VirtualGateway/basic
=== RUN   TestAccAppMesh_serial/VirtualGateway/backendDefaults
=== RUN   TestAccAppMesh_serial/VirtualGateway/tags
=== RUN   TestAccAppMesh_serial/VirtualGateway/disappears
=== RUN   TestAccAppMesh_serial/VirtualNode
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerTimeout
=== RUN   TestAccAppMesh_serial/VirtualNode/disappears
=== RUN   TestAccAppMesh_serial/VirtualNode/backendDefaultsCertificate
=== RUN   TestAccAppMesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerValidation
=== RUN   TestAccAppMesh_serial/VirtualNode/basic
=== RUN   TestAccAppMesh_serial/VirtualNode/backendClientPolicyFile
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerConnectionPool
=== RUN   TestAccAppMesh_serial/VirtualNode/tags
=== RUN   TestAccAppMesh_serial/VirtualNode/backendClientPolicyAcm
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerOutlierDetection
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerHealthChecks
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerTls
=== RUN   TestAccAppMesh_serial/VirtualNode/multiListenerValidation
=== RUN   TestAccAppMesh_serial/VirtualNode/logging
=== RUN   TestAccAppMesh_serial/VirtualNode/backendDefaults
=== RUN   TestAccAppMesh_serial/VirtualRouter
=== RUN   TestAccAppMesh_serial/VirtualRouter/disappears
=== RUN   TestAccAppMesh_serial/VirtualRouter/multiListener
=== RUN   TestAccAppMesh_serial/VirtualRouter/tags
=== RUN   TestAccAppMesh_serial/VirtualRouter/basic
=== RUN   TestAccAppMesh_serial/VirtualService
=== RUN   TestAccAppMesh_serial/VirtualService/tags
=== RUN   TestAccAppMesh_serial/VirtualService/dataSourceVirtualNode
=== RUN   TestAccAppMesh_serial/VirtualService/dataSourceVirtualRouter
=== RUN   TestAccAppMesh_serial/VirtualService/disappears
=== RUN   TestAccAppMesh_serial/VirtualService/virtualNode
=== RUN   TestAccAppMesh_serial/VirtualService/virtualRouter
=== RUN   TestAccAppMesh_serial/GatewayRoute
=== RUN   TestAccAppMesh_serial/GatewayRoute/grpcRoute
=== RUN   TestAccAppMesh_serial/GatewayRoute/httpRoute
=== RUN   TestAccAppMesh_serial/GatewayRoute/tags
=== RUN   TestAccAppMesh_serial/GatewayRoute/basic
=== RUN   TestAccAppMesh_serial/GatewayRoute/disappears
=== RUN   TestAccAppMesh_serial/GatewayRoute/grpcRouteWithPort
=== RUN   TestAccAppMesh_serial/GatewayRoute/httpRouteWithPort
=== RUN   TestAccAppMesh_serial/GatewayRoute/http2Route
=== RUN   TestAccAppMesh_serial/GatewayRoute/http2RouteWithPort
=== RUN   TestAccAppMesh_serial/Mesh
=== RUN   TestAccAppMesh_serial/Mesh/disappears
=== RUN   TestAccAppMesh_serial/Mesh/egressFilter
=== RUN   TestAccAppMesh_serial/Mesh/tags
=== RUN   TestAccAppMesh_serial/Mesh/dataSourceBasic
=== RUN   TestAccAppMesh_serial/Mesh/dataSourceMeshOwner
=== RUN   TestAccAppMesh_serial/Mesh/dataSourceSpecAndTagsSet
=== RUN   TestAccAppMesh_serial/Mesh/dataSourceShared
    acctest.go:771: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== RUN   TestAccAppMesh_serial/Mesh/basic
=== RUN   TestAccAppMesh_serial/Route
=== RUN   TestAccAppMesh_serial/Route/httpRoute
=== RUN   TestAccAppMesh_serial/Route/httpRouteTimeout
=== RUN   TestAccAppMesh_serial/Route/tcpRouteWithPortMatch
=== RUN   TestAccAppMesh_serial/Route/dataSourceGRPCRoute
=== RUN   TestAccAppMesh_serial/Route/grpcRouteTimeout
=== RUN   TestAccAppMesh_serial/Route/http2Route
=== RUN   TestAccAppMesh_serial/Route/httpHeader
=== RUN   TestAccAppMesh_serial/Route/httpRetryPolicy
=== RUN   TestAccAppMesh_serial/Route/http2RouteWithPortMatch
=== RUN   TestAccAppMesh_serial/Route/routePriority
=== RUN   TestAccAppMesh_serial/Route/tcpRoute
=== RUN   TestAccAppMesh_serial/Route/dataSourceHTTPRoute
=== RUN   TestAccAppMesh_serial/Route/disappears
=== RUN   TestAccAppMesh_serial/Route/grpcRouteWithPortMatch
=== RUN   TestAccAppMesh_serial/Route/http2RouteTimeout
=== RUN   TestAccAppMesh_serial/Route/dataSourceTCPRoute
=== RUN   TestAccAppMesh_serial/Route/tags
=== RUN   TestAccAppMesh_serial/Route/dataSourceHTTP2Route
=== RUN   TestAccAppMesh_serial/Route/grpcRoute
=== RUN   TestAccAppMesh_serial/Route/grpcRouteEmptyMatch
=== RUN   TestAccAppMesh_serial/Route/httpRouteWithPortMatch
=== RUN   TestAccAppMesh_serial/Route/tcpRouteTimeout
--- PASS: TestAccAppMesh_serial (2244.15s)
    --- PASS: TestAccAppMesh_serial/VirtualGateway (320.63s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/backendDefaultsCertificate (16.33s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/listenerConnectionPool (25.90s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/listenerHealthChecks (25.76s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/listenerTls (74.24s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/listenerValidation (25.73s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/multiListenerValidation (26.02s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/logging (36.35s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/basic (15.36s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/backendDefaults (25.81s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/tags (36.38s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/disappears (12.76s)
    --- PASS: TestAccAppMesh_serial/VirtualNode (585.13s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerTimeout (26.18s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/disappears (12.88s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/backendDefaultsCertificate (15.64s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/cloudMapServiceDiscovery (114.21s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerValidation (26.25s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/basic (15.42s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/backendClientPolicyFile (26.16s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerConnectionPool (27.02s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/tags (38.07s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/backendClientPolicyAcm (60.24s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerOutlierDetection (27.03s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerHealthChecks (26.97s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerTls (76.66s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/multiListenerValidation (27.44s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/logging (38.10s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/backendDefaults (26.86s)
    --- PASS: TestAccAppMesh_serial/VirtualRouter (100.28s)
        --- PASS: TestAccAppMesh_serial/VirtualRouter/disappears (12.72s)
        --- PASS: TestAccAppMesh_serial/VirtualRouter/multiListener (25.72s)
        --- PASS: TestAccAppMesh_serial/VirtualRouter/tags (36.07s)
        --- PASS: TestAccAppMesh_serial/VirtualRouter/basic (25.77s)
    --- PASS: TestAccAppMesh_serial/VirtualService (134.62s)
        --- PASS: TestAccAppMesh_serial/VirtualService/tags (38.18s)
        --- PASS: TestAccAppMesh_serial/VirtualService/dataSourceVirtualNode (15.25s)
        --- PASS: TestAccAppMesh_serial/VirtualService/dataSourceVirtualRouter (15.61s)
        --- PASS: TestAccAppMesh_serial/VirtualService/disappears (13.73s)
        --- PASS: TestAccAppMesh_serial/VirtualService/virtualNode (27.47s)
        --- PASS: TestAccAppMesh_serial/VirtualService/virtualRouter (24.37s)
    --- PASS: TestAccAppMesh_serial/GatewayRoute (318.21s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRoute (26.99s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRoute (49.06s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/tags (38.09s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/basic (16.25s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/disappears (13.63s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRouteWithPort (27.16s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRouteWithPort (49.08s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/http2Route (49.02s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/http2RouteWithPort (48.92s)
    --- PASS: TestAccAppMesh_serial/Mesh (129.69s)
        --- PASS: TestAccAppMesh_serial/Mesh/disappears (10.47s)
        --- PASS: TestAccAppMesh_serial/Mesh/egressFilter (30.60s)
        --- PASS: TestAccAppMesh_serial/Mesh/tags (34.41s)
        --- PASS: TestAccAppMesh_serial/Mesh/dataSourceBasic (13.09s)
        --- PASS: TestAccAppMesh_serial/Mesh/dataSourceMeshOwner (13.54s)
        --- PASS: TestAccAppMesh_serial/Mesh/dataSourceSpecAndTagsSet (13.12s)
        --- SKIP: TestAccAppMesh_serial/Mesh/dataSourceShared (0.00s)
        --- PASS: TestAccAppMesh_serial/Mesh/basic (14.46s)
    --- PASS: TestAccAppMesh_serial/Route (655.58s)
        --- PASS: TestAccAppMesh_serial/Route/httpRoute (38.41s)
        --- PASS: TestAccAppMesh_serial/Route/httpRouteTimeout (27.36s)
        --- PASS: TestAccAppMesh_serial/Route/tcpRouteWithPortMatch (38.52s)
        --- PASS: TestAccAppMesh_serial/Route/dataSourceGRPCRoute (15.72s)
        --- PASS: TestAccAppMesh_serial/Route/grpcRouteTimeout (28.13s)
        --- PASS: TestAccAppMesh_serial/Route/http2Route (28.48s)
        --- PASS: TestAccAppMesh_serial/Route/httpHeader (27.97s)
        --- PASS: TestAccAppMesh_serial/Route/httpRetryPolicy (41.65s)
        --- PASS: TestAccAppMesh_serial/Route/http2RouteWithPortMatch (29.38s)
        --- PASS: TestAccAppMesh_serial/Route/routePriority (28.00s)
        --- PASS: TestAccAppMesh_serial/Route/tcpRoute (39.73s)
        --- PASS: TestAccAppMesh_serial/Route/dataSourceHTTPRoute (15.07s)
        --- PASS: TestAccAppMesh_serial/Route/disappears (14.05s)
        --- PASS: TestAccAppMesh_serial/Route/grpcRouteWithPortMatch (50.31s)
        --- PASS: TestAccAppMesh_serial/Route/http2RouteTimeout (27.49s)
        --- PASS: TestAccAppMesh_serial/Route/dataSourceTCPRoute (14.84s)
        --- PASS: TestAccAppMesh_serial/Route/tags (40.14s)
        --- PASS: TestAccAppMesh_serial/Route/dataSourceHTTP2Route (15.13s)
        --- PASS: TestAccAppMesh_serial/Route/grpcRoute (51.52s)
        --- PASS: TestAccAppMesh_serial/Route/grpcRouteEmptyMatch (16.90s)
        --- PASS: TestAccAppMesh_serial/Route/httpRouteWithPortMatch (39.06s)
        --- PASS: TestAccAppMesh_serial/Route/tcpRouteTimeout (27.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appmesh	2249.472s

@ewbankkit
Copy link
Contributor

@stefangrosaru Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ff70194 into hashicorp:main Mar 23, 2023
@github-actions github-actions bot added this to the v4.60.0 milestone Mar 23, 2023
@github-actions
Copy link

This functionality has been released in v4.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/appmesh Issues and PRs that pertain to the appmesh service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.60.0
Development

Successfully merging this pull request may close these issues.

[New Data Source]: aws_appmesh_route aws_appmesh_mesh data source not working for shared meshes
3 participants
@stefangrosaru @ewbankkit @justinretzolk