Attribute with CreateOnlyProperties that also Optional should use RequiresReplaceIfConfigured plan modifiers

[wellsiau-aws]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment
• The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the CloudFormation Open Coverage Roadmap.

Description

When resource attribute meet the following conditions:

1. marked as CreateOnlyProperties
2. marked as optional

Then the plan modifiers should use RequiresReplaceIfConfigured instead of RequiresReplace

New or Affected Resource(s)

Please refer to 1139 for all relevant issues

Potential Changes

emitters can be updated to accommodate this:

if createOnly {
		if optional {
			// ForceNewIfConfigured.
			planModifiers = append(planModifiers, fmt.Sprintf("%s.RequiresReplaceIfConfigured()", fwPlanModifierPackage))
		} else {
			// ForceNew.
			planModifiers = append(planModifiers, fmt.Sprintf("%s.RequiresReplace()", fwPlanModifierPackage))
		}
		features.FrameworkPlanModifierPackages = append(features.FrameworkPlanModifierPackages, fwPlanModifierPackage)
	}

References

• https://developer.hashicorp.com/terraform/plugin/framework/resources/plan-modification#common-use-case-attribute-plan-modifiers

• awscc_ec2_ipam_pool - update to args has unexpected force new #1139