Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that resource ID is specified when populating Unknown values #229

Merged
merged 4 commits into from
Oct 5, 2021

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Oct 4, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
  • The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the Cloudformation Open Coverage Roadmap.

Closes #225.

Synthetic ID

% TF_LOG=WARN make testacc PKG_NAME=internal/aws/logs TESTARGS='-run=TestAccAWSLogsLogGroup_update'
TF_ACC=1 go test ./internal/aws/logs -v -count 1 -parallel 20 -run=TestAccAWSLogsLogGroup_update -timeout 180m
=== RUN   TestAccAWSLogsLogGroup_update
=== PAUSE TestAccAWSLogsLogGroup_update
=== CONT  TestAccAWSLogsLogGroup_update
--- PASS: TestAccAWSLogsLogGroup_update (42.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-awscc/internal/aws/logs	43.563s

CloudFormation Schema Defined ID

% TF_LOG=WARN make testacc PKG_NAME=internal/aws/ec2 TESTARGS='-run=TestAccAWSEC2VPC_CidrBlock'
TF_ACC=1 go test ./internal/aws/ec2 -v -count 1 -parallel 20 -run=TestAccAWSEC2VPC_CidrBlock -timeout 180m
=== RUN   TestAccAWSEC2VPC_CidrBlock
=== PAUSE TestAccAWSEC2VPC_CidrBlock
=== CONT  TestAccAWSEC2VPC_CidrBlock
    testcases.go:30: Step 1/2 error: After applying this test step and performing a `terraform refresh`, the plan was not empty.
        stdout
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # awscc_ec2_vpc.test will be updated in-place
          ~ resource "awscc_ec2_vpc" "test" {
              - enable_dns_hostnames    = false -> null
              - enable_dns_support      = true -> null
                id                      = "vpc-0e4806ce7aa9ae83d"
              - instance_tenancy        = "default" -> null
                tags                    = [
                    {          },
                  # (1 unchanged element hidden)
                ]
                # (5 unchanged attributes hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccAWSEC2VPC_CidrBlock (52.40s)

Drift is detected because the CFN schema does not specify attribute defaults: #191.

@ewbankkit ewbankkit merged commit 91d9263 into main Oct 5, 2021
@ewbankkit ewbankkit deleted the b-non-synthetic-id-create branch October 5, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VPC creation is failing
1 participant