Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform-plugin-framework@0.5.0+ #306

Merged
merged 14 commits into from
Dec 14, 2021
Merged

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Dec 2, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
  • The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the Cloudformation Open Coverage Roadmap.

Closes #300.
Relates #208.
Closes #222.
Closes #218.
Closes #242.
Closes #219.
Relates #294.
Supersedes #246.
Closes #283.
Closes #317.
Closes #319.

@ewbankkit ewbankkit marked this pull request as draft December 2, 2021 12:41
@ewbankkit ewbankkit force-pushed the f-terraform-plugin-framework@0.5.0 branch from b9c8869 to 4a37d20 Compare December 2, 2021 12:56
@ewbankkit

This comment has been minimized.

@ewbankkit
Copy link
Contributor Author

ewbankkit commented Dec 2, 2021

The immediate S3 Bucket resource recreate bug (#218) has been fixed but has uncovered an issue with resource import:

% TF_LOG=WARN make testacc PKG_NAME=internal/aws/s3 TESTARGS='-run=TestAccAWSS3Bucket_'
TF_ACC=1 go test ./internal/aws/s3 -v -count 1 -parallel 20 -run=TestAccAWSS3Bucket_ -timeout 180m
=== RUN   TestAccAWSS3Bucket_basic
=== PAUSE TestAccAWSS3Bucket_basic
=== RUN   TestAccAWSS3Bucket_disappears
=== PAUSE TestAccAWSS3Bucket_disappears
=== CONT  TestAccAWSS3Bucket_basic
=== CONT  TestAccAWSS3Bucket_disappears
--- PASS: TestAccAWSS3Bucket_disappears (63.51s)
2021/12/02 09:05:52 [WARN] Got error running Terraform: exit status 1

Error: Terraform Resource Attribute Not Set in Import State

Terraform resource attribute not set in Import State. This is typically an
error with the Terraform provider implementation. Original Error: 1 error
occurred:
	* An unexpected error was encountered trying to convert from slice value.
This is always an error in the provider. Please report the following to the
provider developer:

cannot use type reflect.Value as schema type types.ObjectType;
types.ObjectType must be an attr.TypeWithElementType to hold reflect.Value



=== CONT  TestAccAWSS3Bucket_basic
    testcases.go:30: Step 2/2 error running import: exit status 1
        
        Error: Terraform Resource Attribute Not Set in Import State
        
        Terraform resource attribute not set in Import State. This is typically an
        error with the Terraform provider implementation. Original Error: 1 error
        occurred:
        	* An unexpected error was encountered trying to convert from slice value.
        This is always an error in the provider. Please report the following to the
        provider developer:
        
        cannot use type reflect.Value as schema type types.ObjectType;
        types.ObjectType must be an attr.TypeWithElementType to hold reflect.Value
        
        
        
--- FAIL: TestAccAWSS3Bucket_basic (83.08s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-awscc/internal/aws/s3	83.626s
FAIL
make: *** [testacc] Error 1

See hashicorp/terraform-plugin-framework#229.

Fixed by removing setEmptyAttributes which is no longer needed.

@ewbankkit ewbankkit force-pushed the f-terraform-plugin-framework@0.5.0 branch from e823296 to 8631d08 Compare December 3, 2021 15:57
@ewbankkit ewbankkit changed the title terraform-plugin-framework@0.5.0 terraform-plugin-framework@0.5.0+ Dec 14, 2021
@ewbankkit ewbankkit marked this pull request as ready for review December 14, 2021 14:16
dependabot bot and others added 14 commits December 14, 2021 14:47
Bumps [github.com/hashicorp/terraform-plugin-framework](https://github.com/hashicorp/terraform-plugin-framework) from 0.4.1 to 0.5.0.
- [Release notes](https://github.com/hashicorp/terraform-plugin-framework/releases)
- [Changelog](https://github.com/hashicorp/terraform-plugin-framework/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-plugin-framework@v0.4.1...v0.5.0)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/terraform-plugin-framework
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@ewbankkit ewbankkit force-pushed the f-terraform-plugin-framework@0.5.0 branch from e8f217e to d706232 Compare December 14, 2021 19:47
@ewbankkit ewbankkit merged commit f09a3a8 into main Dec 14, 2021
@ewbankkit ewbankkit deleted the f-terraform-plugin-framework@0.5.0 branch December 14, 2021 20:03
@ewbankkit ewbankkit mentioned this pull request Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment