Wait on password replication #117
Conversation
There was a problem hiding this comment.
Hi @jlpedrosa,
Thank you for the PR, I've left one comment inline. I think we just need to change the API call we are making and it should work just fine.
| @@ -58,6 +58,13 @@ func resourceServicePrincipalPasswordCreate(d *schema.ResourceData, meta interfa | |||
|
|
|||
| d.SetId(id.String()) | |||
|
|
|||
| _, err = graph.WaitForReplication(func() (interface{}, error) { | |||
| return client.Get(ctx, id.ObjectId) | |||
There was a problem hiding this comment.
So i think this should be:
| return client.Get(ctx, id.ObjectId) | |
| return client.ListPasswordCredentials(ctx, id.ObjectId) |
as that is how we are checking if the credentials exist?
|
This has been released in version 0.5.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azuread" {
version = "~> 0.5.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Hi @katbyte
This PR waits on Password replication, same as done in #93 for Application and service principal.
Please note that I have not run the integration tests as get a workable AAD, may be bit complex for me.